DYN-6073 Civil 3D - Crash, if closing "Search for Packages"dialog before closing "Interactive Guides" #14338

RobertGlobant20 · 2023-08-28T20:10:30Z

Purpose

Fix1 for Packages tour (preventing crash)
This change is disabling the close button in the PackageManagerSearch window when running the Packages tour, when passing to the next Step the button is enabled again (unless the next step also requires to disable the button). I've added a new icon image that will be shown when the close button is disabled.

Declarations

Check these if you believe they are true

The codebase is in a better state after this PR
Is documented according to the standards
The level of testing this PR includes is appropriate
User facing strings, if any, are extracted into *.resx files
All tests pass using the self-service CI.
Snapshot of UI changes, if any.
Changes to the API follow Semantic Versioning and are documented in the API Changes document.
This PR modifies some build requirements and the readme is updated
This PR contains no files larger than 50 MB

Release Notes

Fix1 for Packages tour (preventing crash)

Reviewers

@QilongTang

FYIs

It was crashing due that the user tried to close the Step 4 clicking the PackageSearch window and the Popup is not closed but seems that is already disposed.

This change is disabling the close button in the PackageManagerSearch window when running the Packages tour, when passing to the next Step the button is enabled again (unless the next step also requires to disable the button). I've added a new icon image that will be shown when the close button is disabled. In this way we will be preventing the crash when the user try to close the Packages tour by closing the PackageManagerSearch window

RobertGlobant20 · 2023-08-28T20:11:22Z

This is a GIF showing the behavior of the packages guide until Step5

This fix will solve the problem of the packages guide crashing when clicking the Library (package installed) for passing from Step8 to Step9.

RobertGlobant20 · 2023-08-29T00:33:15Z

@QilongTang due that at the end the change in the Library was not needed (was crashing when passing from Step8 to Step8) I've include it in this PR.

QilongTang · 2023-08-29T02:01:29Z

src/LibraryViewExtensionWebView2/web/library/library.html

                found_div.parentNode.parentNode.addEventListener('click', nextStepInGuide);
            }
            else {
-                found_div.removeEventListener('click', nextStepInGuide);
-                found_div.parentNode.removeEventListener('click', nextStepInGuide);


So this has been broken since we add this tour?

Probably as I was saying in the standup the change from MS WebBrowser to WebView2 introduced the bug (but I'm not sure about it). I've tested since 2.13 and the packages tour doesn't crash when you click the Library package but it doesn't go to the next Step.

QilongTang · 2023-08-29T15:03:23Z

@RobertGlobant20 Please cherry-pick

* DYN-6073 civil3 d packages tour crashing (#14338) * DYN-6073 Civil3D Packages Guide Crashing It was crashing due that the user tried to close the Step 4 clicking the PackageSearch window and the Popup is not closed but seems that is already disposed. * DYN-6073 Civil3D Package Tour Crashing This change is disabling the close button in the PackageManagerSearch window when running the Packages tour, when passing to the next Step the button is enabled again (unless the next step also requires to disable the button). I've added a new icon image that will be shown when the close button is disabled. In this way we will be preventing the crash when the user try to close the Packages tour by closing the PackageManagerSearch window * DYN-6073 Civil3D Package Tour Crashing This fix will solve the problem of the packages guide crashing when clicking the Library (package installed) for passing from Step8 to Step9. * Fixing Cherry-Pick When creating the cherry-pick for RC2.19_master branch I noticed some changes that I didn't do, so I'm reverting those changes.

* DYN-6073 Civil3D Packages Guide Crashing It was crashing due that the user tried to close the Step 4 clicking the PackageSearch window and the Popup is not closed but seems that is already disposed. * DYN-6073 Civil3D Package Tour Crashing This change is disabling the close button in the PackageManagerSearch window when running the Packages tour, when passing to the next Step the button is enabled again (unless the next step also requires to disable the button). I've added a new icon image that will be shown when the close button is disabled. In this way we will be preventing the crash when the user try to close the Packages tour by closing the PackageManagerSearch window * DYN-6073 Civil3D Package Tour Crashing This fix will solve the problem of the packages guide crashing when clicking the Library (package installed) for passing from Step8 to Step9.

* [DYN-4302 + DYN-5259] Add visual indication for deprecated packages (#13413) * add deprecated label * update extension * sync package manger and package view displays * finishes * set horizontal offset * update HD profile icon * Update PackageDetailsViewModel.cs * add comment * conflicts fix * Update PackageDetailItem.cs * Revert "conflicts fix" This reverts commit 2e60462. * conflict fix2 * DYN-3652 docs browser Artifakt font fails if not installed (#13654) * Embedded Artifakt Element as base64 - to ensure the DocumentationBrowser always loads with the correct font, the Artifakt Element font is now included in the css style sheet as base64 * Refactored font resource - now substitutes an embedded resource containing the font style and converts to base64 before rendering the html page * Revert unnecessary changes * FontFace Css rule reintroduced - brought back a fontface css rule to be whitelisted by the Md2HtmlSanitizer - all DocumentationBrowserExtension tests passing * DYN-5297 Import Excel Small Numbers (#13680) * read scientific notation * remove unecessary reference * Fix for situation with formulas and add unit tests for scientific notation * Dyn 5314 open xml (#13647) * Fix String display * Adding Unit test * Checking Formula * Fixing Ghost warning (#13820) * Fixing Ghost warning * Keeping the Warning Color for the new state * Adding the Unit test * Revert "Keeping the Warning Color for the new state" This reverts commit 40e9643. * Revert "Fixing Ghost warning" This reverts commit 04c14c1. * Updates, Implementation and Test * fix List.AllIndicesOf node (#13773) * Handle null values in watch node/preview bubble (#13855) * Handle null values in watch node/preview bubble * Add test * Update WatchNodeTests.cs * Add null check (#13908) * DYN-6073 civil3 d packages tour crashing (#14338) * DYN-6073 Civil3D Packages Guide Crashing It was crashing due that the user tried to close the Step 4 clicking the PackageSearch window and the Popup is not closed but seems that is already disposed. * DYN-6073 Civil3D Package Tour Crashing This change is disabling the close button in the PackageManagerSearch window when running the Packages tour, when passing to the next Step the button is enabled again (unless the next step also requires to disable the button). I've added a new icon image that will be shown when the close button is disabled. In this way we will be preventing the crash when the user try to close the Packages tour by closing the PackageManagerSearch window * DYN-6073 Civil3D Package Tour Crashing This fix will solve the problem of the packages guide crashing when clicking the Library (package installed) for passing from Step8 to Step9. * Update to remove extra code * Remove the test causing build failure * DYN-6123 Fix groups loose associations with notes and nested groups when a custom node is created (#14220) * Fix note in group in customnode * add test * merge test from other PR * DYN-6130 remove the toast notification (#14317) (#14332) * Make sure close the Toast notification when Dynamo closes * Removing extra file * Removing extra file * Relocate the responsibility about the toast notification to the DynamoViewModel * removing unnecessary using * take advantage of already implementation to apply minimal changes * Moving the code to a proper place --------- Co-authored-by: Jesus Alfredo Alviño <[email protected]> * DependencyType match (#14314) * remove extra code --------- Co-authored-by: Ashish Aggarwal <[email protected]> Co-authored-by: Deyan Nenov <[email protected]> Co-authored-by: filipeotero <[email protected]> Co-authored-by: jesusalvino <[email protected]> Co-authored-by: aparajit-pratap <[email protected]> Co-authored-by: reddyashish <[email protected]> Co-authored-by: Roberto T <[email protected]> Co-authored-by: Jesus Alfredo Alviño <[email protected]>

* DYN-6073 Civil3D Packages Guide Crashing It was crashing due that the user tried to close the Step 4 clicking the PackageSearch window and the Popup is not closed but seems that is already disposed. * DYN-6073 Civil3D Package Tour Crashing This change is disabling the close button in the PackageManagerSearch window when running the Packages tour, when passing to the next Step the button is enabled again (unless the next step also requires to disable the button). I've added a new icon image that will be shown when the close button is disabled. In this way we will be preventing the crash when the user try to close the Packages tour by closing the PackageManagerSearch window * DYN-6073 Civil3D Package Tour Crashing This fix will solve the problem of the packages guide crashing when clicking the Library (package installed) for passing from Step8 to Step9. (cherry picked from commit 0c9eeb7)

RobertGlobant20 added 2 commits August 23, 2023 11:10

DYN-6073 Civil3D Packages Guide Crashing

7d3fc81

It was crashing due that the user tried to close the Step 4 clicking the PackageSearch window and the Popup is not closed but seems that is already disposed.

RobertGlobant20 requested a review from QilongTang August 28, 2023 20:10

QilongTang added this to the 2.19.0 milestone Aug 28, 2023

QilongTang approved these changes Aug 28, 2023

View reviewed changes

DYN-6073 Civil3D Package Tour Crashing

89d2cee

This fix will solve the problem of the packages guide crashing when clicking the Library (package installed) for passing from Step8 to Step9.

QilongTang reviewed Aug 29, 2023

View reviewed changes

QilongTang merged commit 0c9eeb7 into DynamoDS:master Aug 29, 2023

RobertGlobant20 mentioned this pull request Aug 29, 2023

Cherry-Pick-DYN-6073 civil3 d packages tour crashing (#14338) #14343

Merged

9 tasks

QilongTang changed the title ~~DYN-6073 civil3 d packages tour crashing~~ DYN-6073 Civil 3D - Crash, if closing "Search for Packages"dialog before closing "Interactive Guides" Mar 26, 2024

QilongTang mentioned this pull request Mar 26, 2024

2.16.3 CherryPicks Morpheus #15052

Merged

9 tasks

twastvedt mentioned this pull request Sep 23, 2024

DYN-7475: Cherry picks for 2.16.4 #15499

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DYN-6073 Civil 3D - Crash, if closing "Search for Packages"dialog before closing "Interactive Guides" #14338

DYN-6073 Civil 3D - Crash, if closing "Search for Packages"dialog before closing "Interactive Guides" #14338

RobertGlobant20 commented Aug 28, 2023

RobertGlobant20 commented Aug 28, 2023

RobertGlobant20 commented Aug 29, 2023

QilongTang Aug 29, 2023

RobertGlobant20 Aug 29, 2023

QilongTang commented Aug 29, 2023

DYN-6073 Civil 3D - Crash, if closing "Search for Packages"dialog before closing "Interactive Guides" #14338

DYN-6073 Civil 3D - Crash, if closing "Search for Packages"dialog before closing "Interactive Guides" #14338

Conversation

RobertGlobant20 commented Aug 28, 2023

Purpose

Declarations

Release Notes

Reviewers

FYIs

RobertGlobant20 commented Aug 28, 2023

RobertGlobant20 commented Aug 29, 2023

QilongTang Aug 29, 2023

Choose a reason for hiding this comment

RobertGlobant20 Aug 29, 2023

Choose a reason for hiding this comment

QilongTang commented Aug 29, 2023