DYN-5297 Import Excel Small Numbers #13680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipeotero
changed the title
|
There is one reported regression DynamoMSOfficeTests.OpenXmlTests.TestFormula, can you take a look? |
Thanks Aaron! I will also add a test containing a scientific notation example. |
QilongTang
approved these changes
Jan 17, 2023
9 tasks
QilongTang
pushed a commit
that referenced
this pull request
Mar 26, 2024
* read scientific notation * remove unecessary reference * Fix for situation with formulas and add unit tests for scientific notation
QilongTang
added a commit
that referenced
this pull request
Mar 26, 2024
* [DYN-4302 + DYN-5259] Add visual indication for deprecated packages (#13413) * add deprecated label * update extension * sync package manger and package view displays * finishes * set horizontal offset * update HD profile icon * Update PackageDetailsViewModel.cs * add comment * conflicts fix * Update PackageDetailItem.cs * Revert "conflicts fix" This reverts commit 2e60462. * conflict fix2 * DYN-3652 docs browser Artifakt font fails if not installed (#13654) * Embedded Artifakt Element as base64 - to ensure the DocumentationBrowser always loads with the correct font, the Artifakt Element font is now included in the css style sheet as base64 * Refactored font resource - now substitutes an embedded resource containing the font style and converts to base64 before rendering the html page * Revert unnecessary changes * FontFace Css rule reintroduced - brought back a fontface css rule to be whitelisted by the Md2HtmlSanitizer - all DocumentationBrowserExtension tests passing * DYN-5297 Import Excel Small Numbers (#13680) * read scientific notation * remove unecessary reference * Fix for situation with formulas and add unit tests for scientific notation * Dyn 5314 open xml (#13647) * Fix String display * Adding Unit test * Checking Formula * Fixing Ghost warning (#13820) * Fixing Ghost warning * Keeping the Warning Color for the new state * Adding the Unit test * Revert "Keeping the Warning Color for the new state" This reverts commit 40e9643. * Revert "Fixing Ghost warning" This reverts commit 04c14c1. * Updates, Implementation and Test * fix List.AllIndicesOf node (#13773) * Handle null values in watch node/preview bubble (#13855) * Handle null values in watch node/preview bubble * Add test * Update WatchNodeTests.cs * Add null check (#13908) * DYN-6073 civil3 d packages tour crashing (#14338) * DYN-6073 Civil3D Packages Guide Crashing It was crashing due that the user tried to close the Step 4 clicking the PackageSearch window and the Popup is not closed but seems that is already disposed. * DYN-6073 Civil3D Package Tour Crashing This change is disabling the close button in the PackageManagerSearch window when running the Packages tour, when passing to the next Step the button is enabled again (unless the next step also requires to disable the button). I've added a new icon image that will be shown when the close button is disabled. In this way we will be preventing the crash when the user try to close the Packages tour by closing the PackageManagerSearch window * DYN-6073 Civil3D Package Tour Crashing This fix will solve the problem of the packages guide crashing when clicking the Library (package installed) for passing from Step8 to Step9. * Update to remove extra code * Remove the test causing build failure * DYN-6123 Fix groups loose associations with notes and nested groups when a custom node is created (#14220) * Fix note in group in customnode * add test * merge test from other PR * DYN-6130 remove the toast notification (#14317) (#14332) * Make sure close the Toast notification when Dynamo closes * Removing extra file * Removing extra file * Relocate the responsibility about the toast notification to the DynamoViewModel * removing unnecessary using * take advantage of already implementation to apply minimal changes * Moving the code to a proper place --------- Co-authored-by: Jesus Alfredo Alviño <[email protected]> * DependencyType match (#14314) * remove extra code --------- Co-authored-by: Ashish Aggarwal <[email protected]> Co-authored-by: Deyan Nenov <[email protected]> Co-authored-by: filipeotero <[email protected]> Co-authored-by: jesusalvino <[email protected]> Co-authored-by: aparajit-pratap <[email protected]> Co-authored-by: reddyashish <[email protected]> Co-authored-by: Roberto T <[email protected]> Co-authored-by: Jesus Alfredo Alviño <[email protected]>
Mikhinja
reviewed
Aug 28, 2024
| @@ -345,7 +345,7 @@ private static object GetCellValue(Cell cell, SharedStringTable sharedStringTabl | |||
| else | |||
| { | |||
| // This is a number | |||
| if (cell.CellValue.TryGetDouble(out var value)) | |||
| if (double.TryParse(cell.CellValue.InnerText, NumberStyles.Any, NumberFormatInfo.InvariantInfo, out var value)) | |||
There was a problem hiding this comment.
Have we tested change in behavior when digit separator is changed (from OS settings)?
There was a problem hiding this comment.
Possible use case: customer distributes a spreadsheet with per-cell number formatting to at least 2 different users in 2 different locations with different OS settings relating to number formatting (digit separator). Did the previous function work for both OS settings and does the new one not work the same?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The purpose of this PR is to fix scientific notation values that are read from Excel files.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@QilongTang