Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DYN-6158 Dynamo crashes upon removing item for Package publish list #14314

Merged
merged 1 commit into from
Aug 25, 2023
Merged

DYN-6158 Dynamo crashes upon removing item for Package publish list #14314

merged 1 commit into from
Aug 25, 2023

Conversation

QilongTang
Copy link
Contributor

@QilongTang QilongTang commented Aug 24, 2023 •
edited
Loading

Please Note:

  1. Before submitting the PR, please review How to Contribute to Dynamo
  2. Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
  3. PRs will be reviewed from oldest to newest
  4. If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
  5. PRs should use either Dynamo's default PR template or one of these other template options in order to be considered for review.
  6. PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
  7. PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.

Purpose

Per DYN-6158, fix the bug when removing a dyf in publish package dialog, Dynamo would crash. Also fixes #13325
RemoveDyf

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Fix the bug when removing a dyf in publish package dialog, Dynamo would crash

Reviewers

@DynamoDS/dynamo

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@QilongTang QilongTang requested a review from zeusongit August 24, 2023 16:49
@QilongTang QilongTang added this to the 2.19.0 milestone Aug 24, 2023
@QilongTang
Copy link
Contributor Author

@avidit We may want to consider adding this case to the test complete test suite

@github-actions
Copy link

⚠️ [run-bin-diff] - Files Added/Deleted::72 new file(s) have been added and 154 file(s) have been deleted!
⚠️ [run-bin-diff-net60-windows] - Files Added/Deleted::11 new file(s) have been added and 29 file(s) have been deleted!

@QilongTang QilongTang requested a review from avidit August 24, 2023 18:14
@QilongTang QilongTang merged commit 87c6b57 into RC2.19.0_master Aug 25, 2023
@QilongTang QilongTang deleted the DependencyTypeMatch branch August 25, 2023 15:06
QilongTang added a commit that referenced this pull request Aug 25, 2023
@QilongTang
DependencyType match (#14314)
3000eda
@QilongTang QilongTang mentioned this pull request Aug 25, 2023
Merged
9 tasks
QilongTang added a commit that referenced this pull request Aug 25, 2023
@QilongTang
DependencyType match (#14314) (#14320)
63645f8
@QilongTang QilongTang changed the title DYN-6158 Package content DependencyType match DYN-6158 Dynamo crashes upon removing item for Package publish list Mar 26, 2024
@QilongTang QilongTang mentioned this pull request Mar 26, 2024
Merged
9 tasks
QilongTang added a commit that referenced this pull request Mar 26, 2024
@QilongTang
DependencyType match (#14314)
c2d6009
QilongTang added a commit that referenced this pull request Mar 26, 2024
@QilongTang @zeusongit
@dnenov @filipeotero @jesusalvino @aparajit-pratap @reddyashish @RobertGlobant20
2.16.3 CherryPicks Morpheus (#15052)
0380b5b 
* [DYN-4302 + DYN-5259] Add visual indication for deprecated packages (#13413)

* add deprecated label

* update extension

* sync package manger and package view displays

* finishes

* set horizontal offset

* update HD profile icon

* Update PackageDetailsViewModel.cs

* add comment

* conflicts fix

* Update PackageDetailItem.cs

* Revert "conflicts fix"

This reverts commit 2e60462.

* conflict fix2

* DYN-3652 docs browser Artifakt font fails if not installed (#13654)

* Embedded Artifakt Element as base64

- to ensure the DocumentationBrowser always loads with the correct font, the Artifakt Element font is now included in the css style sheet as base64

* Refactored font resource

- now substitutes an embedded resource containing the font style and converts to base64 before rendering the html page

* Revert unnecessary changes

* FontFace Css rule reintroduced

- brought back a fontface css rule to be whitelisted by the Md2HtmlSanitizer
- all DocumentationBrowserExtension tests passing

* DYN-5297 Import Excel Small Numbers (#13680)

* read scientific notation

* remove unecessary reference

* Fix for situation with formulas and add unit tests for scientific notation

* Dyn 5314 open xml (#13647)

* Fix String display

* Adding Unit test

* Checking Formula

* Fixing Ghost warning (#13820)

* Fixing Ghost warning

* Keeping the Warning Color for the new state

* Adding the Unit test

* Revert "Keeping the Warning Color for the new state"

This reverts commit 40e9643.

* Revert "Fixing Ghost warning"

This reverts commit 04c14c1.

* Updates, Implementation and Test

* fix List.AllIndicesOf node (#13773)

* Handle null values in watch node/preview bubble (#13855)

* Handle null values in watch node/preview bubble

* Add test

* Update WatchNodeTests.cs

* Add null check (#13908)

* DYN-6073 civil3 d packages tour crashing (#14338)

* DYN-6073 Civil3D Packages Guide Crashing

It was crashing due that the user tried to close the Step 4 clicking the PackageSearch window and the Popup is not closed but seems that is already disposed.

* DYN-6073 Civil3D Package Tour Crashing

This change is disabling the close button in the PackageManagerSearch window when running the Packages tour, when passing to the next Step the button is enabled again (unless the next step also requires to disable the button). I've added a new icon image that will be shown when the close button is disabled.
In this way we will be preventing the crash when the user try to close the Packages tour by closing the PackageManagerSearch window

* DYN-6073 Civil3D Package Tour Crashing

This fix will solve the problem of the packages guide crashing when clicking the Library (package installed) for passing from Step8 to Step9.

* Update to remove extra code

* Remove the test causing build failure

* DYN-6123 Fix groups loose associations with notes and nested groups when a custom node is created (#14220)

* Fix note in group in customnode

* add test

* merge test from other PR

* DYN-6130 remove the toast notification (#14317) (#14332)

* Make sure close the Toast notification when Dynamo closes

* Removing extra file

* Removing extra file

* Relocate the responsibility about the toast notification to the DynamoViewModel

* removing unnecessary using

* take advantage of already implementation to apply minimal changes

* Moving the code to a proper place

---------

Co-authored-by: Jesus Alfredo Alviño <[email protected]>

* DependencyType  match (#14314)

* remove extra code

---------

Co-authored-by: Ashish Aggarwal <[email protected]>
Co-authored-by: Deyan Nenov <[email protected]>
Co-authored-by: filipeotero <[email protected]>
Co-authored-by: jesusalvino <[email protected]>
Co-authored-by: aparajit-pratap <[email protected]>
Co-authored-by: reddyashish <[email protected]>
Co-authored-by: Roberto T <[email protected]>
Co-authored-by: Jesus Alfredo Alviño <[email protected]>
twastvedt pushed a commit that referenced this pull request Sep 19, 2024
@QilongTang @twastvedt
DependencyType match (#14314)
5070b31 
(cherry picked from commit 87c6b57)
@twastvedt twastvedt mentioned this pull request Sep 23, 2024
Merged
9 tasks
twastvedt pushed a commit that referenced this pull request Sep 30, 2024
@QilongTang @twastvedt
DependencyType match (#14314)
750000b 
(cherry picked from commit 87c6b57)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avidit avidit avidit approved these changes

@zeusongit zeusongit Awaiting requested review from zeusongit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.19.0
Development

Successfully merging this pull request may close these issues.
2 participants
@QilongTang @avidit