DYN-6130 remove the toast notification #14317

jesusalvino · 2023-08-24T19:19:10Z

Purpose

Making sure close the toast notification from the Preferences when Dynamo closes, bug https://jira.autodesk.com/browse/DYN-6130

Declarations

Check these if you believe they are true

The codebase is in a better state after this PR
Is documented according to the standards
The level of testing this PR includes is appropriate
User facing strings, if any, are extracted into *.resx files
All tests pass using the self-service CI.
Snapshot of UI changes, if any.
Changes to the API follow Semantic Versioning and are documented in the API Changes document.
This PR modifies some build requirements and the readme is updated
This PR contains no files larger than 50 MB

Reviewers

@QilongTang
@RobertGlobant20

FYIs

@Enzo707

jesusalvino · 2023-08-24T19:19:31Z

Dynamo Sandbox

jesusalvino · 2023-08-24T19:19:42Z

D4R

github-actions · 2023-08-24T19:32:12Z

⚠️ [run-bin-diff] - Files Added/Deleted::72 new file(s) have been added and 153 file(s) have been deleted!
⚠️ [run-bin-diff-net60-windows] - Files Added/Deleted::12 new file(s) have been added and 29 file(s) have been deleted!
(Updated: 2023-08-25-17:18:47)

src/DynamoCoreWpf/ViewModels/Menu/PreferencesViewModel.cs

mjkkirschner · 2023-08-24T19:43:14Z

please try to add a regression test.

…oViewModel

src/DynamoCoreWpf/UI/GuidedTour/GuidesManager.cs

src/DynamoCoreWpf/ViewModels/Core/DynamoViewModel.cs

QilongTang · 2023-08-25T17:00:02Z

src/DynamoCoreWpf/ViewModels/Core/DynamoViewModel.cs

@@ -3419,6 +3419,7 @@ public bool PerformShutdownSequence(ShutdownParams shutdownParams)
            WatchHandler.RequestSelectGeometry -= BackgroundPreviewViewModel.AddLabelForPath;
            model.ComputeModelDeserialized -= model_ComputeModelDeserialized;
            model.RequestNotification -= model_RequestNotification;
+            MainGuideManager?.CloseRealTimeInfoWindow();


Thanks @jesusalvino Can you move this line to below BackgroundPreviewViewModel.Dispose();? The section below is for DynamoModel shutdown, maybe we are missing a comment there. Can you add that as well?

QilongTang · 2023-08-25T18:34:47Z

Passed at https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/10887/. Please also cherry-pick to master branch.

QilongTang · 2023-08-25T19:09:12Z

The gif for D4R is way too long, can we not demonstrate the host application opening as part of the gif? I would love a gif from only when user launches D4R inside Revit to the end of the experience

jesusalvino · 2023-08-25T20:51:18Z

The gif for D4R is way too long, can we not demonstrate the host application opening as part of the gif? I would love a gif from only when user launches D4R inside Revit to the end of the experience

Done

jesusalvino · 2023-08-25T21:51:23Z

Passed at https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/10887/. Please also cherry-pick to master branch.

CP #14332

jesusalvino · 2023-08-28T14:57:18Z

The gif for D4R is way too long, can we not demonstrate the host application opening as part of the gif? I would love a gif from only when user launches D4R inside Revit to the end of the experience

Done

@QilongTang the D4R gif has been updated.

* Make sure close the Toast notification when Dynamo closes * Removing extra file * Removing extra file * Relocate the responsibility about the toast notification to the DynamoViewModel * removing unnecessary using * take advantage of already implementation to apply minimal changes * Moving the code to a proper place --------- Co-authored-by: Jesus Alfredo Alviño <[email protected]>

jesusalvino · 2023-08-29T01:51:06Z

please try to add a regression test.

@mjkkirschner here you are #14340

* Make sure close the Toast notification when Dynamo closes * Removing extra file * Removing extra file * Relocate the responsibility about the toast notification to the DynamoViewModel * removing unnecessary using * take advantage of already implementation to apply minimal changes * Moving the code to a proper place --------- Co-authored-by: Jesus Alfredo Alviño <[email protected]>

* [DYN-4302 + DYN-5259] Add visual indication for deprecated packages (#13413) * add deprecated label * update extension * sync package manger and package view displays * finishes * set horizontal offset * update HD profile icon * Update PackageDetailsViewModel.cs * add comment * conflicts fix * Update PackageDetailItem.cs * Revert "conflicts fix" This reverts commit 2e60462. * conflict fix2 * DYN-3652 docs browser Artifakt font fails if not installed (#13654) * Embedded Artifakt Element as base64 - to ensure the DocumentationBrowser always loads with the correct font, the Artifakt Element font is now included in the css style sheet as base64 * Refactored font resource - now substitutes an embedded resource containing the font style and converts to base64 before rendering the html page * Revert unnecessary changes * FontFace Css rule reintroduced - brought back a fontface css rule to be whitelisted by the Md2HtmlSanitizer - all DocumentationBrowserExtension tests passing * DYN-5297 Import Excel Small Numbers (#13680) * read scientific notation * remove unecessary reference * Fix for situation with formulas and add unit tests for scientific notation * Dyn 5314 open xml (#13647) * Fix String display * Adding Unit test * Checking Formula * Fixing Ghost warning (#13820) * Fixing Ghost warning * Keeping the Warning Color for the new state * Adding the Unit test * Revert "Keeping the Warning Color for the new state" This reverts commit 40e9643. * Revert "Fixing Ghost warning" This reverts commit 04c14c1. * Updates, Implementation and Test * fix List.AllIndicesOf node (#13773) * Handle null values in watch node/preview bubble (#13855) * Handle null values in watch node/preview bubble * Add test * Update WatchNodeTests.cs * Add null check (#13908) * DYN-6073 civil3 d packages tour crashing (#14338) * DYN-6073 Civil3D Packages Guide Crashing It was crashing due that the user tried to close the Step 4 clicking the PackageSearch window and the Popup is not closed but seems that is already disposed. * DYN-6073 Civil3D Package Tour Crashing This change is disabling the close button in the PackageManagerSearch window when running the Packages tour, when passing to the next Step the button is enabled again (unless the next step also requires to disable the button). I've added a new icon image that will be shown when the close button is disabled. In this way we will be preventing the crash when the user try to close the Packages tour by closing the PackageManagerSearch window * DYN-6073 Civil3D Package Tour Crashing This fix will solve the problem of the packages guide crashing when clicking the Library (package installed) for passing from Step8 to Step9. * Update to remove extra code * Remove the test causing build failure * DYN-6123 Fix groups loose associations with notes and nested groups when a custom node is created (#14220) * Fix note in group in customnode * add test * merge test from other PR * DYN-6130 remove the toast notification (#14317) (#14332) * Make sure close the Toast notification when Dynamo closes * Removing extra file * Removing extra file * Relocate the responsibility about the toast notification to the DynamoViewModel * removing unnecessary using * take advantage of already implementation to apply minimal changes * Moving the code to a proper place --------- Co-authored-by: Jesus Alfredo Alviño <[email protected]> * DependencyType match (#14314) * remove extra code --------- Co-authored-by: Ashish Aggarwal <[email protected]> Co-authored-by: Deyan Nenov <[email protected]> Co-authored-by: filipeotero <[email protected]> Co-authored-by: jesusalvino <[email protected]> Co-authored-by: aparajit-pratap <[email protected]> Co-authored-by: reddyashish <[email protected]> Co-authored-by: Roberto T <[email protected]> Co-authored-by: Jesus Alfredo Alviño <[email protected]>

* Make sure close the Toast notification when Dynamo closes * Removing extra file * Removing extra file * Relocate the responsibility about the toast notification to the DynamoViewModel * removing unnecessary using * take advantage of already implementation to apply minimal changes * Moving the code to a proper place --------- Co-authored-by: Jesus Alfredo Alviño <[email protected]> (cherry picked from commit 596f4fa) # Conflicts: # src/DynamoCoreWpf/ViewModels/Core/DynamoViewModel.cs

Jesus Alfredo Alviño added 3 commits August 24, 2023 13:39

Make sure close the Toast notification when Dynamo closes

2f15a54

Removing extra file

e87e55b

Removing extra file

7c6fbf5

mjkkirschner reviewed Aug 24, 2023

View reviewed changes

src/DynamoCoreWpf/ViewModels/Menu/PreferencesViewModel.cs Outdated Show resolved Hide resolved

mjkkirschner reviewed Aug 24, 2023

View reviewed changes

src/DynamoCoreWpf/ViewModels/Menu/PreferencesViewModel.cs Outdated Show resolved Hide resolved

Relocate the responsibility about the toast notification to the Dynam…

717f6f7

…oViewModel

QilongTang reviewed Aug 25, 2023

View reviewed changes

src/DynamoCoreWpf/UI/GuidedTour/GuidesManager.cs Outdated Show resolved Hide resolved

QilongTang reviewed Aug 25, 2023

View reviewed changes

src/DynamoCoreWpf/ViewModels/Core/DynamoViewModel.cs Outdated Show resolved Hide resolved

Jesus Alfredo Alviño added 2 commits August 25, 2023 11:22

removing unnecessary using

9058b06

take advantage of already implementation to apply minimal changes

7bbcc17

QilongTang reviewed Aug 25, 2023

View reviewed changes

Moving the code to a proper place

6425251

QilongTang added this to the 2.19.0 milestone Aug 25, 2023

QilongTang approved these changes Aug 25, 2023

View reviewed changes

QilongTang merged commit 596f4fa into DynamoDS:RC2.19.0_master Aug 25, 2023

jesusalvino mentioned this pull request Aug 28, 2023

DYN-6130 Toast notification stays open even after dynamo addin is closed (#14317) #14332

Merged

9 tasks

jesusalvino mentioned this pull request Aug 29, 2023

Adding the Unit Test TestToastNotificationClosingBehavior #14340

Merged

9 tasks

QilongTang mentioned this pull request Mar 26, 2024

2.16.3 CherryPicks Morpheus #15052

Merged

9 tasks

twastvedt mentioned this pull request Sep 23, 2024

DYN-7475: Cherry picks for 2.16.4 #15499

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DYN-6130 remove the toast notification #14317

DYN-6130 remove the toast notification #14317

jesusalvino commented Aug 24, 2023

jesusalvino commented Aug 24, 2023 •

edited

Loading

jesusalvino commented Aug 24, 2023 •

edited

Loading

github-actions bot commented Aug 24, 2023 •

edited

Loading

mjkkirschner commented Aug 24, 2023 •

edited

Loading

QilongTang Aug 25, 2023 •

edited

Loading

QilongTang commented Aug 25, 2023

QilongTang commented Aug 25, 2023

jesusalvino commented Aug 25, 2023

jesusalvino commented Aug 25, 2023

jesusalvino commented Aug 28, 2023

jesusalvino commented Aug 29, 2023

DYN-6130 remove the toast notification #14317

DYN-6130 remove the toast notification #14317

Conversation

jesusalvino commented Aug 24, 2023

Purpose

Declarations

Reviewers

FYIs

jesusalvino commented Aug 24, 2023 • edited Loading

jesusalvino commented Aug 24, 2023 • edited Loading

github-actions bot commented Aug 24, 2023 • edited Loading

mjkkirschner commented Aug 24, 2023 • edited Loading

QilongTang Aug 25, 2023 • edited Loading

Choose a reason for hiding this comment

QilongTang commented Aug 25, 2023

QilongTang commented Aug 25, 2023

jesusalvino commented Aug 25, 2023

jesusalvino commented Aug 25, 2023

jesusalvino commented Aug 28, 2023

jesusalvino commented Aug 29, 2023

jesusalvino commented Aug 24, 2023 •

edited

Loading

jesusalvino commented Aug 24, 2023 •

edited

Loading

github-actions bot commented Aug 24, 2023 •

edited

Loading

mjkkirschner commented Aug 24, 2023 •

edited

Loading

QilongTang Aug 25, 2023 •

edited

Loading