Dyn5272 #13334

mjkkirschner · 2022-09-22T21:29:17Z

Purpose

a continuation of @aparajit-pratap 's work started here:
#13331
and here:
#13221

We have issues using the input optimization that was put in place to skip recompiling primitive inputs when executing complex UI nodes where their AST produces primitive values sometimes and complex values other times - for example, the Revit Face selection node which returns null sometimes (a primitive) and the result of a function call other times.

We check the previous assignment statement for the node's output identifier to determine if the previous result was a primitive before attempting to apply any input optimization and skip compilation.

We have verified this fixes the Revit regressions with selection nodes using RTF.

Declarations

Check these if you believe they are true

The codebase is in a better state after this PR
Is documented according to the standards
The level of testing this PR includes is appropriate
User facing strings, if any, are extracted into *.resx files
All tests pass using the self-service CI.
Snapshot of UI changes, if any.
Changes to the API follow Semantic Versioning and are documented in the API Changes document.
This PR modifies some build requirements and the readme is updated

Release Notes

Fixes regression with selection nodes in Revit.

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

src/Engine/ProtoScript/Runners/LiveRunner.cs

tests pass - merging this then will send cherry pick

* add nunit test adapter for 2022 (#13313) * add nunit test adapter for 2022 * update * Update Setup.cs * update * Update DynamoCore.csproj * Create System.Net.Http.dll * update * update Co-authored-by: pinzart <[email protected]> * Filter Mouse Pressed Removed (#13319) - removed flashing white color on mouse pressed for the filter ui element * Fixing horizontal center (#13312) * Update Node AutoComplete Dialog Visuals (#13329) * Update Node AutoComplete Visuals * Reuse style from central location * Add editorconfig (#13233) * Dyn5272 (#13334) tests pass - merging this then will send cherry pick * Dyn 5159 import export preferences (#13301) * Import Export Settings * Info Icons * Indentation * Using Dynamo View Model reference * Moving the methods to the proper places according to their accessibility * Handling Generic Exceptions * updating the RaisePropertyChanged * Extracting the import extension file as a variable * Unique file name * Changing the access level * Various revisions * Cleaning vars * Adding Unit Test * Adding Comments and cleaning vars * Removing unnecessary methods * Refactoring to get the static fields automatically * Updating the Unit Test * checking new settings file * Adding validation info * Getting First Property with the same value * Updating valid TrustedLocations entries * move near clipping plane further away for more depth buffer precision. (#13338) passed here: merging. * Keep Node AutoComplete popup hidden when window deactivated (#13337) * Keep Node AutoComplete popup hidden when window deactivated * Add condition and null checks * comments Co-authored-by: pinzart90 <[email protected]> Co-authored-by: pinzart <[email protected]> Co-authored-by: Deyan Nenov <[email protected]> Co-authored-by: jesusalvino <[email protected]> Co-authored-by: Aaron (Qilong) <[email protected]> Co-authored-by: Aabishkar KC <[email protected]>

…3343) * add nunit test adapter for 2022 (#13313) * add nunit test adapter for 2022 * update * Update Setup.cs * update * Update DynamoCore.csproj * Create System.Net.Http.dll * update * update Co-authored-by: pinzart <[email protected]> * Filter Mouse Pressed Removed (#13319) - removed flashing white color on mouse pressed for the filter ui element * Fixing horizontal center (#13312) * Update Node AutoComplete Dialog Visuals (#13329) * Update Node AutoComplete Visuals * Reuse style from central location * Add editorconfig (#13233) * Dyn5272 (#13334) tests pass - merging this then will send cherry pick * Dyn 5159 import export preferences (#13301) * Import Export Settings * Info Icons * Indentation * Using Dynamo View Model reference * Moving the methods to the proper places according to their accessibility * Handling Generic Exceptions * updating the RaisePropertyChanged * Extracting the import extension file as a variable * Unique file name * Changing the access level * Various revisions * Cleaning vars * Adding Unit Test * Adding Comments and cleaning vars * Removing unnecessary methods * Refactoring to get the static fields automatically * Updating the Unit Test * checking new settings file * Adding validation info * Getting First Property with the same value * Updating valid TrustedLocations entries * move near clipping plane further away for more depth buffer precision. (#13338) passed here: merging. * add more failing tests * implement case 2 of replication * Update ReplicationTests.cs * add failing test * add some more failing tests * add some lacing tests that use arb rank params * fix tests 1. Missing replication Longest/Shortest attribute 2. Fix result - wrap in list (like old VM) Co-authored-by: pinzart90 <[email protected]> Co-authored-by: pinzart <[email protected]> Co-authored-by: Deyan Nenov <[email protected]> Co-authored-by: jesusalvino <[email protected]> Co-authored-by: Aaron (Qilong) <[email protected]> Co-authored-by: Aabishkar KC <[email protected]> Co-authored-by: kirschm <[email protected]>

* add nunit test adapter for 2022 (#13313) * add nunit test adapter for 2022 * update * Update Setup.cs * update * Update DynamoCore.csproj * Create System.Net.Http.dll * update * update Co-authored-by: pinzart <[email protected]> * Filter Mouse Pressed Removed (#13319) - removed flashing white color on mouse pressed for the filter ui element * Fixing horizontal center (#13312) * Update Node AutoComplete Dialog Visuals (#13329) * Update Node AutoComplete Visuals * Reuse style from central location * Add editorconfig (#13233) * Dyn5272 (#13334) tests pass - merging this then will send cherry pick * Dyn 5159 import export preferences (#13301) * Import Export Settings * Info Icons * Indentation * Using Dynamo View Model reference * Moving the methods to the proper places according to their accessibility * Handling Generic Exceptions * updating the RaisePropertyChanged * Extracting the import extension file as a variable * Unique file name * Changing the access level * Various revisions * Cleaning vars * Adding Unit Test * Adding Comments and cleaning vars * Removing unnecessary methods * Refactoring to get the static fields automatically * Updating the Unit Test * checking new settings file * Adding validation info * Getting First Property with the same value * Updating valid TrustedLocations entries * move near clipping plane further away for more depth buffer precision. (#13338) passed here: merging. * add more failing tests * implement case 2 of replication * Update ReplicationTests.cs * add failing test * add some more failing tests * add replication test * fix merge conflict * fix merge conflict Co-authored-by: pinzart90 <[email protected]> Co-authored-by: pinzart <[email protected]> Co-authored-by: Deyan Nenov <[email protected]> Co-authored-by: jesusalvino <[email protected]> Co-authored-by: Aaron (Qilong) <[email protected]> Co-authored-by: Aabishkar KC <[email protected]> Co-authored-by: Michael Kirschner <[email protected]> Co-authored-by: kirschm <[email protected]>

* add nunit test adapter for 2022 (#13313) * add nunit test adapter for 2022 * update * Update Setup.cs * update * Update DynamoCore.csproj * Create System.Net.Http.dll * update * update Co-authored-by: pinzart <[email protected]> * Filter Mouse Pressed Removed (#13319) - removed flashing white color on mouse pressed for the filter ui element * Fixing horizontal center (#13312) * Update Node AutoComplete Dialog Visuals (#13329) * Update Node AutoComplete Visuals * Reuse style from central location * Add editorconfig (#13233) * Dyn5272 (#13334) tests pass - merging this then will send cherry pick * Dyn 5159 import export preferences (#13301) * Import Export Settings * Info Icons * Indentation * Using Dynamo View Model reference * Moving the methods to the proper places according to their accessibility * Handling Generic Exceptions * updating the RaisePropertyChanged * Extracting the import extension file as a variable * Unique file name * Changing the access level * Various revisions * Cleaning vars * Adding Unit Test * Adding Comments and cleaning vars * Removing unnecessary methods * Refactoring to get the static fields automatically * Updating the Unit Test * checking new settings file * Adding validation info * Getting First Property with the same value * Updating valid TrustedLocations entries * move near clipping plane further away for more depth buffer precision. (#13338) passed here: merging. * add more failing tests * implement case 2 of replication * Update ReplicationTests.cs * add failing test * add some more failing tests * add replication test * fix merge conflict * fix merge conflict * update replication test Co-authored-by: pinzart90 <[email protected]> Co-authored-by: pinzart <[email protected]> Co-authored-by: Deyan Nenov <[email protected]> Co-authored-by: jesusalvino <[email protected]> Co-authored-by: Aaron (Qilong) <[email protected]> Co-authored-by: Aabishkar KC <[email protected]> Co-authored-by: Michael Kirschner <[email protected]> Co-authored-by: kirschm <[email protected]>

…namoDS#13343) * add nunit test adapter for 2022 (DynamoDS#13313) * add nunit test adapter for 2022 * update * Update Setup.cs * update * Update DynamoCore.csproj * Create System.Net.Http.dll * update * update Co-authored-by: pinzart <[email protected]> * Filter Mouse Pressed Removed (DynamoDS#13319) - removed flashing white color on mouse pressed for the filter ui element * Fixing horizontal center (DynamoDS#13312) * Update Node AutoComplete Dialog Visuals (DynamoDS#13329) * Update Node AutoComplete Visuals * Reuse style from central location * Add editorconfig (DynamoDS#13233) * Dyn5272 (DynamoDS#13334) tests pass - merging this then will send cherry pick * Dyn 5159 import export preferences (DynamoDS#13301) * Import Export Settings * Info Icons * Indentation * Using Dynamo View Model reference * Moving the methods to the proper places according to their accessibility * Handling Generic Exceptions * updating the RaisePropertyChanged * Extracting the import extension file as a variable * Unique file name * Changing the access level * Various revisions * Cleaning vars * Adding Unit Test * Adding Comments and cleaning vars * Removing unnecessary methods * Refactoring to get the static fields automatically * Updating the Unit Test * checking new settings file * Adding validation info * Getting First Property with the same value * Updating valid TrustedLocations entries * move near clipping plane further away for more depth buffer precision. (DynamoDS#13338) passed here: merging. * add more failing tests * implement case 2 of replication * Update ReplicationTests.cs * add failing test * add some more failing tests * add some lacing tests that use arb rank params * fix tests 1. Missing replication Longest/Shortest attribute 2. Fix result - wrap in list (like old VM) Co-authored-by: pinzart90 <[email protected]> Co-authored-by: pinzart <[email protected]> Co-authored-by: Deyan Nenov <[email protected]> Co-authored-by: jesusalvino <[email protected]> Co-authored-by: Aaron (Qilong) <[email protected]> Co-authored-by: Aabishkar KC <[email protected]> Co-authored-by: kirschm <[email protected]>

* add nunit test adapter for 2022 (DynamoDS#13313) * add nunit test adapter for 2022 * update * Update Setup.cs * update * Update DynamoCore.csproj * Create System.Net.Http.dll * update * update Co-authored-by: pinzart <[email protected]> * Filter Mouse Pressed Removed (DynamoDS#13319) - removed flashing white color on mouse pressed for the filter ui element * Fixing horizontal center (DynamoDS#13312) * Update Node AutoComplete Dialog Visuals (DynamoDS#13329) * Update Node AutoComplete Visuals * Reuse style from central location * Add editorconfig (DynamoDS#13233) * Dyn5272 (DynamoDS#13334) tests pass - merging this then will send cherry pick * Dyn 5159 import export preferences (DynamoDS#13301) * Import Export Settings * Info Icons * Indentation * Using Dynamo View Model reference * Moving the methods to the proper places according to their accessibility * Handling Generic Exceptions * updating the RaisePropertyChanged * Extracting the import extension file as a variable * Unique file name * Changing the access level * Various revisions * Cleaning vars * Adding Unit Test * Adding Comments and cleaning vars * Removing unnecessary methods * Refactoring to get the static fields automatically * Updating the Unit Test * checking new settings file * Adding validation info * Getting First Property with the same value * Updating valid TrustedLocations entries * move near clipping plane further away for more depth buffer precision. (DynamoDS#13338) passed here: merging. * add more failing tests * implement case 2 of replication * Update ReplicationTests.cs * add failing test * add some more failing tests * add replication test * fix merge conflict * fix merge conflict Co-authored-by: pinzart90 <[email protected]> Co-authored-by: pinzart <[email protected]> Co-authored-by: Deyan Nenov <[email protected]> Co-authored-by: jesusalvino <[email protected]> Co-authored-by: Aaron (Qilong) <[email protected]> Co-authored-by: Aabishkar KC <[email protected]> Co-authored-by: Michael Kirschner <[email protected]> Co-authored-by: kirschm <[email protected]>

* add nunit test adapter for 2022 (DynamoDS#13313) * add nunit test adapter for 2022 * update * Update Setup.cs * update * Update DynamoCore.csproj * Create System.Net.Http.dll * update * update Co-authored-by: pinzart <[email protected]> * Filter Mouse Pressed Removed (DynamoDS#13319) - removed flashing white color on mouse pressed for the filter ui element * Fixing horizontal center (DynamoDS#13312) * Update Node AutoComplete Dialog Visuals (DynamoDS#13329) * Update Node AutoComplete Visuals * Reuse style from central location * Add editorconfig (DynamoDS#13233) * Dyn5272 (DynamoDS#13334) tests pass - merging this then will send cherry pick * Dyn 5159 import export preferences (DynamoDS#13301) * Import Export Settings * Info Icons * Indentation * Using Dynamo View Model reference * Moving the methods to the proper places according to their accessibility * Handling Generic Exceptions * updating the RaisePropertyChanged * Extracting the import extension file as a variable * Unique file name * Changing the access level * Various revisions * Cleaning vars * Adding Unit Test * Adding Comments and cleaning vars * Removing unnecessary methods * Refactoring to get the static fields automatically * Updating the Unit Test * checking new settings file * Adding validation info * Getting First Property with the same value * Updating valid TrustedLocations entries * move near clipping plane further away for more depth buffer precision. (DynamoDS#13338) passed here: merging. * add more failing tests * implement case 2 of replication * Update ReplicationTests.cs * add failing test * add some more failing tests * add replication test * fix merge conflict * fix merge conflict * update replication test Co-authored-by: pinzart90 <[email protected]> Co-authored-by: pinzart <[email protected]> Co-authored-by: Deyan Nenov <[email protected]> Co-authored-by: jesusalvino <[email protected]> Co-authored-by: Aaron (Qilong) <[email protected]> Co-authored-by: Aabishkar KC <[email protected]> Co-authored-by: Michael Kirschner <[email protected]> Co-authored-by: kirschm <[email protected]>

aparajit-pratap and others added 2 commits September 21, 2022 22:19

add test selection node and corresponding test

1985306

test passes?

92812f6

mjkkirschner requested a review from aparajit-pratap September 22, 2022 21:29

missing parentheses

03cc895

aparajit-pratap reviewed Sep 22, 2022

View reviewed changes