Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DYN-5220 Fixing horizontal center #13312

Merged
merged 1 commit into from
Sep 19, 2022
Merged

DYN-5220 Fixing horizontal center #13312

merged 1 commit into from
Sep 19, 2022

Conversation

jesusalvino
Copy link
Contributor

@jesusalvino jesusalvino commented Sep 15, 2022 •
edited
Loading

Purpose

Fixing the horizontal alignment of the Trust dialog
https://jira.autodesk.com/browse/DYN-5220

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Reviewers

@QilongTang @RobertGlobant20 @filipeotero

@jesusalvino
Copy link
Contributor Author

TrustPosition-2

zeusongit
zeusongit approved these changes Sep 15, 2022
View reviewed changes
Copy link
Contributor

@zeusongit zeusongit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QilongTang QilongTang added this to the 2.17.0 milestone Sep 19, 2022
@QilongTang QilongTang merged commit 2459d0f into DynamoDS:master Sep 19, 2022
pinzart90 added a commit that referenced this pull request Sep 27, 2022
@mjkkirschner @pinzart90
@pinzart @dnenov @jesusalvino @QilongTang @avidit
merge master to emitMSIL (#13344)
2f42eea 
* add nunit test adapter for 2022 (#13313)

* add nunit test adapter for 2022

* update

* Update Setup.cs

* update

* Update DynamoCore.csproj

* Create System.Net.Http.dll

* update

* update

Co-authored-by: pinzart <[email protected]>

* Filter Mouse Pressed Removed (#13319)

- removed flashing white color on mouse pressed for the filter ui element

* Fixing horizontal center (#13312)

* Update Node AutoComplete Dialog Visuals (#13329)

* Update Node AutoComplete Visuals

* Reuse style from central location

* Add editorconfig (#13233)

* Dyn5272 (#13334)

tests pass - merging this then will send cherry pick

* Dyn 5159 import export preferences (#13301)

* Import Export Settings

* Info Icons

* Indentation

* Using Dynamo View Model reference

* Moving the methods to the proper places according to their accessibility

* Handling Generic Exceptions

* updating the RaisePropertyChanged

* Extracting the import extension file as a variable

* Unique file name

* Changing the access level

* Various revisions

* Cleaning vars

* Adding Unit Test

* Adding Comments and cleaning vars

* Removing unnecessary methods

* Refactoring to get the static fields automatically

* Updating the Unit Test

* checking new settings file

* Adding validation info

* Getting First Property with the same value

* Updating valid TrustedLocations entries

* move near clipping plane further away for more depth buffer precision. (#13338)

passed here:
merging.

* Keep Node AutoComplete popup hidden when window deactivated (#13337)

* Keep Node AutoComplete popup hidden when window deactivated

* Add condition and null checks

* comments

Co-authored-by: pinzart90 <[email protected]>
Co-authored-by: pinzart <[email protected]>
Co-authored-by: Deyan Nenov <[email protected]>
Co-authored-by: jesusalvino <[email protected]>
Co-authored-by: Aaron (Qilong) <[email protected]>
Co-authored-by: Aabishkar KC <[email protected]>
mjkkirschner added a commit that referenced this pull request Sep 28, 2022
@mjkkirschner @pinzart90
@pinzart @dnenov @jesusalvino @QilongTang @avidit
Dyn 4994 adding tests for longest/shortest replication MSIL - WIP (#1…
75c2f6f 
…3343)

* add nunit test adapter for 2022 (#13313)

* add nunit test adapter for 2022

* update

* Update Setup.cs

* update

* Update DynamoCore.csproj

* Create System.Net.Http.dll

* update

* update

Co-authored-by: pinzart <[email protected]>

* Filter Mouse Pressed Removed (#13319)

- removed flashing white color on mouse pressed for the filter ui element

* Fixing horizontal center (#13312)

* Update Node AutoComplete Dialog Visuals (#13329)

* Update Node AutoComplete Visuals

* Reuse style from central location

* Add editorconfig (#13233)

* Dyn5272 (#13334)

tests pass - merging this then will send cherry pick

* Dyn 5159 import export preferences (#13301)

* Import Export Settings

* Info Icons

* Indentation

* Using Dynamo View Model reference

* Moving the methods to the proper places according to their accessibility

* Handling Generic Exceptions

* updating the RaisePropertyChanged

* Extracting the import extension file as a variable

* Unique file name

* Changing the access level

* Various revisions

* Cleaning vars

* Adding Unit Test

* Adding Comments and cleaning vars

* Removing unnecessary methods

* Refactoring to get the static fields automatically

* Updating the Unit Test

* checking new settings file

* Adding validation info

* Getting First Property with the same value

* Updating valid TrustedLocations entries

* move near clipping plane further away for more depth buffer precision. (#13338)

passed here:
merging.

* add more failing tests

* implement case 2 of replication

* Update ReplicationTests.cs

* add failing test

* add some more failing tests

* add some lacing tests that use arb rank params

* fix tests

1. Missing replication Longest/Shortest attribute
2. Fix result - wrap in list (like old VM)

Co-authored-by: pinzart90 <[email protected]>
Co-authored-by: pinzart <[email protected]>
Co-authored-by: Deyan Nenov <[email protected]>
Co-authored-by: jesusalvino <[email protected]>
Co-authored-by: Aaron (Qilong) <[email protected]>
Co-authored-by: Aabishkar KC <[email protected]>
Co-authored-by: kirschm <[email protected]>
aparajit-pratap added a commit that referenced this pull request Sep 28, 2022
@aparajit-pratap @pinzart90
@pinzart @dnenov @jesusalvino @QilongTang @avidit @mjkkirschner
Add one more replication test (#13350)
1cb5053 
* add nunit test adapter for 2022 (#13313)

* add nunit test adapter for 2022

* update

* Update Setup.cs

* update

* Update DynamoCore.csproj

* Create System.Net.Http.dll

* update

* update

Co-authored-by: pinzart <[email protected]>

* Filter Mouse Pressed Removed (#13319)

- removed flashing white color on mouse pressed for the filter ui element

* Fixing horizontal center (#13312)

* Update Node AutoComplete Dialog Visuals (#13329)

* Update Node AutoComplete Visuals

* Reuse style from central location

* Add editorconfig (#13233)

* Dyn5272 (#13334)

tests pass - merging this then will send cherry pick

* Dyn 5159 import export preferences (#13301)

* Import Export Settings

* Info Icons

* Indentation

* Using Dynamo View Model reference

* Moving the methods to the proper places according to their accessibility

* Handling Generic Exceptions

* updating the RaisePropertyChanged

* Extracting the import extension file as a variable

* Unique file name

* Changing the access level

* Various revisions

* Cleaning vars

* Adding Unit Test

* Adding Comments and cleaning vars

* Removing unnecessary methods

* Refactoring to get the static fields automatically

* Updating the Unit Test

* checking new settings file

* Adding validation info

* Getting First Property with the same value

* Updating valid TrustedLocations entries

* move near clipping plane further away for more depth buffer precision. (#13338)

passed here:
merging.

* add more failing tests

* implement case 2 of replication

* Update ReplicationTests.cs

* add failing test

* add some more failing tests

* add replication test

* fix merge conflict

* fix merge conflict

Co-authored-by: pinzart90 <[email protected]>
Co-authored-by: pinzart <[email protected]>
Co-authored-by: Deyan Nenov <[email protected]>
Co-authored-by: jesusalvino <[email protected]>
Co-authored-by: Aaron (Qilong) <[email protected]>
Co-authored-by: Aabishkar KC <[email protected]>
Co-authored-by: Michael Kirschner <[email protected]>
Co-authored-by: kirschm <[email protected]>
aparajit-pratap added a commit that referenced this pull request Sep 28, 2022
@aparajit-pratap @pinzart90
@pinzart @dnenov @jesusalvino @QilongTang @avidit @mjkkirschner
Update replication test (#13351)
093b4f9 
* add nunit test adapter for 2022 (#13313)

* add nunit test adapter for 2022

* update

* Update Setup.cs

* update

* Update DynamoCore.csproj

* Create System.Net.Http.dll

* update

* update

Co-authored-by: pinzart <[email protected]>

* Filter Mouse Pressed Removed (#13319)

- removed flashing white color on mouse pressed for the filter ui element

* Fixing horizontal center (#13312)

* Update Node AutoComplete Dialog Visuals (#13329)

* Update Node AutoComplete Visuals

* Reuse style from central location

* Add editorconfig (#13233)

* Dyn5272 (#13334)

tests pass - merging this then will send cherry pick

* Dyn 5159 import export preferences (#13301)

* Import Export Settings

* Info Icons

* Indentation

* Using Dynamo View Model reference

* Moving the methods to the proper places according to their accessibility

* Handling Generic Exceptions

* updating the RaisePropertyChanged

* Extracting the import extension file as a variable

* Unique file name

* Changing the access level

* Various revisions

* Cleaning vars

* Adding Unit Test

* Adding Comments and cleaning vars

* Removing unnecessary methods

* Refactoring to get the static fields automatically

* Updating the Unit Test

* checking new settings file

* Adding validation info

* Getting First Property with the same value

* Updating valid TrustedLocations entries

* move near clipping plane further away for more depth buffer precision. (#13338)

passed here:
merging.

* add more failing tests

* implement case 2 of replication

* Update ReplicationTests.cs

* add failing test

* add some more failing tests

* add replication test

* fix merge conflict

* fix merge conflict

* update replication test

Co-authored-by: pinzart90 <[email protected]>
Co-authored-by: pinzart <[email protected]>
Co-authored-by: Deyan Nenov <[email protected]>
Co-authored-by: jesusalvino <[email protected]>
Co-authored-by: Aaron (Qilong) <[email protected]>
Co-authored-by: Aabishkar KC <[email protected]>
Co-authored-by: Michael Kirschner <[email protected]>
Co-authored-by: kirschm <[email protected]>
sm6srw pushed a commit to sm6srw/Dynamo that referenced this pull request Jan 20, 2023
@mjkkirschner @pinzart90
@pinzart @dnenov @jesusalvino @QilongTang @avidit @sm6srw
Dyn 4994 adding tests for longest/shortest replication MSIL - WIP (Dy…
1d5b67c 
…namoDS#13343)

* add nunit test adapter for 2022 (DynamoDS#13313)

* add nunit test adapter for 2022

* update

* Update Setup.cs

* update

* Update DynamoCore.csproj

* Create System.Net.Http.dll

* update

* update

Co-authored-by: pinzart <[email protected]>

* Filter Mouse Pressed Removed (DynamoDS#13319)

- removed flashing white color on mouse pressed for the filter ui element

* Fixing horizontal center (DynamoDS#13312)

* Update Node AutoComplete Dialog Visuals (DynamoDS#13329)

* Update Node AutoComplete Visuals

* Reuse style from central location

* Add editorconfig (DynamoDS#13233)

* Dyn5272 (DynamoDS#13334)

tests pass - merging this then will send cherry pick

* Dyn 5159 import export preferences (DynamoDS#13301)

* Import Export Settings

* Info Icons

* Indentation

* Using Dynamo View Model reference

* Moving the methods to the proper places according to their accessibility

* Handling Generic Exceptions

* updating the RaisePropertyChanged

* Extracting the import extension file as a variable

* Unique file name

* Changing the access level

* Various revisions

* Cleaning vars

* Adding Unit Test

* Adding Comments and cleaning vars

* Removing unnecessary methods

* Refactoring to get the static fields automatically

* Updating the Unit Test

* checking new settings file

* Adding validation info

* Getting First Property with the same value

* Updating valid TrustedLocations entries

* move near clipping plane further away for more depth buffer precision. (DynamoDS#13338)

passed here:
merging.

* add more failing tests

* implement case 2 of replication

* Update ReplicationTests.cs

* add failing test

* add some more failing tests

* add some lacing tests that use arb rank params

* fix tests

1. Missing replication Longest/Shortest attribute
2. Fix result - wrap in list (like old VM)

Co-authored-by: pinzart90 <[email protected]>
Co-authored-by: pinzart <[email protected]>
Co-authored-by: Deyan Nenov <[email protected]>
Co-authored-by: jesusalvino <[email protected]>
Co-authored-by: Aaron (Qilong) <[email protected]>
Co-authored-by: Aabishkar KC <[email protected]>
Co-authored-by: kirschm <[email protected]>
sm6srw pushed a commit to sm6srw/Dynamo that referenced this pull request Jan 20, 2023
@aparajit-pratap @pinzart90
@pinzart @dnenov @jesusalvino @QilongTang @avidit @mjkkirschner @sm6srw
Add one more replication test (DynamoDS#13350)
2e7a794 
* add nunit test adapter for 2022 (DynamoDS#13313)

* add nunit test adapter for 2022

* update

* Update Setup.cs

* update

* Update DynamoCore.csproj

* Create System.Net.Http.dll

* update

* update

Co-authored-by: pinzart <[email protected]>

* Filter Mouse Pressed Removed (DynamoDS#13319)

- removed flashing white color on mouse pressed for the filter ui element

* Fixing horizontal center (DynamoDS#13312)

* Update Node AutoComplete Dialog Visuals (DynamoDS#13329)

* Update Node AutoComplete Visuals

* Reuse style from central location

* Add editorconfig (DynamoDS#13233)

* Dyn5272 (DynamoDS#13334)

tests pass - merging this then will send cherry pick

* Dyn 5159 import export preferences (DynamoDS#13301)

* Import Export Settings

* Info Icons

* Indentation

* Using Dynamo View Model reference

* Moving the methods to the proper places according to their accessibility

* Handling Generic Exceptions

* updating the RaisePropertyChanged

* Extracting the import extension file as a variable

* Unique file name

* Changing the access level

* Various revisions

* Cleaning vars

* Adding Unit Test

* Adding Comments and cleaning vars

* Removing unnecessary methods

* Refactoring to get the static fields automatically

* Updating the Unit Test

* checking new settings file

* Adding validation info

* Getting First Property with the same value

* Updating valid TrustedLocations entries

* move near clipping plane further away for more depth buffer precision. (DynamoDS#13338)

passed here:
merging.

* add more failing tests

* implement case 2 of replication

* Update ReplicationTests.cs

* add failing test

* add some more failing tests

* add replication test

* fix merge conflict

* fix merge conflict

Co-authored-by: pinzart90 <[email protected]>
Co-authored-by: pinzart <[email protected]>
Co-authored-by: Deyan Nenov <[email protected]>
Co-authored-by: jesusalvino <[email protected]>
Co-authored-by: Aaron (Qilong) <[email protected]>
Co-authored-by: Aabishkar KC <[email protected]>
Co-authored-by: Michael Kirschner <[email protected]>
Co-authored-by: kirschm <[email protected]>
sm6srw pushed a commit to sm6srw/Dynamo that referenced this pull request Jan 20, 2023
@aparajit-pratap @pinzart90
@pinzart @dnenov @jesusalvino @QilongTang @avidit @mjkkirschner @sm6srw
Update replication test (DynamoDS#13351)
df29fe8 
* add nunit test adapter for 2022 (DynamoDS#13313)

* add nunit test adapter for 2022

* update

* Update Setup.cs

* update

* Update DynamoCore.csproj

* Create System.Net.Http.dll

* update

* update

Co-authored-by: pinzart <[email protected]>

* Filter Mouse Pressed Removed (DynamoDS#13319)

- removed flashing white color on mouse pressed for the filter ui element

* Fixing horizontal center (DynamoDS#13312)

* Update Node AutoComplete Dialog Visuals (DynamoDS#13329)

* Update Node AutoComplete Visuals

* Reuse style from central location

* Add editorconfig (DynamoDS#13233)

* Dyn5272 (DynamoDS#13334)

tests pass - merging this then will send cherry pick

* Dyn 5159 import export preferences (DynamoDS#13301)

* Import Export Settings

* Info Icons

* Indentation

* Using Dynamo View Model reference

* Moving the methods to the proper places according to their accessibility

* Handling Generic Exceptions

* updating the RaisePropertyChanged

* Extracting the import extension file as a variable

* Unique file name

* Changing the access level

* Various revisions

* Cleaning vars

* Adding Unit Test

* Adding Comments and cleaning vars

* Removing unnecessary methods

* Refactoring to get the static fields automatically

* Updating the Unit Test

* checking new settings file

* Adding validation info

* Getting First Property with the same value

* Updating valid TrustedLocations entries

* move near clipping plane further away for more depth buffer precision. (DynamoDS#13338)

passed here:
merging.

* add more failing tests

* implement case 2 of replication

* Update ReplicationTests.cs

* add failing test

* add some more failing tests

* add replication test

* fix merge conflict

* fix merge conflict

* update replication test

Co-authored-by: pinzart90 <[email protected]>
Co-authored-by: pinzart <[email protected]>
Co-authored-by: Deyan Nenov <[email protected]>
Co-authored-by: jesusalvino <[email protected]>
Co-authored-by: Aaron (Qilong) <[email protected]>
Co-authored-by: Aabishkar KC <[email protected]>
Co-authored-by: Michael Kirschner <[email protected]>
Co-authored-by: kirschm <[email protected]>
QilongTang pushed a commit that referenced this pull request Jul 12, 2023
@jesusalvino @QilongTang
Fixing horizontal center (#13312)
339cced
@QilongTang QilongTang mentioned this pull request Jul 12, 2023
Merged
9 tasks
QilongTang added a commit that referenced this pull request Jul 13, 2023
@QilongTang @jesusalvino
@saintentropy @twastvedt @filipeotero @RobertGlobant20
Dynamo 2.16.2 Hotfix (#14157)
ba1046d 
* Fixing horizontal center (#13312)

* Fix Trusted Message behavior (#13355)

* Fix Trusted Message behavior

* Extract Business Logic as a function

* Moving API to Preferences

* Adding unit test

* Leave RenderPackage data intact when passed to AggregateRenderPackages (#13437)

* Leave RP data intact

* Fix tests

* Remove unnessary code

* Spelling typos and clean up

* clean up

* clean up

* Add regression test for render package mutation.

* Unsubscribe from event.

* Add image comparison test for render bug.

* Fix test image size.

Co-authored-by: Craig Long <[email protected]>
Co-authored-by: Trygve Wastvedt <[email protected]>

* DYN-5437 Export image button shortcut (#13550)

* Insert the export command in the shortcut view model

* remove test method

* Dyn 5317 check webview2 installed (#13464)

* DYN-5317-Check-WebView2-Installed

I added a validation that before starting the DynamoSandbox app we will check if the WebView2 Runtime is installed or not, if is not installed we will show a MessageBox with the  link of the WebView2 installer and then after pressing the OK button close Dynamo.
Also in the DynamoMessageBox I added a RichTextBox that will be visible under very specific circumstances, this RichTextBox allows to have a blue hyperlink as a part of the text so the user can click it and open the webview2 installer webpage.

* DYN-5317-Check-WebView2-Installed

removing extra comment

* DYN-5674-CustomNode-Renamed (#13854)

After the auto-save functionality is triggered when we are located in the Custom Node edit tab when the node in the Home Workspace is being renamed to "backup". Then after my fix first is checking if it has a name and file associated (that usually happen when you create/edit a custom node) if that is the case then we don't execute the rename process.
Also I added a test that will validate that the Save functionality doesn't rename the CustomNode name.

* clean up

---------

Co-authored-by: jesusalvino <[email protected]>
Co-authored-by: Craig Long <[email protected]>
Co-authored-by: Craig Long <[email protected]>
Co-authored-by: Trygve Wastvedt <[email protected]>
Co-authored-by: filipeotero <[email protected]>
Co-authored-by: Roberto T <[email protected]>
@QilongTang QilongTang changed the title Fixing horizontal center DYN 5220 Fixing horizontal center Mar 25, 2024
@QilongTang QilongTang changed the title DYN 5220 Fixing horizontal center DYN - 5220 Fixing horizontal center Mar 25, 2024
@QilongTang QilongTang changed the title DYN - 5220 Fixing horizontal center DYN-5220 Fixing horizontal center Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeusongit zeusongit zeusongit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.17.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jesusalvino @zeusongit @QilongTang