Dyn 5317 check webview2 installed #13464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added a validation that before starting the DynamoSandbox app we will check if the WebView2 Runtime is installed or not, if is not installed we will show a MessageBox with the link of the WebView2 installer and then after pressing the OK button close Dynamo. Also in the DynamoMessageBox I added a RichTextBox that will be visible under very specific circumstances, this RichTextBox allows to have a blue hyperlink as a part of the text so the user can click it and open the webview2 installer webpage.
removing extra comment
|
GIF showing behavior when WebView2 Runtime is not installed. |
|
GIF showing behavior when WebView2 is installed |
QilongTang
reviewed
Nov 3, 2022
| Margin="20" | ||
| CustomText="{Binding BodyText}" | ||
| Style="{StaticResource CustomRichTextBoxStyle}"> | ||
| </localui:CustomRichTextBox> |
There was a problem hiding this comment.
Would you also test if normal messages display correctly?
There was a problem hiding this comment.
Oh you are adding a RIchTextBox instead of forcing it, I guess it is less impactful then
QilongTang
reviewed
Nov 3, 2022
| @@ -57,6 +58,10 @@ public void RunApplication(Application app) | |||
| { | |||
| try | |||
| { | |||
| //This line validates if the WebView2 Runtime is installed in the computer, if is not we return and then exit Dynamo | |||
| if (!WebView2Utilities.ValidateWebView2RuntimeInstalled()) | |||
| return; | |||
There was a problem hiding this comment.
I think this is fine for now. For integrations, usually host will include WebView2 Runtime, for any integration launching Dynamo as another process, this should hit
There was a problem hiding this comment.
do we really need to exit Dynamo?
There was a problem hiding this comment.
@mjkkirschner It would be safe to do so since Splash Screen depending on WebView2, unless we want to totally skip that experience when runtime not installed
QilongTang
approved these changes
Nov 3, 2022
|
@RobertGlobant20 |
QilongTang
pushed a commit
that referenced
this pull request
Jul 12, 2023
* DYN-5317-Check-WebView2-Installed I added a validation that before starting the DynamoSandbox app we will check if the WebView2 Runtime is installed or not, if is not installed we will show a MessageBox with the link of the WebView2 installer and then after pressing the OK button close Dynamo. Also in the DynamoMessageBox I added a RichTextBox that will be visible under very specific circumstances, this RichTextBox allows to have a blue hyperlink as a part of the text so the user can click it and open the webview2 installer webpage. * DYN-5317-Check-WebView2-Installed removing extra comment
QilongTang
added a commit
that referenced
this pull request
Jul 13, 2023
* Fixing horizontal center (#13312) * Fix Trusted Message behavior (#13355) * Fix Trusted Message behavior * Extract Business Logic as a function * Moving API to Preferences * Adding unit test * Leave RenderPackage data intact when passed to AggregateRenderPackages (#13437) * Leave RP data intact * Fix tests * Remove unnessary code * Spelling typos and clean up * clean up * clean up * Add regression test for render package mutation. * Unsubscribe from event. * Add image comparison test for render bug. * Fix test image size. Co-authored-by: Craig Long <[email protected]> Co-authored-by: Trygve Wastvedt <[email protected]> * DYN-5437 Export image button shortcut (#13550) * Insert the export command in the shortcut view model * remove test method * Dyn 5317 check webview2 installed (#13464) * DYN-5317-Check-WebView2-Installed I added a validation that before starting the DynamoSandbox app we will check if the WebView2 Runtime is installed or not, if is not installed we will show a MessageBox with the link of the WebView2 installer and then after pressing the OK button close Dynamo. Also in the DynamoMessageBox I added a RichTextBox that will be visible under very specific circumstances, this RichTextBox allows to have a blue hyperlink as a part of the text so the user can click it and open the webview2 installer webpage. * DYN-5317-Check-WebView2-Installed removing extra comment * DYN-5674-CustomNode-Renamed (#13854) After the auto-save functionality is triggered when we are located in the Custom Node edit tab when the node in the Home Workspace is being renamed to "backup". Then after my fix first is checking if it has a name and file associated (that usually happen when you create/edit a custom node) if that is the case then we don't execute the rename process. Also I added a test that will validate that the Save functionality doesn't rename the CustomNode name. * clean up --------- Co-authored-by: jesusalvino <[email protected]> Co-authored-by: Craig Long <[email protected]> Co-authored-by: Craig Long <[email protected]> Co-authored-by: Trygve Wastvedt <[email protected]> Co-authored-by: filipeotero <[email protected]> Co-authored-by: Roberto T <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Check that WebView2 is installed before starting Dynamo
I added a validation that before starting the DynamoSandbox app we will check if the WebView2 Runtime is installed or not, if is not installed we will show a MessageBox with the link of the WebView2 installer and then after pressing the OK button close Dynamo.
Also in the DynamoMessageBox I added a RichTextBox that will be visible under very specific circumstances, this RichTextBox allows to have a blue hyperlink as a part of the text so the user can click it and open the webview2 installer webpage.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Check that WebView2 is installed before starting Dynamo
Reviewers
@QilongTang
FYIs
@filipeotero