Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dyn 5159 import export preferences #13301

Merged
merged 21 commits into from
Sep 23, 2022
Merged

Dyn 5159 import export preferences #13301

merged 21 commits into from
Sep 23, 2022

Conversation

jesusalvino
Copy link
Contributor

@jesusalvino jesusalvino commented Sep 7, 2022 •
edited
Loading

Purpose

Import and Export Settings Features
https://jira.autodesk.com/browse/DYN-5159

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Reviewers

@QilongTang

FYIs

@RobertGlobant20 @filipeotero

@QilongTang
Copy link
Contributor

any gif of how it works now?

@jesusalvino
Copy link
Contributor Author

any gif of how it works now?

Export

Export

Import

Import

@QilongTang QilongTang added this to the 2.17.0 milestone Sep 8, 2022
QilongTang
QilongTang reviewed Sep 8, 2022
View reviewed changes
Copy link
Contributor

@QilongTang QilongTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress, some questions and comments

RobertGlobant20
RobertGlobant20 reviewed Sep 8, 2022
View reviewed changes
Copy link
Contributor

@RobertGlobant20 RobertGlobant20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with two comments

src/DynamoCoreWpf/Views/Menu/PreferencesView.xaml.cs Show resolved Hide resolved
src/DynamoCore/Configuration/PathManager.cs Outdated Show resolved Hide resolved
QilongTang
QilongTang reviewed Sep 19, 2022
View reviewed changes
Copy link
Contributor

@QilongTang QilongTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments then LGTM with unit test

QilongTang
QilongTang reviewed Sep 21, 2022
View reviewed changes
Copy link
Contributor

@QilongTang QilongTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one comment

@QilongTang
Copy link
Contributor

Also the new test does not seem to pass from the CI: Dynamo.Tests.Configuration.PreferenceSettingsTests.TestImportCopySettings

QilongTang
QilongTang reviewed Sep 21, 2022
View reviewed changes
src/DynamoCore/Configuration/PreferenceSettings.cs
public List<string> StaticFields()
{
return typeof(PreferenceSettings).GetMembers(BindingFlags.Static | BindingFlags.NonPublic).OfType<FieldInfo>().Select(field => field.Name).ToList();
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the Unit Test, just updated.

@QilongTang
Copy link
Contributor

LGTM waiting for PR checks to finish

@QilongTang QilongTang merged commit 503ab76 into DynamoDS:master Sep 23, 2022
pinzart90 added a commit that referenced this pull request Sep 27, 2022
@mjkkirschner @pinzart90
@pinzart @dnenov @jesusalvino @QilongTang @avidit
merge master to emitMSIL (#13344)
2f42eea 
* add nunit test adapter for 2022 (#13313)

* add nunit test adapter for 2022

* update

* Update Setup.cs

* update

* Update DynamoCore.csproj

* Create System.Net.Http.dll

* update

* update

Co-authored-by: pinzart <[email protected]>

* Filter Mouse Pressed Removed (#13319)

- removed flashing white color on mouse pressed for the filter ui element

* Fixing horizontal center (#13312)

* Update Node AutoComplete Dialog Visuals (#13329)

* Update Node AutoComplete Visuals

* Reuse style from central location

* Add editorconfig (#13233)

* Dyn5272 (#13334)

tests pass - merging this then will send cherry pick

* Dyn 5159 import export preferences (#13301)

* Import Export Settings

* Info Icons

* Indentation

* Using Dynamo View Model reference

* Moving the methods to the proper places according to their accessibility

* Handling Generic Exceptions

* updating the RaisePropertyChanged

* Extracting the import extension file as a variable

* Unique file name

* Changing the access level

* Various revisions

* Cleaning vars

* Adding Unit Test

* Adding Comments and cleaning vars

* Removing unnecessary methods

* Refactoring to get the static fields automatically

* Updating the Unit Test

* checking new settings file

* Adding validation info

* Getting First Property with the same value

* Updating valid TrustedLocations entries

* move near clipping plane further away for more depth buffer precision. (#13338)

passed here:
merging.

* Keep Node AutoComplete popup hidden when window deactivated (#13337)

* Keep Node AutoComplete popup hidden when window deactivated

* Add condition and null checks

* comments

Co-authored-by: pinzart90 <[email protected]>
Co-authored-by: pinzart <[email protected]>
Co-authored-by: Deyan Nenov <[email protected]>
Co-authored-by: jesusalvino <[email protected]>
Co-authored-by: Aaron (Qilong) <[email protected]>
Co-authored-by: Aabishkar KC <[email protected]>
mjkkirschner added a commit that referenced this pull request Sep 28, 2022
@mjkkirschner @pinzart90
@pinzart @dnenov @jesusalvino @QilongTang @avidit
Dyn 4994 adding tests for longest/shortest replication MSIL - WIP (#1…
75c2f6f 
…3343)

* add nunit test adapter for 2022 (#13313)

* add nunit test adapter for 2022

* update

* Update Setup.cs

* update

* Update DynamoCore.csproj

* Create System.Net.Http.dll

* update

* update

Co-authored-by: pinzart <[email protected]>

* Filter Mouse Pressed Removed (#13319)

- removed flashing white color on mouse pressed for the filter ui element

* Fixing horizontal center (#13312)

* Update Node AutoComplete Dialog Visuals (#13329)

* Update Node AutoComplete Visuals

* Reuse style from central location

* Add editorconfig (#13233)

* Dyn5272 (#13334)

tests pass - merging this then will send cherry pick

* Dyn 5159 import export preferences (#13301)

* Import Export Settings

* Info Icons

* Indentation

* Using Dynamo View Model reference

* Moving the methods to the proper places according to their accessibility

* Handling Generic Exceptions

* updating the RaisePropertyChanged

* Extracting the import extension file as a variable

* Unique file name

* Changing the access level

* Various revisions

* Cleaning vars

* Adding Unit Test

* Adding Comments and cleaning vars

* Removing unnecessary methods

* Refactoring to get the static fields automatically

* Updating the Unit Test

* checking new settings file

* Adding validation info

* Getting First Property with the same value

* Updating valid TrustedLocations entries

* move near clipping plane further away for more depth buffer precision. (#13338)

passed here:
merging.

* add more failing tests

* implement case 2 of replication

* Update ReplicationTests.cs

* add failing test

* add some more failing tests

* add some lacing tests that use arb rank params

* fix tests

1. Missing replication Longest/Shortest attribute
2. Fix result - wrap in list (like old VM)

Co-authored-by: pinzart90 <[email protected]>
Co-authored-by: pinzart <[email protected]>
Co-authored-by: Deyan Nenov <[email protected]>
Co-authored-by: jesusalvino <[email protected]>
Co-authored-by: Aaron (Qilong) <[email protected]>
Co-authored-by: Aabishkar KC <[email protected]>
Co-authored-by: kirschm <[email protected]>
aparajit-pratap added a commit that referenced this pull request Sep 28, 2022
@aparajit-pratap @pinzart90
@pinzart @dnenov @jesusalvino @QilongTang @avidit @mjkkirschner
Add one more replication test (#13350)
1cb5053 
* add nunit test adapter for 2022 (#13313)

* add nunit test adapter for 2022

* update

* Update Setup.cs

* update

* Update DynamoCore.csproj

* Create System.Net.Http.dll

* update

* update

Co-authored-by: pinzart <[email protected]>

* Filter Mouse Pressed Removed (#13319)

- removed flashing white color on mouse pressed for the filter ui element

* Fixing horizontal center (#13312)

* Update Node AutoComplete Dialog Visuals (#13329)

* Update Node AutoComplete Visuals

* Reuse style from central location

* Add editorconfig (#13233)

* Dyn5272 (#13334)

tests pass - merging this then will send cherry pick

* Dyn 5159 import export preferences (#13301)

* Import Export Settings

* Info Icons

* Indentation

* Using Dynamo View Model reference

* Moving the methods to the proper places according to their accessibility

* Handling Generic Exceptions

* updating the RaisePropertyChanged

* Extracting the import extension file as a variable

* Unique file name

* Changing the access level

* Various revisions

* Cleaning vars

* Adding Unit Test

* Adding Comments and cleaning vars

* Removing unnecessary methods

* Refactoring to get the static fields automatically

* Updating the Unit Test

* checking new settings file

* Adding validation info

* Getting First Property with the same value

* Updating valid TrustedLocations entries

* move near clipping plane further away for more depth buffer precision. (#13338)

passed here:
merging.

* add more failing tests

* implement case 2 of replication

* Update ReplicationTests.cs

* add failing test

* add some more failing tests

* add replication test

* fix merge conflict

* fix merge conflict

Co-authored-by: pinzart90 <[email protected]>
Co-authored-by: pinzart <[email protected]>
Co-authored-by: Deyan Nenov <[email protected]>
Co-authored-by: jesusalvino <[email protected]>
Co-authored-by: Aaron (Qilong) <[email protected]>
Co-authored-by: Aabishkar KC <[email protected]>
Co-authored-by: Michael Kirschner <[email protected]>
Co-authored-by: kirschm <[email protected]>
aparajit-pratap added a commit that referenced this pull request Sep 28, 2022
@aparajit-pratap @pinzart90
@pinzart @dnenov @jesusalvino @QilongTang @avidit @mjkkirschner
Update replication test (#13351)
093b4f9 
* add nunit test adapter for 2022 (#13313)

* add nunit test adapter for 2022

* update

* Update Setup.cs

* update

* Update DynamoCore.csproj

* Create System.Net.Http.dll

* update

* update

Co-authored-by: pinzart <[email protected]>

* Filter Mouse Pressed Removed (#13319)

- removed flashing white color on mouse pressed for the filter ui element

* Fixing horizontal center (#13312)

* Update Node AutoComplete Dialog Visuals (#13329)

* Update Node AutoComplete Visuals

* Reuse style from central location

* Add editorconfig (#13233)

* Dyn5272 (#13334)

tests pass - merging this then will send cherry pick

* Dyn 5159 import export preferences (#13301)

* Import Export Settings

* Info Icons

* Indentation

* Using Dynamo View Model reference

* Moving the methods to the proper places according to their accessibility

* Handling Generic Exceptions

* updating the RaisePropertyChanged

* Extracting the import extension file as a variable

* Unique file name

* Changing the access level

* Various revisions

* Cleaning vars

* Adding Unit Test

* Adding Comments and cleaning vars

* Removing unnecessary methods

* Refactoring to get the static fields automatically

* Updating the Unit Test

* checking new settings file

* Adding validation info

* Getting First Property with the same value

* Updating valid TrustedLocations entries

* move near clipping plane further away for more depth buffer precision. (#13338)

passed here:
merging.

* add more failing tests

* implement case 2 of replication

* Update ReplicationTests.cs

* add failing test

* add some more failing tests

* add replication test

* fix merge conflict

* fix merge conflict

* update replication test

Co-authored-by: pinzart90 <[email protected]>
Co-authored-by: pinzart <[email protected]>
Co-authored-by: Deyan Nenov <[email protected]>
Co-authored-by: jesusalvino <[email protected]>
Co-authored-by: Aaron (Qilong) <[email protected]>
Co-authored-by: Aabishkar KC <[email protected]>
Co-authored-by: Michael Kirschner <[email protected]>
Co-authored-by: kirschm <[email protected]>
sm6srw pushed a commit to sm6srw/Dynamo that referenced this pull request Jan 20, 2023
@mjkkirschner @pinzart90
@pinzart @dnenov @jesusalvino @QilongTang @avidit @sm6srw
Dyn 4994 adding tests for longest/shortest replication MSIL - WIP (Dy…
1d5b67c 
…namoDS#13343)

* add nunit test adapter for 2022 (DynamoDS#13313)

* add nunit test adapter for 2022

* update

* Update Setup.cs

* update

* Update DynamoCore.csproj

* Create System.Net.Http.dll

* update

* update

Co-authored-by: pinzart <[email protected]>

* Filter Mouse Pressed Removed (DynamoDS#13319)

- removed flashing white color on mouse pressed for the filter ui element

* Fixing horizontal center (DynamoDS#13312)

* Update Node AutoComplete Dialog Visuals (DynamoDS#13329)

* Update Node AutoComplete Visuals

* Reuse style from central location

* Add editorconfig (DynamoDS#13233)

* Dyn5272 (DynamoDS#13334)

tests pass - merging this then will send cherry pick

* Dyn 5159 import export preferences (DynamoDS#13301)

* Import Export Settings

* Info Icons

* Indentation

* Using Dynamo View Model reference

* Moving the methods to the proper places according to their accessibility

* Handling Generic Exceptions

* updating the RaisePropertyChanged

* Extracting the import extension file as a variable

* Unique file name

* Changing the access level

* Various revisions

* Cleaning vars

* Adding Unit Test

* Adding Comments and cleaning vars

* Removing unnecessary methods

* Refactoring to get the static fields automatically

* Updating the Unit Test

* checking new settings file

* Adding validation info

* Getting First Property with the same value

* Updating valid TrustedLocations entries

* move near clipping plane further away for more depth buffer precision. (DynamoDS#13338)

passed here:
merging.

* add more failing tests

* implement case 2 of replication

* Update ReplicationTests.cs

* add failing test

* add some more failing tests

* add some lacing tests that use arb rank params

* fix tests

1. Missing replication Longest/Shortest attribute
2. Fix result - wrap in list (like old VM)

Co-authored-by: pinzart90 <[email protected]>
Co-authored-by: pinzart <[email protected]>
Co-authored-by: Deyan Nenov <[email protected]>
Co-authored-by: jesusalvino <[email protected]>
Co-authored-by: Aaron (Qilong) <[email protected]>
Co-authored-by: Aabishkar KC <[email protected]>
Co-authored-by: kirschm <[email protected]>
sm6srw pushed a commit to sm6srw/Dynamo that referenced this pull request Jan 20, 2023
@aparajit-pratap @pinzart90
@pinzart @dnenov @jesusalvino @QilongTang @avidit @mjkkirschner @sm6srw
Add one more replication test (DynamoDS#13350)
2e7a794 
* add nunit test adapter for 2022 (DynamoDS#13313)

* add nunit test adapter for 2022

* update

* Update Setup.cs

* update

* Update DynamoCore.csproj

* Create System.Net.Http.dll

* update

* update

Co-authored-by: pinzart <[email protected]>

* Filter Mouse Pressed Removed (DynamoDS#13319)

- removed flashing white color on mouse pressed for the filter ui element

* Fixing horizontal center (DynamoDS#13312)

* Update Node AutoComplete Dialog Visuals (DynamoDS#13329)

* Update Node AutoComplete Visuals

* Reuse style from central location

* Add editorconfig (DynamoDS#13233)

* Dyn5272 (DynamoDS#13334)

tests pass - merging this then will send cherry pick

* Dyn 5159 import export preferences (DynamoDS#13301)

* Import Export Settings

* Info Icons

* Indentation

* Using Dynamo View Model reference

* Moving the methods to the proper places according to their accessibility

* Handling Generic Exceptions

* updating the RaisePropertyChanged

* Extracting the import extension file as a variable

* Unique file name

* Changing the access level

* Various revisions

* Cleaning vars

* Adding Unit Test

* Adding Comments and cleaning vars

* Removing unnecessary methods

* Refactoring to get the static fields automatically

* Updating the Unit Test

* checking new settings file

* Adding validation info

* Getting First Property with the same value

* Updating valid TrustedLocations entries

* move near clipping plane further away for more depth buffer precision. (DynamoDS#13338)

passed here:
merging.

* add more failing tests

* implement case 2 of replication

* Update ReplicationTests.cs

* add failing test

* add some more failing tests

* add replication test

* fix merge conflict

* fix merge conflict

Co-authored-by: pinzart90 <[email protected]>
Co-authored-by: pinzart <[email protected]>
Co-authored-by: Deyan Nenov <[email protected]>
Co-authored-by: jesusalvino <[email protected]>
Co-authored-by: Aaron (Qilong) <[email protected]>
Co-authored-by: Aabishkar KC <[email protected]>
Co-authored-by: Michael Kirschner <[email protected]>
Co-authored-by: kirschm <[email protected]>
sm6srw pushed a commit to sm6srw/Dynamo that referenced this pull request Jan 20, 2023
@aparajit-pratap @pinzart90
@pinzart @dnenov @jesusalvino @QilongTang @avidit @mjkkirschner @sm6srw
Update replication test (DynamoDS#13351)
df29fe8 
* add nunit test adapter for 2022 (DynamoDS#13313)

* add nunit test adapter for 2022

* update

* Update Setup.cs

* update

* Update DynamoCore.csproj

* Create System.Net.Http.dll

* update

* update

Co-authored-by: pinzart <[email protected]>

* Filter Mouse Pressed Removed (DynamoDS#13319)

- removed flashing white color on mouse pressed for the filter ui element

* Fixing horizontal center (DynamoDS#13312)

* Update Node AutoComplete Dialog Visuals (DynamoDS#13329)

* Update Node AutoComplete Visuals

* Reuse style from central location

* Add editorconfig (DynamoDS#13233)

* Dyn5272 (DynamoDS#13334)

tests pass - merging this then will send cherry pick

* Dyn 5159 import export preferences (DynamoDS#13301)

* Import Export Settings

* Info Icons

* Indentation

* Using Dynamo View Model reference

* Moving the methods to the proper places according to their accessibility

* Handling Generic Exceptions

* updating the RaisePropertyChanged

* Extracting the import extension file as a variable

* Unique file name

* Changing the access level

* Various revisions

* Cleaning vars

* Adding Unit Test

* Adding Comments and cleaning vars

* Removing unnecessary methods

* Refactoring to get the static fields automatically

* Updating the Unit Test

* checking new settings file

* Adding validation info

* Getting First Property with the same value

* Updating valid TrustedLocations entries

* move near clipping plane further away for more depth buffer precision. (DynamoDS#13338)

passed here:
merging.

* add more failing tests

* implement case 2 of replication

* Update ReplicationTests.cs

* add failing test

* add some more failing tests

* add replication test

* fix merge conflict

* fix merge conflict

* update replication test

Co-authored-by: pinzart90 <[email protected]>
Co-authored-by: pinzart <[email protected]>
Co-authored-by: Deyan Nenov <[email protected]>
Co-authored-by: jesusalvino <[email protected]>
Co-authored-by: Aaron (Qilong) <[email protected]>
Co-authored-by: Aabishkar KC <[email protected]>
Co-authored-by: Michael Kirschner <[email protected]>
Co-authored-by: kirschm <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjkkirschner mjkkirschner mjkkirschner left review comments

@reddyashish reddyashish reddyashish approved these changes

@QilongTang QilongTang QilongTang approved these changes

@zeusongit zeusongit Awaiting requested review from zeusongit

@pinzart90 pinzart90 Awaiting requested review from pinzart90

@RobertGlobant20 RobertGlobant20 Awaiting requested review from RobertGlobant20

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.17.0
Development

Successfully merging this pull request may close these issues.
6 participants
@jesusalvino @QilongTang @mjkkirschner @reddyashish @pinzart90 @RobertGlobant20