Treat null AST as primitive for update graph execution cycle #13221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
twastvedt
added a commit
that referenced
this pull request
Aug 19, 2022
* First successful build * Added to Library View Extension * Remove dependency on PresentationCore.dll * Updated some attributes * Added some resource strings * AssemblySharedInfo * Changed name to "Custom Dropdown" * Added MD file * Made changes to address two failed tests * Fix broken tests (#12082) Co-authored-by: Craig Long <[email protected]> * Added test related files * AGD 2199 Test Fix (#12161) * Fix broken tests * Remove temp test files Co-authored-by: Craig Long <[email protected]> * Modern styling applied to CustomDropdown node * Update MarkdownGeneratorCommandTests.cs * Resolved PR conflicts with master * Midway commit * Cleanup mostly done * Addressed all issues related to first PR review round * Removed .idea directory and added it to .gitignore * Icon * Merged from master * Waypoint * Error * Commit just before fixing bug related to JSON deseiralization * Fixed regression bug * DYN file test completed * Added tests and simplify some methods * Addded the .dyn file required for tests to git tracking * Corrected node name * Addressed a couple of PR comments * Deleted unused method * Solved conflict with master * A couple of changes * AssemblySharedInfo * Undid whitespace removal * Undid blank line at the end of file * Undid whitespace removal * Undid whitespace removal * Undid whitespace removal * Undid blank line * Revert XML indent size to 2 whitespaces * Revert "Undid blank line" This reverts commit 99bec28. * Revert blank line * Undid auto whitespace removal * Undid auto whitespace removal * Undid auto whitespace removal * Undid auto whitespace removal * Revert version number * Undid auto whitespace removal * Deleted two auto-generated resource cs files * Fix build * Don't hold separate source of truth, use Dynamo UI components. Updates aren't yet working. * Fix formatting. * Remove INotifyPropertyChanged from DynamoDropDownItem. Revert "Auxiliary commit to revert individual files from e849045" This reverts commit eb01977c42b39ed216f700907810d1ccf3d70cd6. * Fix some binding updates. * Improve tab navigation. * Fix more binding updates. * Remove logging. * Fix remove button styling. * Rename to match current convention. * Fix build by removing last line of AssemblySharedInfo.tt? * Clean up tests. * Clean up unnecessary changes. * Clean up extra styling. * Match +/- button color with existing nodes. * Add serialization. * Undo unnecessary changes. * Fix image class names. * Fix copy/paste deserialization. * Actually fix icon images. * Fix dropdown test. * Remove lacing comment. * Add custom selection documentation files. * Update incorrect documentation on DoubleInput. * Treat null AST as primitive for update graph execution cycle (#13221) * Update CoreUtils.cs * add test * Fix some tests. * Revert template change. * Fix comment text. * Localize output description. * Add documentation. * Reduce property visibility. * Fix inline if format. * Docs. * Reduce whitespace. * Docs fix. * Naming fixes. Co-authored-by: Craig Long <[email protected]> Co-authored-by: Craig Long <[email protected]> Co-authored-by: Trygve Wastvedt <[email protected]> Co-authored-by: Trygve Wastvedt <[email protected]> Co-authored-by: aparajit-pratap <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
There is a regression with NodeModel nodes in 2.15 where they don't update after being assigned to null AST after the optimization implemented in #12835. This was reported by the Vera team with a new UI node they're implementing, that stopped updating once a dropdown item was updated after the node was assigned to a null value.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
(FILL ME IN) Brief description of the fix / enhancement. Mandatory section
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of