🐛 [RUMF-1449] workaround for Firefox memory leak when using Zone.js #1860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1860 +/- ##
==========================================
+ Coverage 93.16% 93.19% +0.03%
==========================================
Files 134 137 +3
Lines 5135 5161 +26
Branches 1148 1150 +2
==========================================
+ Hits 4784 4810 +26
Misses 351 351
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
BenoitZugmeyer
force-pushed
the
benoit/zonejs-memoryleak-workaround
branch
from
aa0bf66 to
37efd06
Compare
liywjl
approved these changes
Dec 8, 2022
BenoitZugmeyer
force-pushed
the
benoit/zonejs-memoryleak-workaround
branch
2 times, most recently
from
67dc751 to
751c525
Compare
Use the native name rather than introducing our own concept.
BenoitZugmeyer
force-pushed
the
benoit/zonejs-memoryleak-workaround
branch
from
751c525 to
02b4a7b
Compare
BenoitZugmeyer
force-pushed
the
benoit/zonejs-memoryleak-workaround
branch
from
02b4a7b to
669b1ec
Compare
liywjl
approved these changes
Dec 8, 2022
| const browserWindow = window as BrowserWindowWithZoneJs | ||
| let original: Target[Name] | undefined | ||
| if (browserWindow.Zone) { | ||
| original = (target as any)[browserWindow.Zone.__symbol__(name)] |
There was a problem hiding this comment.
❓ question: Are we sure it works for all version of Angular/zone.js?
There was a problem hiding this comment.
Yes this is something we used before:
and it works with all tested Zone.js versions (from old ones used by Angularjs 1 to latest ones)| @@ -9,39 +10,6 @@ export const ONE_YEAR = 365 * ONE_DAY | |||
| export const ONE_KIBI_BYTE = 1024 | |||
| export const ONE_MEBI_BYTE = 1024 * ONE_KIBI_BYTE | |||
|
|
|||
| export const enum DOM_EVENT { | |||
There was a problem hiding this comment.
👏 praise: I totally agree on moving it to /browser 👍
bcaudan
approved these changes
Dec 9, 2022
amortemousque
approved these changes
Dec 9, 2022
liywjl
added a commit
that referenced
this pull request
Dec 13, 2022
* 🐛 [RUMF-1337] Fix incorrect fetch duration ♻️ remove unused imports ♻️ remove responseDurationInfo ♻️ remove unused import * 🔥 remove `resolveDuration` * 🔥 remove `resolveDuration` * 🐛 [RUMF-1449] workaround for Firefox memory leak when using Zone.js (#1860) * ♻️ [RUMF-1449] rename EventEmitter to EventTarget Use the native name rather than introducing our own concept. * 🚚 [RUMF-1449] move addEventListener functions to a dedicated module * 🐛 [RUMF-1449] implement a workaround for Firefox memory leak * 👌🚚 move stubZoneJs in its own module * 👷 Bump staging to staging-51 * 🔊 Collect computed and perf entry durations (#1861) * 🔊 Collect computed and perf entry durations * ✨Allow internal analytics subdomain (#1863) * 🔥 remove `resolveDuration` 🔥 remove `resolveDuration` Co-authored-by: Benoît <[email protected]> Co-authored-by: ci.browser-sdk <[email protected]> Co-authored-by: Aymeric <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Firefox is leaking memory when using Zone.js +
visualViewport.addEventListener: https://bugzilla.mozilla.org/show_bug.cgi?id=1804409Changes
addEventListenermethod instead of the patched oneTesting
I have gone over the contributing documentation.