๐ Collect computed and perf entry durations #1861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1861 +/- ##
=======================================
Coverage 93.13% 93.14%
=======================================
Files 132 132
Lines 5100 5106 +6
Branches 1143 1146 +3
=======================================
+ Hits 4750 4756 +6
Misses 350 350
๐ฃ Weโre building smart automated test selection to slash your CI/CD build times. Learn more |
amortemousque
force-pushed
the
aymeric/resource-duration-investigation
branch
from
6585933 to
114dca3
Compare
liywjl
reviewed
Dec 8, 2022
packages/rum-core/src/domain/rumEventsCollection/resource/resourceCollection.ts
Outdated
Show resolved
Hide resolved
liywjl
approved these changes
Dec 9, 2022
bcaudan
reviewed
Dec 9, 2022
packages/rum-core/src/domain/rumEventsCollection/resource/resourceCollection.ts
Outdated
Show resolved
Hide resolved
packages/rum-core/src/domain/rumEventsCollection/resource/resourceCollection.ts
Outdated
Show resolved
Hide resolved
BenoitZugmeyer
approved these changes
Dec 9, 2022
bcaudan
approved these changes
Dec 12, 2022
liywjl
pushed a commit
that referenced
this pull request
Dec 13, 2022
* ๐ Collect computed and perf entry durations
liywjl
added a commit
that referenced
this pull request
Dec 13, 2022
* ๐ [RUMF-1337] Fix incorrect fetch duration โป๏ธ remove unused imports โป๏ธ remove responseDurationInfo โป๏ธ remove unused import * ๐ฅ remove `resolveDuration` * ๐ฅ remove `resolveDuration` * ๐ [RUMF-1449] workaround for Firefox memory leak when using Zone.js (#1860) * โป๏ธ [RUMF-1449] rename EventEmitter to EventTarget Use the native name rather than introducing our own concept. * ๐ [RUMF-1449] move addEventListener functions to a dedicated module * ๐ [RUMF-1449] implement a workaround for Firefox memory leak * ๐๐ move stubZoneJs in its own module * ๐ท Bump staging to staging-51 * ๐ Collect computed and perf entry durations (#1861) * ๐ Collect computed and perf entry durations * โจAllow internal analytics subdomain (#1863) * ๐ฅ remove `resolveDuration` ๐ฅ remove `resolveDuration` Co-authored-by: Benoรฎt <[email protected]> Co-authored-by: ci.browser-sdk <[email protected]> Co-authored-by: Aymeric <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In the context of the investigation of resources with long durations, I want to assess the performance entry durations correctness.
To do it, I want to colllect xhr and fetch computed durations and corresponding performance entry durations to identify:
Changes
Adds
resource._dd.computed_durationandresource._dd.entry_performance_durationUnder feature flag resource_durations
Testing
I have gone over the contributing documentation.