✨Allow internal analytics intake #1863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1863 +/- ##
=======================================
Coverage 93.16% 93.17%
=======================================
Files 134 134
Lines 5135 5140 +5
Branches 1148 1149 +1
=======================================
+ Hits 4784 4789 +5
Misses 351 351
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
amortemousque
force-pushed
the
aymeric/internal-analytics-intake
branch
from
92251de to
2e4a474
Compare
liywjl
approved these changes
Dec 12, 2022
bcaudan
approved these changes
Dec 12, 2022
liywjl
pushed a commit
that referenced
this pull request
Dec 13, 2022
liywjl
added a commit
that referenced
this pull request
Dec 13, 2022
* 🐛 [RUMF-1337] Fix incorrect fetch duration ♻️ remove unused imports ♻️ remove responseDurationInfo ♻️ remove unused import * 🔥 remove `resolveDuration` * 🔥 remove `resolveDuration` * 🐛 [RUMF-1449] workaround for Firefox memory leak when using Zone.js (#1860) * ♻️ [RUMF-1449] rename EventEmitter to EventTarget Use the native name rather than introducing our own concept. * 🚚 [RUMF-1449] move addEventListener functions to a dedicated module * 🐛 [RUMF-1449] implement a workaround for Firefox memory leak * 👌🚚 move stubZoneJs in its own module * 👷 Bump staging to staging-51 * 🔊 Collect computed and perf entry durations (#1861) * 🔊 Collect computed and perf entry durations * ✨Allow internal analytics subdomain (#1863) * 🔥 remove `resolveDuration` 🔥 remove `resolveDuration` Co-authored-by: Benoît <[email protected]> Co-authored-by: ci.browser-sdk <[email protected]> Co-authored-by: Aymeric <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To mitigate ad blockers for internal analytics monitored sites, we can now configure a specific subdomain.
Changes
Add new init config option
internalAnalyticsSubdomainOnly allow internal analytics intake for traffic going to
datadoghq.com(including replica)Testing
I have gone over the contributing documentation.