🚨 [RUMF-1505] ESLint rule to forbid usage of Zone.js problematic values #2031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenoitZugmeyer
force-pushed
the
benoit/disallow-zone-js-patched-values--eslint-rule
branch
from
e7e9d89 to
72f3133
Compare
4 tasks
amortemousque
approved these changes
Feb 27, 2023
BenoitZugmeyer
deleted the
benoit/disallow-zone-js-patched-values--eslint-rule
branch
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As we've seen in the past, integrating the SDK on an app that uses Angular/Zone.js causes critical issues in various ways. See related PRs:
Changes
This PR adds an ESLint rule to forbid usage of some values that are known to cause trouble when they are patched by Zone.js. This PR focuses on introducing the rule and disallow
MutationObserver. Future PRs will disallow more things.Testing
I have gone over the contributing documentation.