Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ [RUMF-1505] introduce a safe setInterval helper function #2044

Merged

Conversation

BenoitZugmeyer
Copy link
Member

@BenoitZugmeyer BenoitZugmeyer commented Feb 28, 2023

Motivation

See related PRs:

Even though we didn't found any problem when using setInterval on Angular websites, let's consider it problematic in prevention and to unify its usages with setTimeout

Changes

Introduce a safe setInterval helper function and use it in packages.

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@BenoitZugmeyer BenoitZugmeyer force-pushed the benoit/disallow-zone-js-patched-values--set-interval branch from 4506cb8 to b17131f Compare March 10, 2023 15:40
@codecov-commenter
Copy link

Codecov Report

Merging #2044 (b17131f) into main (1cc4fc7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2044   +/-   ##
=======================================
  Coverage   93.62%   93.62%           
=======================================
  Files         156      156           
  Lines        5522     5525    +3     
  Branches     1256     1256           
=======================================
+ Hits         5170     5173    +3     
  Misses        352      352           
Impacted Files Coverage Δ
packages/core/src/tools/contextHistory.ts 100.00% <ø> (ø)
packages/core/src/browser/timer.ts 100.00% <100.00%> (ø)
packages/core/src/domain/session/sessionManager.ts 100.00% <100.00%> (ø)
packages/core/src/domain/session/sessionStore.ts 100.00% <100.00%> (ø)
.../src/domain/rumEventsCollection/view/trackViews.ts 100.00% <100.00%> (ø)
.../rum-core/src/domain/startCustomerDataTelemetry.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@BenoitZugmeyer BenoitZugmeyer force-pushed the benoit/disallow-zone-js-patched-values--set-interval branch from b17131f to 5a35653 Compare March 21, 2023 17:06
@BenoitZugmeyer BenoitZugmeyer marked this pull request as ready for review March 21, 2023 17:07
@BenoitZugmeyer BenoitZugmeyer requested a review from a team as a code owner March 21, 2023 17:07
@BenoitZugmeyer BenoitZugmeyer merged commit fc60898 into main Mar 27, 2023
@BenoitZugmeyer BenoitZugmeyer deleted the benoit/disallow-zone-js-patched-values--set-interval branch March 27, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants