Jsonize bionic power gen from sunlight and wind #35643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
November 21, 2019 17:05
This reverts commit e094038.
ZhilkinSerg
added
[C++]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "Jsonize bionic power gen from sunlight and wind"Purpose of change
Jsonize bionic power gen from sunlight and wind
Fixes #35542
Describe the solution
Add sun_light fuel
Add code to handle perpetual fuel wind and sun light in
burn_fuel()Add
passive_power_gen()function to handle power production from inactive CBMs fueld by pertual fuelAdd
coverage_power_gen_penaltythe fraction of coverage diminishingfuel_efficiencyAdd
get_effective_efficiency()that returns the efficiency after applying penalty fromcoverage_power_gen_penaltyEncapsulate heat production from exothermic power gen
Add
Wind Turbine CBMto aftershockDescribe alternatives you've considered
Testing
Get Solar panel CBM
Get into the Sun and wait
Power goes up
Get Wind Turbine CBM
Go outside and wait
Power goes up
Get on a bike and drive
Power goes up faster
Add
"coverage_power_gen_penalty": 1.0,to Wind turbineDrive bike
No power
Remove cloth on torso
Power goes up
Additional context
passive_power_gen()won't do anything untill #35620 is merged since un-active CBMs are not processed currently