Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jsonize bionic power gen from sunlight and wind #35643

Merged
merged 11 commits into from
Nov 23, 2019

Conversation

Fris0uman
Copy link
Contributor

Summary

SUMMARY: Infrastructure "Jsonize bionic power gen from sunlight and wind"

Purpose of change

Jsonize bionic power gen from sunlight and wind
Fixes #35542

Describe the solution

Add sun_light fuel
Add code to handle perpetual fuel wind and sun light in burn_fuel()
Add passive_power_gen() function to handle power production from inactive CBMs fueld by pertual fuel
Add coverage_power_gen_penalty the fraction of coverage diminishing fuel_efficiency
Add get_effective_efficiency() that returns the efficiency after applying penalty from coverage_power_gen_penalty
Encapsulate heat production from exothermic power gen
Add Wind Turbine CBM to aftershock

Describe alternatives you've considered

Testing

Get Solar panel CBM
Get into the Sun and wait
Power goes up
Get Wind Turbine CBM
Go outside and wait
Power goes up
Get on a bike and drive
Power goes up faster

Add "coverage_power_gen_penalty": 1.0, to Wind turbine
Drive bike
No power
Remove cloth on torso
Power goes up

Additional context

passive_power_gen() won't do anything untill #35620 is merged since un-active CBMs are not processed currently

@Fris0uman Fris0uman marked this pull request as ready for review November 21, 2019 21:34
@ZhilkinSerg ZhilkinSerg added [C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON Bionics CBM (Compact Bionic Modules) labels Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bionics CBM (Compact Bionic Modules) [C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Solar Panels an active CBM
3 participants