Add Auto start mode to power gen bionics #35620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BevapDin
reviewed
Nov 20, 2019
Co-Authored-By: Anton Burmistrov <[email protected]>
ZhilkinSerg
added
[C++]
RDru
reviewed
Nov 22, 2019
| @@ -972,6 +972,10 @@ static bool attempt_recharge( Character &p, bionic &bio, units::energy &amount, | |||
| void Character::process_bionic( int b ) | |||
| { | |||
| bionic &bio = ( *my_bionics )[b]; | |||
| if( calendar::once_every( 1_hours ) && !bio.id->fuel_opts.empty() && | |||
| bio.has_flag( "AUTO_START_ON" ) && power_level <= 0_mJ ) { | |||
There was a problem hiding this comment.
Sorry, but with this conditions this feature is useless. It needs to be at least every minute and somewhere between 66% - 80% of max power.
There was a problem hiding this comment.
Ok I'm setting up a menu to choose the threshold, I just need to figure out the time interval thing, because trying to turn on your CBM every minutes when you don't have fuel for it is very spammy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Features "Add Auto start mode to power gen bionics"Purpose of change
Add Auto Start mode if ON the bionic will try to start every hour if your power_level is <=0_mJ
It's OFF by default
Describe the solution
Use the flag system set up for fuel saving mode
Describe alternatives you've considered
Testing
Install MI
Turn Auto Start on
Wait
Bionic turn ON
Powers fills
Since Saving fuel is ON it also turns Off automatically
Additional context
This can only work for the player as the activation uses
g->u