Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change power efficiency numbers #30656

Merged
merged 9 commits into from
Jun 14, 2019
Merged

Change power efficiency numbers #30656

merged 9 commits into from
Jun 14, 2019

Conversation

ymber
Copy link
Member

@ymber ymber commented May 19, 2019

Summary

SUMMARY: Balance "Change power draw of vehicle parts and electric tools to reflect reality"

Purpose of change

A lot of power draw numbers were a long way off from reality and/or hadn't been updated when everything switched to watts. With the recent and future changes increasing energy scarcity incredibly inefficient devices would become an obvious problem. Imminent changes to make turn and action lengths more realistic will also make such inefficient hardware look more like 0A era kind of artistic license physics.

Describe the solution

Change values for electric power draw to accurately reflect reality. In most cases this has meant significantly increasing energy efficiency.

Additional context

The vehicle epower changes should be fine now but changes to turns_per_charge values shouldn't be merged until after #30253 or electric tools will be six times more efficient than they should be.

@ymber ymber changed the title Power Change power efficiency numbers May 19, 2019
@ifreund ifreund added [C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON Game: Balance Balancing of (existing) in-game features. Vehicles Vehicles, parts, mechanics & interactions Items: Battery / UPS Electric power management labels May 19, 2019
@mlangsdorf
Copy link
Contributor

Please update the docs so future contributors know how to convert watts to turns_per_charge.

Also consider replacing turn_per_charge with "watts" as a float in JSON and then converting it in the code. That would improve readability and make it much easier to convert to 1 second turns in the future.

@Inglonias
Copy link
Contributor

Are you planning to adjust battery capacity in a similar fashion? Right now they use round numbers that don't make a whole lot of sense, and altering efficiency means that altering battery capacity might also be called for.

@@ -5209,7 +5209,7 @@
"name": "mp3 player (on)",
"name_plural": "mp3 players (on)",
"description": "This mp3 player is turned on and playing some great tunes, raising your morale steadily while on your person. It runs through batteries quickly; you can turn it off by using it. It also obscures your hearing.",
"turns_per_charge": 150,
"turns_per_charge": 10000,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a ludicrous increase in efficiency. I wonder if we'll see any bug reports about tools suddenly having infinite battery life?

@ymber
Copy link
Member Author

ymber commented May 25, 2019

Added a new power_draw field and updated most items to use it. We should consider using mJ internally for storing energy as we have mW range items. Working accurately with integer kJ values is hard with low power over short times. We might also want a power string parser at some point.

src/map.cpp Outdated Show resolved Hide resolved
Co-Authored-By: anothersimulacrum <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Game: Balance Balancing of (existing) in-game features. Items: Battery / UPS Electric power management [JSON] Changes (can be) made in JSON Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants