Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement energy and power classes to allow appropriate units to be used everywhere, separate batteries from magazines #32067

Open
5 of 15 tasks
ymber opened this issue Jul 2, 2019 · 2 comments
Labels
Items: Battery / UPS Electric power management (P5 - Long-term) Long-term WIP, may stay on the list for a while.

Comments

@ymber
Copy link
Member

ymber commented Jul 2, 2019

Is your feature request related to a problem? Please describe.
Working with integer kJ values for power draw under 1kW requires using RNG to decide if a charge will be consumed in a given turn, which becomes more inconsistent the lower the power draw is. See #30656.

See also the original PR #31079 which is being split up as it was going to get far too big.

Describe the solution you'd like
Energy and power should have supporting code for quantity classes that allow much higher precision.

Describe alternatives you've considered
Making battery charges millijoules would be the easiest solution but then we'd have to use that precision everywhere and some cases are more appropriately handled with larger units. Separating batteries from magazines will also allow easier modification in the future if there is interest in making batteries more detailed eg modeling maximum voltage and current.

@stale
Copy link

stale bot commented Aug 14, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@stale stale bot added the stale Closed for lack of activity, but still valid. label Aug 14, 2019
@stale
Copy link

stale bot commented Sep 13, 2019

This issue has been automatically closed due to lack of activity. This does not mean that we do not value the issue. Feel free to request that it be re-opened if you are going to actively work on it

@stale stale bot closed this as completed Sep 13, 2019
@ZhilkinSerg ZhilkinSerg added (P5 - Long-term) Long-term WIP, may stay on the list for a while. and removed stale Closed for lack of activity, but still valid. labels Sep 18, 2019
@ymber ymber reopened this Nov 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Items: Battery / UPS Electric power management (P5 - Long-term) Long-term WIP, may stay on the list for a while.
Projects
None yet
Development

No branches or pull requests

2 participants