Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tool and grenade processing with 1 second turns #31382

Closed
ifreund opened this issue Jun 13, 2019 · 4 comments
Closed

Tool and grenade processing with 1 second turns #31382

ifreund opened this issue Jun 13, 2019 · 4 comments
Labels
<Bug> This needs to be fixed Items / Item Actions / Item Qualities Items and how they work and interact <Suggestion / Discussion> Talk it out before implementing Time / Turns / Duration / Date Issues concerning any activities being too fast or too slow. Also issues about time and date ingame

Comments

@ifreund
Copy link
Contributor

ifreund commented Jun 13, 2019

Describe the bug

Tools that make use of "turns_per_charge" haven't been updated to account for 1 second turns. This means that in most cases they consume charge six times too fast.

Expected behavior

Unfortunately the fix is not as simple as multiplying them all by 6, as there are be some tools that used to have a value of 1 "turns_per_charges" and should continue to do so.

Additional context

Grenades suffer from the same problem, though it's even less clear if their lifetimes should be extended to match the old behavior. Most likely they are fine as they are now.

@ifreund ifreund added <Bug> This needs to be fixed <Suggestion / Discussion> Talk it out before implementing Items / Item Actions / Item Qualities Items and how they work and interact Time / Turns / Duration / Date Issues concerning any activities being too fast or too slow. Also issues about time and date ingame labels Jun 13, 2019
@Rivet-the-Zombie
Copy link
Member

A grenade really shouldn't take thirty seconds to explode after its pin is pulled, so I think they're fine now. The other stuff totally needs to be fixed though.

@ymber
Copy link
Member

ymber commented Jun 16, 2019

Most of the powered tools and similar should be fine since #30656. Grenades are fine now. Most of the items left have arbitrary turns_per_charge values like the rebreathers. While we're updating them we should do the research for realistic values for the real items and make up some plausible numbers for fictional ones.

@Night-Pryanik
Copy link
Contributor

We need an exhaustive list of tools not working right (if any at all) for this issue to be valid.

@anothersimulacrum
Copy link
Member

Seeing as none has been provided, I think this is probably resolved (or very well hidden).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed Items / Item Actions / Item Qualities Items and how they work and interact <Suggestion / Discussion> Talk it out before implementing Time / Turns / Duration / Date Issues concerning any activities being too fast or too slow. Also issues about time and date ingame
Projects
None yet
Development

No branches or pull requests

5 participants