npctalk: move almost all dialogue into JSON #27901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlangsdorf
added
NPC / Factions
18 tasks
move mission responses and sharing equipment, along with a few other items, into JSON now that all the infrastructure is in place.
mlangsdorf
force-pushed
the
npctalk_ally_to_json
branch
from
d55a39f to
6a0277e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "npctalk: move almost all dialogue into JSON"Purpose of change
Take advantage of the new JSON dialogue infrastructure to move almost all the remaining hardcoded NPC dialogue into JSON.
Describe the solution
with truefalsetext and generic CONDITION trials from #27707, mission goals, mission based opionion changes, the add_debt effect and some other things from #27734, the NPC needs in JSON from #27858, and the NPC follower AI rules in JSON changes from #27859, there aren't a lot of talk topics that can't be moved into JSON. Move most of those functions into JSON and delete some now unnecessary helper MACROs.
Additional context
Built on top of #27859.
Final implementation of #27643