npctalk: add a bunch of new options to JSON #27734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new response option for response text, "truefalsetext", which takes a condition and displays a "true" text if the condition is true and false otherwise. The response trial, effects, etc. are the same for both texts.
Add a new type of trial, "CONDITION" which always succeeds or fails based on the value of a condition object.
Add a new version of the `opinion` effect called `mission_opinion`. `mission_opinion` adjusts NPC `op_of_u` according to the mission value.
Add an `and` option, which joins multiple other dynamic lines together.
Add a variety of new options: * `and` dynamic lines * `u_driving`, `npc_driving`, and `no_vehicle` dynamic lines * `has_pickup_list` dynamic line * `mission_goal`, `mission_complete`, `mission_incomplete` conditions * `npc_following`, `npc_friend`, `npc_hostile` conditions * `npc_train_styles`, `npc_train_skills` conditions * `add_debt` effect
mlangsdorf
added
<Enhancement / Feature>
18 tasks
ZhilkinSerg
added
the
Code: Tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "npctalk: add a bunch of new options to JSON"Purpose of change
Add a variety of new options:
anddynamic linesu_driving,npc_driving, andno_vehicledynamic lineshas_pickup_listdynamic linemission_goal,mission_complete,mission_incompleteconditionsnpc_following,npc_friend,npc_hostileconditionsnpc_train_styles,npc_train_skillsconditionsadd_debteffectmission_opinionopinion modifiersDescribe the solution
andis implemented as a vector of dynamic_line_t and each entry in the vector is called and the result is concatenated together.u_drivingandnpc_drivingcheck if the player or NPC is currently in control of a moving vehicle.no_vehicleis true if both of the previous are false.has_pickup_listchecks if the NPC has a pickup list in their follower rules.mission_goalchecks if the current selected mission for the conversation matches the specific type.All the others are straightforward boolean checks of the relevant attribute.
Additional Context
Long term plan is at #27643