Npctalk ally rules #27859
Merged
Npctalk ally rules #27859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlangsdorf
added
NPC / Factions
18 tasks
ZhilkinSerg
added
the
<Documentation>
Change npc_follower_rules to use a enum bitfield instead of individual booleans to make it easier to write a single function to toggle the rules. Then create functions to toggle NPC follower AI rules and move all that dialogue into JSON.
mlangsdorf
force-pushed
the
npctalk_ally_rules
branch
from
6f83995 to
5cd6b13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "npctalk: move NPC follower AI rules to JSON"Purpose of change
Make it slightly easier to adjust NPC follower AI rules by moving the dialogue to change them into JSON.
Describe the solution
Change all the npc_follower_rules booleans into enum bitfields, so that they can be checked and changed with simple
has_flag,set_flag,clear_flag,toggle_flagfunctions instead of multiple nested templates.Add JSON parsing for options to check and set npc_follower_rules.
Move most NPC follower dialogue into a new JSON file.
Additional context
Requires #27858
See #27643 for the long term plan.