Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npc: fix NPC followers not closing doors #27932

Merged
merged 1 commit into from
Jan 28, 2019

Conversation

mlangsdorf
Copy link
Contributor

Summary

SUMMARY: Bugfixes "npc: fix NPC followers not closing doors"

Purpose of change

Fix some typos that prevented NPCs from closing doors and the player from being able to update the close door NPC follower AI rule.

Describe the solution

For some reason, the boolean for NPC followers closing doors wasn't removed in #27859, and there was separately a typo in the dialogue option to change the open/close door setting. Fix both so NPCs followers can be told to shut doors and will do so.

Fix some typos that prevented NPCs from closing doors and the player
from being able to update the close door NPC follower AI rule.
@mlangsdorf mlangsdorf added NPC / Factions NPCs, AI, Speech, Factions, Ownership [JSON] Changes (can be) made in JSON [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) labels Jan 28, 2019
@ZhilkinSerg ZhilkinSerg merged commit e4d4227 into CleverRaven:master Jan 28, 2019
@mlangsdorf mlangsdorf deleted the npc_close_door_fix branch January 28, 2019 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants