game crashed after closing the achievement pop-up message #64466
Comments
gettingusedto
added
the
(S1 - Need confirmation)
|
Can confirm as it happened with the first kill achievement as well. https://ibb.co/GnGVWqG |
|
Can also confirm.
|
anothersimulacrum
added
<Crash / Freeze>
|
On cataclysm-tiles Linux is failing too, commit: 6c5f917 Error msg: How to reproduce: |
|
Can confirm on the Thank Goodness It's Friday achievement, except crashes before the achievement shows. Click to open backtraceVersion is 4ad1388 on Linux, with local patches applied unrelated to achievements. |
|
Given the Cataclysm-DDA/src/achievement.cpp Lines 789 to 790 in 4ad1388 |
|
Also having this issue, posted save and debug data etc. in #64499 if anyone wants to have a look. Curiously, I didn't crash when I leveled Computers all the way to 10 and got that achievement. |
|
I'm not getting it on Linux. |
|
I'm getting this too, however I found a workaround: Open the achievement menu with ')' before gaining achievements. This will load the past game data in advance, and achievements will popup without crashing the game. |
|
Getting this too. But in my case it's by "Thanks god its Friday" and my autosave is when the character is sleeping :( |
|
The ones that can reproduce: What OS are you running? |
|
It's possible it's not an OS thing and simply I don't have much/anything in the way of past games here. |
|
It happens to me too in the android (x64) build, with the achievement of waking up after one day (The first day of the rest of their unlives), I can also confirm that opening the achievements menu after loading the last save before the crash did gave me the achievement without any crashes. |
Windows 10 64bit |
|
macOS 12.6.1 (Intel chip) |
NetSysFire
added
the
Game: Achievements / Conducts / Scores
True. But we can now say with confidence its not an OS thing. |
|
Also having this issue with the "Way of the Sword" achievement. The crash happens before the achievement pops up. Running on Windows 10.
|
|
This issue has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there: https://discourse.cataclysmdda.org/t/game-continually-crashes-when-creature-dies/28632/2 |
|
The best workaround is to set "Popup window when achievement completed" to Never. This way it simply won't crash and you don't have to disable achievements or anticipate when the popup window will appear. |
Where is this option? Edit: It's under Interface options, line 42. |
NetSysFire
added
the
Help Wanted
|
(https://github.com/CleverRaven/Cataclysm-DDA/files/11067598/crash.log) |
|
That keybind was just removed as a top-level keybind #64470 |
Well, disregard, I'm dumb. lol |
|
In order to avoid even more duplicates, I have pinned this one now. |
|
Introduced by 86a398f (#63488). The "migration" runs on stats from past games, in the middle of the achievement callback, and screws up the order of operations. The achievement tracker code is pretty hard to follow, but this fixes the crash: diff --git a/src/achievement.cpp b/src/achievement.cpp
index bbec6598f4..6229162f4a 100644
--- a/src/achievement.cpp
+++ b/src/achievement.cpp
@@ -798,12 +798,12 @@ void achievements_tracker::report_achievement( const achievement *a, achievement
tracker_it->second.current_values()
}
);
+ trackers_.erase( tracker_it );
if( comp == achievement_completion::completed ) {
achievement_attained_callback_( a, is_enabled() );
} else if( comp == achievement_completion::failed ) {
achievement_failed_callback_( a, is_enabled() );
}
- trackers_.erase( tracker_it );
}
achievement_completion achievements_tracker::is_completed( const achievement_id &id ) const(the required bits are copied just above that) |
|
confirm that, I thought it was just from the robot killing one. |
|
Its still happening, whats wrong with the achievements? |
|
This issue has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there: https://discourse.cataclysmdda.org/t/crashes-while-getting-any-achievement/28668/2 |
Describe the bug
When i was studying a spell from the spellbook i found, i got the achievement pop-up for learning a spell. Closing said pop-up crashed the game.
Attach save file
Nelson-trimmed.tar.gz
Steps to reproduce
Expected behavior
Not crashing.
Screenshots
No response
Versions and configuration
Dark Days Ahead [dda],
Disable NPC Needs [no_npc_food],
No Fungal Growth [no_fungal_growth],
Portal Storms Ignore NPCs [personal_portal_storms],
Magiclysm [magiclysm],
Xedra Evolved [xedra_evolved],
DinoMod [DinoMod]
]
Additional context
crash.log
debug.log
The text was updated successfully, but these errors were encountered: