Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Crash on Achievement Gain #64996

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Conversation

Maleclypse
Copy link
Member

Summary

Bugfixes "Crash on achievement gain"

Purpose of change

Fixes #64466.

Describe the solution

Uses andrei's suggestion.

Describe alternatives you've considered

None

Testing

I was able to gain achievements without my game crashing.

Additional context

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` Game: Achievements / Conducts / Scores Player goals and how they are tracked. <Bugfix> This is a fix for a bug (or closes open issue) json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Apr 11, 2023
@dseguin dseguin merged commit bdc6908 into CleverRaven:master Apr 11, 2023
@Maleclypse Maleclypse deleted the achievements-fix branch April 11, 2023 14:47
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 11, 2023
Night-Pryanik pushed a commit to Cataclysm-TISH-team/Cataclysm-TISH that referenced this pull request Apr 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Game: Achievements / Conducts / Scores Player goals and how they are tracked. json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

game crashed after closing the achievement pop-up message
2 participants