Tracking whether MAPBUFFER actually needs saving #32

zpmorgan · 2013-02-02T07:31:21Z

with a 'dirty bit'. I imagine that overmaps and nonants
could use the same principle to be loaded on demand
andn saved as needed.

with a 'dirty bit'. I imagine that overmaps and nonants could use the same principle to be loaded on demand andn saved as needed.

Tracking whether MAPBUFFER actually needs saving

Merge from dev to master

Lint json #32

SUS Prep Dec. 17

make it up to date

If melee_actori.is_grab is false grab.exclusive_grab and grab.respect_seatbelts were not initialized. This was causing errors under -fsanitize=undefined The solution initialize the booleans to value that match their defaults ```C++ src/mattack_actors.h:75:8: runtime error: load of value 190, which is not a valid value for type 'bool' #0 0x5a9b6fe in grab::grab(grab const&) src/mattack_actors.h:75 #1 0x5ab7635 in melee_actor::melee_actor(melee_actor const&) src/mattack_actors.h:106 #2 0x5ab8412 in std::__detail::_MakeUniq<melee_actor>::__single_object std::make_unique<melee_actor, melee_actor const&>(melee_actor const&) /usr/include/c++/13/bits/unique_ptr.h:1070 #3 0x5a87e4c in melee_actor::clone() const src/mattack_actors.cpp:962 CleverRaven#4 0x207632c in cata::clone_ptr<mattack_actor>::clone_ptr(cata::clone_ptr<mattack_actor> const&) src/clone_ptr.h:18 CleverRaven#5 0x6085941 in mtype_special_attack::mtype_special_attack(mtype_special_attack const&) src/mattack_common.h:47 CleverRaven#6 0x6085941 in std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack>::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack, true>(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, mtype_special_attack const&) /usr/include/c++/13/bits/stl_pair.h:559 CleverRaven#7 0x6085a2b in void std::__new_allocator<std::_Rb_tree_node<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack> > >::construct<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack>, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, mtype_special_attack const&>(std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack>*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, mtype_special_attack const&) /usr/include/c++/13/bits/new_allocator.h:187 CleverRaven#8 0x6085a2b in void std::allocator_traits<std::allocator<std::_Rb_tree_node<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack> > > >::construct<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack>, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, mtype_special_attack const&>(std::allocator<std::_Rb_tree_node<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack> > >&, std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack>*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, mtype_special_attack const&) /usr/include/c++/13/bits/alloc_traits.h:537 CleverRaven#9 0x6085a2b in void std::_Rb_tree<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack>, std::_Select1st<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack> >, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack> > >::_M_construct_node<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, mtype_special_attack const&>(std::_Rb_tree_node<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack> >*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, mtype_special_attack const&) /usr/include/c++/13/bits/stl_tree.h:597 CleverRaven#10 0x6085b06 in std::_Rb_tree_node<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack> >* std::_Rb_tree<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack>, std::_Select1st<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack> >, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack> > >::_M_create_node<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, mtype_special_attack const&>(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, mtype_special_attack const&) /usr/include/c++/13/bits/stl_tree.h:614 CleverRaven#11 0x6085b71 in std::_Rb_tree<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack>, std::_Select1st<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack> >, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack> > >::_Auto_node::_Auto_node<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, mtype_special_attack const&>(std::_Rb_tree<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack>, std::_Select1st<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack> >, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack> > >&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, mtype_special_attack const&) /usr/include/c++/13/bits/stl_tree.h:1637 CleverRaven#12 0x6085c9d in std::_Rb_tree_iterator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack> > std::_Rb_tree<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack>, std::_Select1st<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack> >, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack> > >::_M_emplace_hint_unique<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, mtype_special_attack const&>(std::_Rb_tree_const_iterator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, mtype_special_attack const&) /usr/include/c++/13/bits/stl_tree.h:2462 CleverRaven#13 0x608618f in std::_Rb_tree_iterator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack> > std::map<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, mtype_special_attack, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack> > >::emplace_hint<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, mtype_special_attack const&>(std::_Rb_tree_const_iterator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, mtype_special_attack const&) /usr/include/c++/13/bits/stl_map.h:640 CleverRaven#14 0x608618f in std::pair<std::_Rb_tree_iterator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack> >, bool> std::map<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, mtype_special_attack, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack> > >::emplace<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, mtype_special_attack const&>(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, mtype_special_attack const&) /usr/include/c++/13/bits/stl_map.h:601 CleverRaven#15 0x5ff3881 in MonsterGenerator::add_attack(mtype_special_attack const&) src/monstergenerator.cpp:1312 CleverRaven#16 0x5ffafa5 in MonsterGenerator::load_monster_attack(JsonObject const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) src/monstergenerator.cpp:1376 CleverRaven#17 0x4262e91 in operator() src/init.cpp:466 CleverRaven#18 0x4262e91 in __invoke_impl<void, DynamicDataLoader::initialize()::<lambda(const JsonObject&, const std::string&)>&, const JsonObject&, const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&> /usr/include/c++/13/bits/invoke.h:61 CleverRaven#19 0x4262e91 in __invoke_r<void, DynamicDataLoader::initialize()::<lambda(const JsonObject&, const std::string&)>&, const JsonObject&, const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&> /usr/include/c++/13/bits/invoke.h:111 CleverRaven#20 0x4262e91 in _M_invoke /usr/include/c++/13/bits/std_function.h:290 CleverRaven#21 0x4290ce9 in std::function<void (JsonObject const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)>::operator()(JsonObject const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) const /usr/include/c++/13/bits/std_function.h:591 CleverRaven#22 0x42693bf in operator() src/init.cpp:227 CleverRaven#23 0x42693bf in __invoke_impl<void, DynamicDataLoader::add(const std::string&, const std::function<void(const JsonObject&, const std::__cxx11::basic_string<char>&)>&)::<lambda(const JsonObject&, const std::string&, const cata_path&, const cata_path&)>&, const JsonObject&, const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&, const cata_path&, const cata_path&> /usr/include/c++/13/bits/invoke.h:61 CleverRaven#24 0x42693bf in __invoke_r<void, DynamicDataLoader::add(const std::string&, const std::function<void(const JsonObject&, const std::__cxx11::basic_string<char>&)>&)::<lambda(const JsonObject&, const std::string&, const cata_path&, const cata_path&)>&, const JsonObject&, const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&, const cata_path&, const cata_path&> /usr/include/c++/13/bits/invoke.h:111 CleverRaven#25 0x42693bf in _M_invoke /usr/include/c++/13/bits/std_function.h:290 CleverRaven#26 0x4290563 in std::function<void (JsonObject const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, cata_path const&, cata_path const&)>::operator()(JsonObject const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, cata_path const&, cata_path const&) const /usr/include/c++/13/bits/std_function.h:591 CleverRaven#27 0x42849b9 in DynamicDataLoader::load_object(JsonObject const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, cata_path const&, cata_path const&) src/init.cpp:137 CleverRaven#28 0x4285ca2 in DynamicDataLoader::load_all_from_json(JsonValue const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, loading_ui&, cata_path const&, cata_path const&) src/init.cpp:540 CleverRaven#29 0x42867b4 in DynamicDataLoader::load_data_from_path(cata_path const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, loading_ui&) src/init.cpp:521 CleverRaven#30 0x3ca266a in game::load_data_from_dir(cata_path const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, loading_ui&) src/game.cpp:571 CleverRaven#31 0x3d211a0 in game::load_packs(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::vector<string_id<MOD_INFORMATION>, std::allocator<string_id<MOD_INFORMATION> > > const&, loading_ui&) src/game.cpp:3265 CleverRaven#32 0x3d51925 in game::load_world_modfiles(loading_ui&) src/game.cpp:3235 CleverRaven#33 0x3e05640 in game::setup() src/game.cpp:756 CleverRaven#34 0x5111d33 in main_menu::new_character_tab() src/main_menu.cpp:972 CleverRaven#35 0x5127b5a in main_menu::opening_screen() src/main_menu.cpp:863 CleverRaven#36 0x50f1ece in main src/main.cpp:792 CleverRaven#37 0x7fdc43fa9b89 in __libc_start_call_main (/lib64/libc.so.6+0x27b89) (BuildId: f888be5f5e7d58e04cabb8c675c7ab94e77dd68c) CleverRaven#38 0x7fdc43fa9c4a in __libc_start_main_alias_2 (/lib64/libc.so.6+0x27c4a) (BuildId: f888be5f5e7d58e04cabb8c675c7ab94e77dd68c) CleverRaven#39 0x1bec874 in _start (/home/cdda/git/Cataclysm-DDA/cataclysm-tiles+0x1bec874) (BuildId: be24990d1723c8da00f3e8701793ab983cf64dcc) ```

If melee_actori.is_grab is false grab.exclusive_grab and grab.respect_seatbelts were not initialized. This was causing errors under -fsanitize=undefined The solution initialize the booleans to value that match their defaults ```C++ src/mattack_actors.h:75:8: runtime error: load of value 190, which is not a valid value for type 'bool' #0 0x5a9b6fe in grab::grab(grab const&) src/mattack_actors.h:75 #1 0x5ab7635 in melee_actor::melee_actor(melee_actor const&) src/mattack_actors.h:106 #2 0x5ab8412 in std::__detail::_MakeUniq<melee_actor>::__single_object std::make_unique<melee_actor, melee_actor const&>(melee_actor const&) /usr/include/c++/13/bits/unique_ptr.h:1070 #3 0x5a87e4c in melee_actor::clone() const src/mattack_actors.cpp:962 #4 0x207632c in cata::clone_ptr<mattack_actor>::clone_ptr(cata::clone_ptr<mattack_actor> const&) src/clone_ptr.h:18 CleverRaven#5 0x6085941 in mtype_special_attack::mtype_special_attack(mtype_special_attack const&) src/mattack_common.h:47 CleverRaven#6 0x6085941 in std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack>::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack, true>(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, mtype_special_attack const&) /usr/include/c++/13/bits/stl_pair.h:559 CleverRaven#7 0x6085a2b in void std::__new_allocator<std::_Rb_tree_node<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack> > >::construct<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack>, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, mtype_special_attack const&>(std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack>*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, mtype_special_attack const&) /usr/include/c++/13/bits/new_allocator.h:187 CleverRaven#8 0x6085a2b in void std::allocator_traits<std::allocator<std::_Rb_tree_node<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack> > > >::construct<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack>, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, mtype_special_attack const&>(std::allocator<std::_Rb_tree_node<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack> > >&, std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack>*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, mtype_special_attack const&) /usr/include/c++/13/bits/alloc_traits.h:537 CleverRaven#9 0x6085a2b in void std::_Rb_tree<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack>, std::_Select1st<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack> >, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack> > >::_M_construct_node<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, mtype_special_attack const&>(std::_Rb_tree_node<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack> >*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, mtype_special_attack const&) /usr/include/c++/13/bits/stl_tree.h:597 CleverRaven#10 0x6085b06 in std::_Rb_tree_node<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack> >* std::_Rb_tree<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack>, std::_Select1st<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack> >, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack> > >::_M_create_node<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, mtype_special_attack const&>(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, mtype_special_attack const&) /usr/include/c++/13/bits/stl_tree.h:614 CleverRaven#11 0x6085b71 in std::_Rb_tree<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack>, std::_Select1st<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack> >, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack> > >::_Auto_node::_Auto_node<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, mtype_special_attack const&>(std::_Rb_tree<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack>, std::_Select1st<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack> >, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack> > >&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, mtype_special_attack const&) /usr/include/c++/13/bits/stl_tree.h:1637 CleverRaven#12 0x6085c9d in std::_Rb_tree_iterator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack> > std::_Rb_tree<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack>, std::_Select1st<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack> >, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack> > >::_M_emplace_hint_unique<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, mtype_special_attack const&>(std::_Rb_tree_const_iterator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, mtype_special_attack const&) /usr/include/c++/13/bits/stl_tree.h:2462 CleverRaven#13 0x608618f in std::_Rb_tree_iterator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack> > std::map<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, mtype_special_attack, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack> > >::emplace_hint<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, mtype_special_attack const&>(std::_Rb_tree_const_iterator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, mtype_special_attack const&) /usr/include/c++/13/bits/stl_map.h:640 CleverRaven#14 0x608618f in std::pair<std::_Rb_tree_iterator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack> >, bool> std::map<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, mtype_special_attack, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack> > >::emplace<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, mtype_special_attack const&>(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, mtype_special_attack const&) /usr/include/c++/13/bits/stl_map.h:601 CleverRaven#15 0x5ff3881 in MonsterGenerator::add_attack(mtype_special_attack const&) src/monstergenerator.cpp:1312 CleverRaven#16 0x5ffafa5 in MonsterGenerator::load_monster_attack(JsonObject const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) src/monstergenerator.cpp:1376 CleverRaven#17 0x4262e91 in operator() src/init.cpp:466 CleverRaven#18 0x4262e91 in __invoke_impl<void, DynamicDataLoader::initialize()::<lambda(const JsonObject&, const std::string&)>&, const JsonObject&, const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&> /usr/include/c++/13/bits/invoke.h:61 CleverRaven#19 0x4262e91 in __invoke_r<void, DynamicDataLoader::initialize()::<lambda(const JsonObject&, const std::string&)>&, const JsonObject&, const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&> /usr/include/c++/13/bits/invoke.h:111 CleverRaven#20 0x4262e91 in _M_invoke /usr/include/c++/13/bits/std_function.h:290 CleverRaven#21 0x4290ce9 in std::function<void (JsonObject const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)>::operator()(JsonObject const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) const /usr/include/c++/13/bits/std_function.h:591 CleverRaven#22 0x42693bf in operator() src/init.cpp:227 CleverRaven#23 0x42693bf in __invoke_impl<void, DynamicDataLoader::add(const std::string&, const std::function<void(const JsonObject&, const std::__cxx11::basic_string<char>&)>&)::<lambda(const JsonObject&, const std::string&, const cata_path&, const cata_path&)>&, const JsonObject&, const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&, const cata_path&, const cata_path&> /usr/include/c++/13/bits/invoke.h:61 CleverRaven#24 0x42693bf in __invoke_r<void, DynamicDataLoader::add(const std::string&, const std::function<void(const JsonObject&, const std::__cxx11::basic_string<char>&)>&)::<lambda(const JsonObject&, const std::string&, const cata_path&, const cata_path&)>&, const JsonObject&, const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&, const cata_path&, const cata_path&> /usr/include/c++/13/bits/invoke.h:111 CleverRaven#25 0x42693bf in _M_invoke /usr/include/c++/13/bits/std_function.h:290 CleverRaven#26 0x4290563 in std::function<void (JsonObject const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, cata_path const&, cata_path const&)>::operator()(JsonObject const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, cata_path const&, cata_path const&) const /usr/include/c++/13/bits/std_function.h:591 CleverRaven#27 0x42849b9 in DynamicDataLoader::load_object(JsonObject const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, cata_path const&, cata_path const&) src/init.cpp:137 CleverRaven#28 0x4285ca2 in DynamicDataLoader::load_all_from_json(JsonValue const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, loading_ui&, cata_path const&, cata_path const&) src/init.cpp:540 CleverRaven#29 0x42867b4 in DynamicDataLoader::load_data_from_path(cata_path const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, loading_ui&) src/init.cpp:521 CleverRaven#30 0x3ca266a in game::load_data_from_dir(cata_path const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, loading_ui&) src/game.cpp:571 CleverRaven#31 0x3d211a0 in game::load_packs(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::vector<string_id<MOD_INFORMATION>, std::allocator<string_id<MOD_INFORMATION> > > const&, loading_ui&) src/game.cpp:3265 CleverRaven#32 0x3d51925 in game::load_world_modfiles(loading_ui&) src/game.cpp:3235 CleverRaven#33 0x3e05640 in game::setup() src/game.cpp:756 CleverRaven#34 0x5111d33 in main_menu::new_character_tab() src/main_menu.cpp:972 CleverRaven#35 0x5127b5a in main_menu::opening_screen() src/main_menu.cpp:863 CleverRaven#36 0x50f1ece in main src/main.cpp:792 CleverRaven#37 0x7fdc43fa9b89 in __libc_start_call_main (/lib64/libc.so.6+0x27b89) (BuildId: f888be5f5e7d58e04cabb8c675c7ab94e77dd68c) CleverRaven#38 0x7fdc43fa9c4a in __libc_start_main_alias_2 (/lib64/libc.so.6+0x27c4a) (BuildId: f888be5f5e7d58e04cabb8c675c7ab94e77dd68c) CleverRaven#39 0x1bec874 in _start (/home/cdda/git/Cataclysm-DDA/cataclysm-tiles+0x1bec874) (BuildId: be24990d1723c8da00f3e8701793ab983cf64dcc) ```

If melee_actori.is_grab is false grab.exclusive_grab and grab.respect_seatbelts were not initialized. This was causing errors under -fsanitize=undefined The solution initialize the booleans to value that match their defaults ```C++ src/mattack_actors.h:75:8: runtime error: load of value 190, which is not a valid value for type 'bool' #0 0x5a9b6fe in grab::grab(grab const&) src/mattack_actors.h:75 #1 0x5ab7635 in melee_actor::melee_actor(melee_actor const&) src/mattack_actors.h:106 #2 0x5ab8412 in std::__detail::_MakeUniq<melee_actor>::__single_object std::make_unique<melee_actor, melee_actor const&>(melee_actor const&) /usr/include/c++/13/bits/unique_ptr.h:1070 #3 0x5a87e4c in melee_actor::clone() const src/mattack_actors.cpp:962 #4 0x207632c in cata::clone_ptr<mattack_actor>::clone_ptr(cata::clone_ptr<mattack_actor> const&) src/clone_ptr.h:18 #5 0x6085941 in mtype_special_attack::mtype_special_attack(mtype_special_attack const&) src/mattack_common.h:47 #6 0x6085941 in std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack>::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack, true>(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, mtype_special_attack const&) /usr/include/c++/13/bits/stl_pair.h:559 #7 0x6085a2b in void std::__new_allocator<std::_Rb_tree_node<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack> > >::construct<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack>, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, mtype_special_attack const&>(std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack>*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, mtype_special_attack const&) /usr/include/c++/13/bits/new_allocator.h:187 #8 0x6085a2b in void std::allocator_traits<std::allocator<std::_Rb_tree_node<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack> > > >::construct<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack>, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, mtype_special_attack const&>(std::allocator<std::_Rb_tree_node<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack> > >&, std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack>*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, mtype_special_attack const&) /usr/include/c++/13/bits/alloc_traits.h:537 #9 0x6085a2b in void std::_Rb_tree<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack>, std::_Select1st<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack> >, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack> > >::_M_construct_node<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, mtype_special_attack const&>(std::_Rb_tree_node<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack> >*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, mtype_special_attack const&) /usr/include/c++/13/bits/stl_tree.h:597 #10 0x6085b06 in std::_Rb_tree_node<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack> >* std::_Rb_tree<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack>, std::_Select1st<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack> >, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack> > >::_M_create_node<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, mtype_special_attack const&>(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, mtype_special_attack const&) /usr/include/c++/13/bits/stl_tree.h:614 #11 0x6085b71 in std::_Rb_tree<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack>, std::_Select1st<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack> >, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack> > >::_Auto_node::_Auto_node<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, mtype_special_attack const&>(std::_Rb_tree<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack>, std::_Select1st<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack> >, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack> > >&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, mtype_special_attack const&) /usr/include/c++/13/bits/stl_tree.h:1637 #12 0x6085c9d in std::_Rb_tree_iterator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack> > std::_Rb_tree<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack>, std::_Select1st<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack> >, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack> > >::_M_emplace_hint_unique<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, mtype_special_attack const&>(std::_Rb_tree_const_iterator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, mtype_special_attack const&) /usr/include/c++/13/bits/stl_tree.h:2462 #13 0x608618f in std::_Rb_tree_iterator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack> > std::map<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, mtype_special_attack, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack> > >::emplace_hint<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, mtype_special_attack const&>(std::_Rb_tree_const_iterator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, mtype_special_attack const&) /usr/include/c++/13/bits/stl_map.h:640 #14 0x608618f in std::pair<std::_Rb_tree_iterator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack> >, bool> std::map<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, mtype_special_attack, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, mtype_special_attack> > >::emplace<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, mtype_special_attack const&>(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, mtype_special_attack const&) /usr/include/c++/13/bits/stl_map.h:601 #15 0x5ff3881 in MonsterGenerator::add_attack(mtype_special_attack const&) src/monstergenerator.cpp:1312 #16 0x5ffafa5 in MonsterGenerator::load_monster_attack(JsonObject const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) src/monstergenerator.cpp:1376 #17 0x4262e91 in operator() src/init.cpp:466 #18 0x4262e91 in __invoke_impl<void, DynamicDataLoader::initialize()::<lambda(const JsonObject&, const std::string&)>&, const JsonObject&, const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&> /usr/include/c++/13/bits/invoke.h:61 #19 0x4262e91 in __invoke_r<void, DynamicDataLoader::initialize()::<lambda(const JsonObject&, const std::string&)>&, const JsonObject&, const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&> /usr/include/c++/13/bits/invoke.h:111 #20 0x4262e91 in _M_invoke /usr/include/c++/13/bits/std_function.h:290 #21 0x4290ce9 in std::function<void (JsonObject const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)>::operator()(JsonObject const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) const /usr/include/c++/13/bits/std_function.h:591 #22 0x42693bf in operator() src/init.cpp:227 #23 0x42693bf in __invoke_impl<void, DynamicDataLoader::add(const std::string&, const std::function<void(const JsonObject&, const std::__cxx11::basic_string<char>&)>&)::<lambda(const JsonObject&, const std::string&, const cata_path&, const cata_path&)>&, const JsonObject&, const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&, const cata_path&, const cata_path&> /usr/include/c++/13/bits/invoke.h:61 #24 0x42693bf in __invoke_r<void, DynamicDataLoader::add(const std::string&, const std::function<void(const JsonObject&, const std::__cxx11::basic_string<char>&)>&)::<lambda(const JsonObject&, const std::string&, const cata_path&, const cata_path&)>&, const JsonObject&, const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&, const cata_path&, const cata_path&> /usr/include/c++/13/bits/invoke.h:111 #25 0x42693bf in _M_invoke /usr/include/c++/13/bits/std_function.h:290 #26 0x4290563 in std::function<void (JsonObject const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, cata_path const&, cata_path const&)>::operator()(JsonObject const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, cata_path const&, cata_path const&) const /usr/include/c++/13/bits/std_function.h:591 #27 0x42849b9 in DynamicDataLoader::load_object(JsonObject const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, cata_path const&, cata_path const&) src/init.cpp:137 #28 0x4285ca2 in DynamicDataLoader::load_all_from_json(JsonValue const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, loading_ui&, cata_path const&, cata_path const&) src/init.cpp:540 #29 0x42867b4 in DynamicDataLoader::load_data_from_path(cata_path const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, loading_ui&) src/init.cpp:521 #30 0x3ca266a in game::load_data_from_dir(cata_path const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, loading_ui&) src/game.cpp:571 #31 0x3d211a0 in game::load_packs(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::vector<string_id<MOD_INFORMATION>, std::allocator<string_id<MOD_INFORMATION> > > const&, loading_ui&) src/game.cpp:3265 #32 0x3d51925 in game::load_world_modfiles(loading_ui&) src/game.cpp:3235 #33 0x3e05640 in game::setup() src/game.cpp:756 #34 0x5111d33 in main_menu::new_character_tab() src/main_menu.cpp:972 #35 0x5127b5a in main_menu::opening_screen() src/main_menu.cpp:863 #36 0x50f1ece in main src/main.cpp:792 #37 0x7fdc43fa9b89 in __libc_start_call_main (/lib64/libc.so.6+0x27b89) (BuildId: f888be5f5e7d58e04cabb8c675c7ab94e77dd68c) #38 0x7fdc43fa9c4a in __libc_start_main_alias_2 (/lib64/libc.so.6+0x27c4a) (BuildId: f888be5f5e7d58e04cabb8c675c7ab94e77dd68c) #39 0x1bec874 in _start (/home/cdda/git/Cataclysm-DDA/cataclysm-tiles+0x1bec874) (BuildId: be24990d1723c8da00f3e8701793ab983cf64dcc) ``` Co-authored-by: hexagon-recursion <[email protected]>

# This is the 1st commit message: ios build # This is the commit message #2: Add legacy handling and overmapbuffer::is_in_city # This is the commit message #3: Correct doc example # This is the commit message #4: Correct distance calc Not sure why I were checking 2 thick circles? # This is the commit message #5: Appease our clang overlords # This is the commit message #6: It helps if you add save/load handling # This is the commit message CleverRaven#7: Remove unnecessary project Co-authored-by: ehughsbaird <[email protected]> # This is the commit message CleverRaven#8: Fix minor typos in keybdings.json # This is the commit message CleverRaven#9: Update data/raw/keybindings.json # This is the commit message CleverRaven#10: Added imgui_freetype.cpp to vcxproj to fix broken build. # This is the commit message CleverRaven#11: Fixing compile error related to map::get_field usage # This is the commit message CleverRaven#12: Adding a welding store (CleverRaven#77279) * First draft * Add the store * Make it spawn * Final touches # This is the commit message CleverRaven#13: fix NPCs stealing player default name # This is the commit message CleverRaven#14: Update materials.json # This is the commit message CleverRaven#15: Update dreamer_procgen.json (CleverRaven#77179) # This is the commit message CleverRaven#16: Fix the Dream magick hobbies (CleverRaven#76912) # This is the commit message CleverRaven#17: cody shows her math skills (CleverRaven#77303) # This is the commit message CleverRaven#18: Set `last_item` after the end of picking up Also remoced mention of zombie spawning in `"LESSON_GOT_WEAPON` snippet. # This is the commit message CleverRaven#19: Normalize body stats on start of the tutorial # This is the commit message CleverRaven#20: fix zoo scenario spawn (CleverRaven#77237) * zoo ZONE_START_POINT * Update start_locations.json * Update scenarios.json * fix DinoMod * fix Xedra * Fix Limb WIP mod * Fix deadly bites mod * Update scenarios.json # This is the commit message CleverRaven#21: Unify all run_eocs in a single eoc function (CleverRaven#77000) * Unify all run_eocs in a single eoc function * add test suite * fix typo * handle condition better * Simplify code, move few big stuff into it's own functions * fix incorrect return * fix mistakes that prevent eoc from firing * rename iteration to iterations * reflect changes in documentation * change iteration to iterations in json * please clang # This is the commit message CleverRaven#22: fix recent regression of CleverRaven#77191 Fixes CleverRaven#77191 # This is the commit message CleverRaven#23: remove migo_bio_tech from spawns (CleverRaven#76940) # This is the commit message CleverRaven#24: Introduced untyped coordinate operations to typed ones (CleverRaven#77098) * Introduced untyped coordinate operations to typed ones * Missed rotate usages * demanded changes # This is the commit message CleverRaven#25: fix 5 round magazine having 20 rounds # This is the commit message CleverRaven#26: Fix edges # This is the commit message CleverRaven#27: Allow debug revealing any OM # This is the commit message CleverRaven#28: Swap the order of the bind labels to a guess at most used -> least used # This is the commit message CleverRaven#29: Add ability to place terrain/special without exiting placement # This is the commit message CleverRaven#30: Revert "Swap the order of the bind labels to a guess at most used -> least used" This reverts commit 05cf094. # This is the commit message CleverRaven#31: Revert "Allow debug revealing any OM" This reverts commit 5d1fc0a. # This is the commit message CleverRaven#32: "all" option for distraction manager (CleverRaven#77342) * distraction manager option for toggling all * Update src/distraction_manager.cpp Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> # This is the commit message CleverRaven#33: Beaver audit (CleverRaven#77283) * beavere big * baby creature * feaver * dambreaker * reproduction * butchery * monstergroups * factions * Update mammal.json * Update monster_factions.json * Update monster_factions.json # This is the commit message CleverRaven#34: Update electronic_parts.json # This is the commit message CleverRaven#35: Add a new widget to display weight with the format "##.#/##.#[unit]" (CleverRaven#77212) * Add two new widgets to display weight with the format "##.#/##.# kg" and "##.#/##.# lb", and add the widgets to the legacy labels sidebar * Apply suggestions from code review I don't format goodly Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Remove imperial version of the feature, and modify the metric version to read users mass setting and adjust the display accordingly * Apply suggestions from code review Formatting Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Updated per IdleSol suggestion * I think I forgot to pull before pushing and I don't understand git so I think it ate this space in the merge :( * I'll get it right one day * Update to use functions I didn't know existed, removing a few lines of code. * Update src/display.cpp Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> # This is the commit message CleverRaven#36: Add Vitamin C Supplements (CleverRaven#77363) * Add VitC Supplement * Create Drug Spawn Groups * Add VitC to softdrugs itemgroup * Full vitC bottle Added to Doctor shopkeep * Add VitC to vitamin_shop itemgroup * Add VitC to SUS bathroom vitamins * I really fucked up that last copy paste, fixed? # This is the commit message CleverRaven#37: Fixed broken Android build due to missing FreeType library # This is the commit message CleverRaven#38: wrap long text in the menu for choosing the type of faction camp to create # This is the commit message CleverRaven#39: [ Aftershock ] Make Flesh Golem heart a mission item # This is the commit message CleverRaven#40: Routine i18n updates on 26 October 2024 # This is the commit message CleverRaven#41: Fix cotton patch being unusable to stop bleeding # This is the commit message CleverRaven#42: First Draft Update en.credits # This is the commit message CleverRaven#43: Update data/credits/en.credits # This is the commit message CleverRaven#44: Update data/credits/en.credits Co-authored-by: David Seguin <[email protected]> # This is the commit message CleverRaven#45: Update data/credits/en.credits # This is the commit message CleverRaven#46: Update data/credits/en.credits Co-authored-by: Binrui Dong <[email protected]> # This is the commit message CleverRaven#47: Apply suggestions from code review Co-authored-by: RenechCDDA <[email protected]> # This is the commit message CleverRaven#48: Update en.credits Overhauled the Main Developers section. Reordered special thanks alphabetically. # This is the commit message CleverRaven#49: Add links to tileset contributor lists. # This is the commit message CleverRaven#50: Removed heating elements drop from smashing the fume hood # This is the commit message CleverRaven#51: Add freetype, clean up 3rd-party CMake file # This is the commit message CleverRaven#52: [MoM/Magiclysm interaction] Synchronize anti-Stare powers, Thought Shield spell protects from telepathy (CleverRaven#77277) * Create miscellaneous.json * Create flags.json * Acount for TEEPSHIELD * Create eoc_misc.json * Add MAGICAL_MIND_PROTECTION to thought shield * Add mind protection to thought shields * TEEPSHIELD effect * Update data/mods/MindOverMatter/mod_interactions/magiclysm/item_overrides.json Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Fixes --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> # This is the commit message CleverRaven#53: Decrement spawn quantity when no monster is selected in sub group # This is the commit message CleverRaven#54: Set mon_found properly when select monster from subgroup # This is the commit message CleverRaven#55: Update src/mongroup.cpp Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> # This is the commit message CleverRaven#56: Update ballistic_armor.json # This is the commit message CleverRaven#57: Factions don't mind the player smashing zombie corpses # This is the commit message CleverRaven#58: [Xedra Evolve] Add Ruach counter to sidebars (CleverRaven#77422) * Update sidebar.json * Create ruach_counter.json * Initial commit * Add to sidebars # This is the commit message CleverRaven#59: Forbid drinking liquids underwater for characters with `WATERSLEEP` and `UNDINE_SLEEP_WATER` mutations # This is the commit message CleverRaven#60: Characters with `UNDINE_SLEEP_WATER` mutation sleep less in water # This is the commit message CleverRaven#61: Fix recent clang-tidy errors. # This is the commit message CleverRaven#62: Set owner for new appliances (CleverRaven#77211) # This is the commit message CleverRaven#63: Lever action rifles (CleverRaven#77409) * Add Rio Bravo * Henry Golden Boy * Add .44 R92 * Adds Uberti 1873 * Added sources * 357 R92 * Minor fixes * fix in ammo count for nested r92 * Spelling fixes * Apply suggestions from code review Co-authored-by: TheShadowFerret <[email protected]> * Apply suggestions from code review Co-authored-by: Anton Burmistrov <[email protected]> --------- Co-authored-by: TheShadowFerret <[email protected]> Co-authored-by: Anton Burmistrov <[email protected]> # This is the commit message CleverRaven#64: Add myself # This is the commit message CleverRaven#65: Initial commit (CleverRaven#77414) # This is the commit message CleverRaven#66: Minor gun fixes # This is the commit message CleverRaven#67: Update spells.json # This is the commit message CleverRaven#68: Feral Agent fix and loot update (CleverRaven#77421) * Feral Agent fix and loot update Co-Authored-By: gettingusedto <[email protected]> * Update data/mods/Xedra_Evolved/itemgroups/monster_drops.json Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: gettingusedto <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> # This is the commit message CleverRaven#69: Apply copy-from to mod scenarios (CleverRaven#77417) * Apply copy-from to mod scensarios * apply to Limb_WIP * Mind Over Matter * Xedra * Update scenarios.json * document # This is the commit message CleverRaven#70: Mutations can have a custom activation message # This is the commit message CleverRaven#71: Changed implementation of battery chargers to make them work outside the reality bubble. # This is the commit message CleverRaven#72: Added last_charged to serialize and deserialize # This is the commit message CleverRaven#73: Prevent overflow # This is the commit message CleverRaven#74: Moved dischargeable check earlier to catch situations when dischargeable is 0 from the beginning # This is the commit message CleverRaven#75: [MoM] Move Mirror-mask bonus to effect, obsolete mutations (CleverRaven#72370) * Obsolete old mutations * Obsolete switcher EoC * Move switcher EoC * Move effect to enchantment * Remove rather than obsolete mutations * lint * Fixes + documentation * Linting # This is the commit message CleverRaven#76: Reworked check for flammability # This is the commit message CleverRaven#77: Changed text to mention a non-lit cig # This is the commit message CleverRaven#78: Refactoring armor ordering # This is the commit message CleverRaven#79: migo sideplates # This is the commit message CleverRaven#80: [Xedra Evolved] Require Traverse the Wilds to target a tree as the endpoint (CleverRaven#72655) * Require teleporting to a tree * Edit description * Update data/mods/Xedra_Evolved/mutations/paraclesians/arvore_eocs.json Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update EoC for map_run_eocs * Update spell --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> # This is the commit message CleverRaven#81: [Xedra Evolved] More Lilin powers (CleverRaven#77269) * Initial commit * Add more powers * Fix n_vitamin * Add the Evil Eye * Duration edits, increase ruach cost of Reap the Whirlwind * Fix math * Cry of the Night Bird reduces speed by percentage, not flat number * Those who have the evil eye are immune to the evil eye * Add Owl's Wisdom * Update xe_lilin.json * Add The Pestilence that Stalks in Darkness * Add Stand Before the Cold * Add more abilities * Various updates * Increase cost of Neither Sleep nor Slumber * Add strix to dictionary * Fix typos * Fix ruach cost # This is the commit message CleverRaven#82: modify random NPC starting equipment based on time passed -some very basic item groups for now, needs to be expanded on later -add_profession_items(): replace raw inv with i_add() -very minor edits to some professions # This is the commit message CleverRaven#83: [DinoMod] mountable and harnessable audit (CleverRaven#77391) * [DinoMod] riding and harness audit * juvenile fixes * rem harnessable * Remove harnessable * juvenile fixes * flag spellcheck # This is the commit message CleverRaven#84: Use corner symbols for vehicle Corner variations # This is the commit message CleverRaven#85: Removing and/or using some unused itemgroup IDs (CleverRaven#77356) * ``accessory_ring`` * unused * Update drugs.json * I told you to remove them * cinnamon groups * yeast * seasoning salt * flour bags * Update druid_tower.json # This is the commit message CleverRaven#86: Use parametrized carpets where appropriate (CleverRaven#77287) * Add the carpet palette * Nested basements * Make the carpet not fallback * Fix oopsie * Fix oopsie * Switch palette name to be clearer * Carpets in nests * First few buildings * Most of the maps * bungalow08 * Use correct palette name * Last few touch-ups * Remove old palette * Use correct palette name # This is the commit message CleverRaven#87: Update urban_20_house.json # This is the commit message CleverRaven#88: Initial commit # This is the commit message CleverRaven#89: add terminal punctuation to bulletin board examination message # This is the commit message CleverRaven#90: Allowed throwing items while piloting mechs # This is the commit message CleverRaven#91: Fix CleverRaven#77179 and a Book in Magiclysm (CleverRaven#77408) * Update dreamer_procgen.json * Update recipe_books.json * Update data/mods/Xedra_Evolved/procgen/dreamer_procgen.json Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> # This is the commit message CleverRaven#92: eoc: clear deferred math on error # This is the commit message CleverRaven#93: fix scenario spawns (CleverRaven#77451) * fix scenario spawns * road mayhem start * wild party * update sloc hospital entry * revert road sloc terrain * simplify road terrain * Try TYPE for crash sloc # This is the commit message CleverRaven#94: Add recommended palettes # This is the commit message CleverRaven#95: Stop 20x Melatonin Spawns (CleverRaven#77347) * Fix Up Melatonin * Woops, too much deleted # This is the commit message CleverRaven#96: Refugee center cleanups (CleverRaven#77331) * dino dave * door position * lobby cleanup # This is the commit message CleverRaven#97: Remove Calcium from Rare Drugs (CleverRaven#77349) # This is the commit message CleverRaven#98: eoc: clean up run_eocs # This is the commit message CleverRaven#99: eoc/run_eocs: don't allow queue+loop in one invocation # This is the commit message CleverRaven#100: eoc/run_eocs: add test for talker mixes # This is the commit message CleverRaven#101: Allow any grade of steel ofr the metal axe head # This is the commit message CleverRaven#102: Switch relationship to enum class # This is the commit message CleverRaven#103: Faction relationships can be modiifed through dialogue # This is the commit message CleverRaven#104: Asking for a bed gives you permission to sleep there # This is the commit message CleverRaven#105: Update lumbermill map+dialogue -Outer fence is no longer permalocked with no way in -You can ask for a gate to be opened. # This is the commit message CleverRaven#106: Appease clang, the one true overlord # This is the commit message CleverRaven#107: Fix food calcs for items with non-food components # This is the commit message CleverRaven#108: Flush debug log writes immediately # This is the commit message CleverRaven#109: fix two supressors in m4_cqbr # This is the commit message CleverRaven#110: magus.json description change This is my first contribution/change. I apologize if it isn't formatted or done correctly. I noticed that magus_slow had the same description as magus_haste. Slow should indicate that it slows the target's speed. # This is the commit message CleverRaven#111: less loopy conversation loops # This is the commit message CleverRaven#112: found another # This is the commit message CleverRaven#113: math: improve diag_value constructors # This is the commit message CleverRaven#114: math: add monostate to diag_value # This is the commit message CleverRaven#115: math: add kwarg_or helper function # This is the commit message CleverRaven#116: Repeat survey missions without leaving interface # This is the commit message CleverRaven#117: Made game recognize burst fire mode as well as full auto when pressing 'Burst fire wielded weapon' # This is the commit message CleverRaven#118: simple knife spear quest options (CleverRaven#77335) * options and random word choice * just spears then # This is the commit message CleverRaven#119: Rejecting some area threats near safe locations # This is the commit message CleverRaven#120: Globally unique -> prio 1 and SAFE_AT_WORLDGEN # This is the commit message CleverRaven#121: Use global coordinates in global calls... # This is the commit message CleverRaven#122: Removed remaining development variable # This is the commit message CleverRaven#123: fix: -Werror=range-loop-construct (CleverRaven#77302) # This is the commit message CleverRaven#124: some mistake fixing # This is the commit message CleverRaven#125: :pray: # This is the commit message CleverRaven#126: idk # This is the commit message CleverRaven#127: heh # This is the commit message CleverRaven#128: cmon do something # This is the commit message CleverRaven#129: astyle # This is the commit message CleverRaven#130: try to deal with undefined type # This is the commit message CleverRaven#131: i'm desperate # This is the commit message CleverRaven#132: resorting # This is the commit message CleverRaven#133: idk what's happening # This is the commit message CleverRaven#134: dunno # This is the commit message CleverRaven#135: stupid resorting # This is the commit message CleverRaven#136: Update input_context.h # This is the commit message CleverRaven#137: attempt to workaround 'inaccessible member'

Tracking whether MAPBUFFER actually needs saving

46e390c

with a 'dirty bit'. I imagine that overmaps and nonants could use the same principle to be loaded on demand andn saved as needed.

TheDarklingWolf added a commit that referenced this pull request Feb 2, 2013

Merge pull request #32 from zpmorgan/dirty-mapbuffer

45878a6

Tracking whether MAPBUFFER actually needs saving

TheDarklingWolf merged commit 45878a6 into CleverRaven:master Feb 2, 2013

kevingranade mentioned this pull request May 2, 2013

l18n, god help us #778

Closed

kevingranade mentioned this pull request Mar 26, 2017

Segfault while attempting to reload a Minigun #20682

Closed

Coolthulhu referenced this pull request in Coolthulhu/Cataclysm Mar 5, 2019

Merge pull request cataclysmbnteam#32 from TGITS-Solutions/dev

252f9b8

Merge from dev to master

kevingranade added a commit that referenced this pull request Apr 30, 2019

Merge pull request #30102 from ifreund/lint-json-32

2290165

Lint json #32

Rivet-the-Zombie pushed a commit that referenced this pull request Dec 29, 2019

Merge pull request #32 from CleverRaven/master

0f47d2b

SUS Prep Dec. 17

bcronrath mentioned this pull request Apr 9, 2020

Crafting concentrated acid from light battery causes crash #39392

Closed

Damdern mentioned this pull request Apr 13, 2020

Crash when turning in 2nd quest for Hub #39507

Closed

ZhilkinSerg mentioned this pull request Mar 13, 2021

Retrieve system language on Android #47977

Merged

John-Candlebury pushed a commit to John-Candlebury/Cataclysm-DDA that referenced this pull request Aug 25, 2021

Merge pull request CleverRaven#32 from CleverRaven/master

362fa04

make it up to date

anoobindisguise mentioned this pull request Sep 1, 2021

Segfault crash when attempting to aim gun at Melded Task Force #51291

Closed

Setmaster mentioned this pull request Mar 22, 2023

game crashed after closing the achievement pop-up message #64466

Closed

GuardianDll mentioned this pull request Mar 31, 2023

[Magiclysm] Shocking Lash Max level = 0 #64738

Closed

RenechCDDA mentioned this pull request Jul 1, 2023

Game crashes generating faction camp recipes when any of the components has_temperature() #50493

Closed

PGR-14 mentioned this pull request Feb 21, 2024

Help w/ a crash #71905

Closed

CaseMonster mentioned this pull request Mar 30, 2024

Changing evac_center from "GLOBALLY_UNIQUE" tag to "UNIQUE" crashes during evec mission generation. #72727

Closed

osuphobia mentioned this pull request Sep 1, 2024

Segfault when opening uilist menus #76110

Closed

jeffplata mentioned this pull request Sep 3, 2024

Error/Crash when using bandages #76166

Closed

ghost mentioned this pull request Sep 3, 2024

Mafia Boss Desert Eagle is bugged #76178

Open

PGR-14 mentioned this pull request Sep 18, 2024

Teleportation segfault w/ MOM #76523

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tracking whether MAPBUFFER actually needs saving #32

Tracking whether MAPBUFFER actually needs saving #32

zpmorgan commented Feb 2, 2013

Tracking whether MAPBUFFER actually needs saving #32

Tracking whether MAPBUFFER actually needs saving #32

Conversation

zpmorgan commented Feb 2, 2013