Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove achievements/scores/killcount top-level keybinding and move it into the diary menu (bound by default to ')') #64470

Conversation

strategineer
Copy link
Contributor

Summary

None

Purpose of change

See issues below for more details.

Fixes #59686
Fixes #59685

Describe the solution

  • Remove global "scores" keybind from code and replace it with a VIEW_SCORES keybind accessible only from the diary menu.
  • Re-use "scores" keybind's default use of ')' for the key to access the diary by default.
  • Implement VIEW_SCORES keybind and hint at its use from the diary menu.

Describe alternatives you've considered

None.

Testing

  • Checked changed keybinds and ensured that they appeared in the right places and worked as expected.

Additional context

diary menu:
WindowsTerminal_nMG8Yy5khk

diary keybindings:
WindowsTerminal_hcPQPGeEah

achievements/scores/killcount menu showing overlaid on top of diary menu:
WindowsTerminal_VMXz7lZDck

@github-actions github-actions bot added <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON Info / User Interface Game - player communication, menus, etc. json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Mar 22, 2023
… into the diary menu (bound by default to ')')
@strategineer strategineer force-pushed the move_kill_count_and_achievements_keybinds_to_diary branch from 2d0d3f6 to 18a2c5e Compare March 22, 2023 23:07
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 22, 2023
@bombasticSlacks
Copy link
Contributor

@I-am-Erk the code for this looks fine to me, but it's your issue, so figured you should take a look if this is what you wanted, or is at least a step in the right direction.

@kevingranade kevingranade merged commit 5b8087d into CleverRaven:master Mar 24, 2023
@kevingranade
Copy link
Member

This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there:

https://discourse.cataclysmdda.org/t/game-continually-crashes-when-creature-dies/28632/6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Achievements do not need to be a top level keybinding Remove top-level keybinding for kill count
3 participants