-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Required prop in multiselect component sets aria property #6438
Required prop in multiselect component sets aria property #6438
Conversation
…ired_prop_device_types Merged with latest main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
I am a little confused... I thought 6408 referred to the And 6404 referred to the Can you show a screenshot of the component that is still missing the aria-required and in which page 🤔 |
Ooooppps, I got confused with #6405 which what I thought #6408 was. This fixes #6404 and #6408 like you said! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…ired_prop_device_types Merged with latest main
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
FRONTEND PULL REQUEST
Related Issue
Resolves #6408
Changes Proposed
Add logic so the prop
required
of theMultiSelect
component is set as an aria-required prop.Additional Information
This fixes the issue for the device edit form as well.
Testing
Verify the aria-required props is set to true.