Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Required prop in multiselect component sets aria property #6438

Merged
merged 3 commits into from
Aug 29, 2023

Conversation

johanna-skylight
Copy link
Contributor

@johanna-skylight johanna-skylight commented Aug 28, 2023

FRONTEND PULL REQUEST

Related Issue

Resolves #6408

Changes Proposed

Add logic so the prop required of the MultiSelect component is set as an aria-required prop.

Additional Information

This fixes the issue for the device edit form as well.

Testing

Verify the aria-required props is set to true.

@johanna-skylight johanna-skylight changed the title Modified multiselect component so the required prop gets set as aria-… Required props in multiselect component sets aria property Aug 28, 2023
@johanna-skylight johanna-skylight changed the title Required props in multiselect component sets aria property Required prop in multiselect component sets aria property Aug 28, 2023
…ired_prop_device_types

Merged with latest main
@johanna-skylight johanna-skylight marked this pull request as ready for review August 28, 2023 20:22
@johanna-skylight johanna-skylight self-assigned this Aug 28, 2023
Copy link
Contributor

@BobanL BobanL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@BobanL
Copy link
Contributor

BobanL commented Aug 29, 2023

Actually, I think this only resolves #6404 and not #6408, only the SNOMED code multi selects have aria-requried. The device combo box does not have aria-required.

@johanna-skylight
Copy link
Contributor Author

Actually, I think this only resolves #6404 and not #6408, only the SNOMED code multi selects have aria-requried. The device combo box does not have aria-required.

I am a little confused... I thought 6408 referred to the multi-select device types (shown below)
Screenshot 2023-08-29 at 10 07 00 AM

And 6404 referred to the multi-select SNOMED (shown below)
Screenshot 2023-08-29 at 10 07 21 AM

Can you show a screenshot of the component that is still missing the aria-required and in which page 🤔

@BobanL
Copy link
Contributor

BobanL commented Aug 29, 2023

Actually, I think this only resolves #6404 and not #6408, only the SNOMED code multi selects have aria-requried. The device combo box does not have aria-required.

I am a little confused... I thought 6408 referred to the multi-select device types (shown below) Screenshot 2023-08-29 at 10 07 00 AM

And 6404 referred to the multi-select SNOMED (shown below) Screenshot 2023-08-29 at 10 07 21 AM

Can you show a screenshot of the component that is still missing the aria-required and in which page 🤔

Ooooppps, I got confused with #6405 which what I thought #6408 was. This fixes #6404 and #6408 like you said!

Copy link
Collaborator

@emyl3 emyl3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

…ired_prop_device_types

Merged with latest main
@sonarcloud
Copy link

sonarcloud bot commented Aug 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@johanna-skylight johanna-skylight added this pull request to the merge queue Aug 29, 2023
Merged via the queue into main with commit 868a423 Aug 29, 2023
@johanna-skylight johanna-skylight deleted the johanna/6408_add_required_prop_device_types branch August 29, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants