Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove multiplex feature flag from frontend #6603

Merged
merged 6 commits into from
Sep 22, 2023
Merged

remove multiplex feature flag from frontend #6603

merged 6 commits into from
Sep 22, 2023

Conversation

BobanL
Copy link
Contributor

@BobanL BobanL commented Sep 22, 2023 •
edited
Loading

FRONTEND PULL REQUEST

Related Issue

Changes Proposed

  • Remove all uses in of "multiplexEnabled" feature flag in the front end

Additional Information

  • Additional PRs will be open to make backend and DB changes.

Testing

Screenshots / Demos

@BobanL BobanL temporarily deployed to Dev5 September 22, 2023 14:06 — with GitHub Actions Inactive
@sonarcloud
Copy link

sonarcloud bot commented Sep 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

92.9% 92.9% Coverage
0.0% 0.0% Duplication

@BobanL BobanL marked this pull request as ready for review September 22, 2023 14:17
@BobanL BobanL enabled auto-merge September 22, 2023 14:17
@BobanL BobanL changed the title Boban/6438 remove multiplex feature flag remove multiplex feature flag from frontend Sep 22, 2023
johanna-skylight
johanna-skylight approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@johanna-skylight johanna-skylight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

fzhao99
fzhao99 approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@fzhao99 fzhao99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@BobanL BobanL added this pull request to the merge queue Sep 22, 2023
@BobanL BobanL removed this pull request from the merge queue due to a manual request Sep 22, 2023
@BobanL BobanL added this pull request to the merge queue Sep 22, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 22, 2023
@BobanL BobanL added this pull request to the merge queue Sep 22, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 22, 2023
@BobanL BobanL added this pull request to the merge queue Sep 22, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 22, 2023
@fzhao99 fzhao99 added this pull request to the merge queue Sep 22, 2023
Merged via the queue into main with commit ca91409 Sep 22, 2023
37 checks passed
@fzhao99 fzhao99 deleted the boban/6438-remove-multiplex-feature-flag branch September 22, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanna-skylight johanna-skylight johanna-skylight approved these changes

@fzhao99 fzhao99 fzhao99 approved these changes

@mehansen mehansen Awaiting requested review from mehansen

@emyl3 emyl3 Awaiting requested review from emyl3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BobanL @fzhao99 @johanna-skylight