Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Add new facility] Device types combo box is a required field but missing aria-required #6408

Closed
BobanL opened this issue Aug 24, 2023 · 0 comments · Fixed by #6438
Closed

[Add new facility] Device types combo box is a required field but missing aria-required #6408

BobanL opened this issue Aug 24, 2023 · 0 comments · Fixed by #6438
Assignees
@johanna-skylight
Labels
Accessibility Issues that affect SR's accessibility Growth & Engagement
Milestone
2023.3 Accessibil...

Comments

@BobanL
Copy link
Contributor

BobanL commented Aug 24, 2023

Area or Component

Settings > Manage Facility > Add new facility

Quick Summary

Device types combo box is required, but missing aria-required

How to Replicate

Accessibility Violation

https://docs.deque.com/issue-help/1.0.0/en/aria-required-missing

Action Requested

Add required=true to the inputProps in the combo box

Screenshots (optional)

Source Code (optional)

Original Deque Issue
@BobanL BobanL added Growth & Engagement Accessibility Issues that affect SR's accessibility labels Aug 24, 2023
@BobanL BobanL added this to the 2023.3 Accessibility Fixes milestone Aug 24, 2023
@BobanL BobanL mentioned this issue Aug 24, 2023
Closed
@johanna-skylight johanna-skylight self-assigned this Aug 28, 2023
@johanna-skylight johanna-skylight mentioned this issue Aug 28, 2023
Merged
@johanna-skylight johanna-skylight mentioned this issue Sep 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johanna-skylight johanna-skylight

Labels
Accessibility Issues that affect SR's accessibility Growth & Engagement
Projects
None yet
Milestone
2023.3 Accessibility Fixes
Development

Successfully merging a pull request may close this issue.

Required prop in multiselect component sets aria property CDCgov/prime-simplereport
3 participants
@mehansen @BobanL @johanna-skylight