Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Edit existing device] Select device combo box is a required field but missing aria-required #6405

Closed
BobanL opened this issue Aug 23, 2023 · 0 comments · Fixed by #6456
Closed

[Edit existing device] Select device combo box is a required field but missing aria-required #6405

BobanL opened this issue Aug 23, 2023 · 0 comments · Fixed by #6456
Assignees
@BobanL
Labels
Accessibility Issues that affect SR's accessibility Growth & Engagement
Milestone
2023.3 Accessibil...

Comments

@BobanL
Copy link
Contributor

BobanL commented Aug 23, 2023

Area or Component

Support Admin > Edit existing device > Select device combo box

Quick Summary

Select device combo box should have aria-required=true

How to Replicate

Accessibility Violation

https://docs.deque.com/issue-help/1.0.0/en/aria-required-missing

Action Requested

Add required=true to the inputProps in the combo box

Screenshots (optional)

Source Code (optional)

Original Deque Issue
@BobanL BobanL added the Accessibility Issues that affect SR's accessibility label Aug 23, 2023
@BobanL BobanL added this to the 2023.3 Accessibility Fixes milestone Aug 23, 2023
@BobanL BobanL mentioned this issue Aug 23, 2023
Closed
@BobanL BobanL changed the title [Edit existing device] Select device combo box is missing aria-required [Edit existing device] Select device combo box is a required field but missing aria-required Aug 24, 2023
@BobanL BobanL mentioned this issue Aug 24, 2023
Closed
@BobanL BobanL mentioned this issue Aug 29, 2023
Merged
@BobanL BobanL self-assigned this Aug 30, 2023
@BobanL BobanL mentioned this issue Aug 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BobanL BobanL

Labels
Accessibility Issues that affect SR's accessibility Growth & Engagement
Projects
None yet
Milestone
2023.3 Accessibility Fixes
Development

Successfully merging a pull request may close this issue.

add aria-required for device combo box CDCgov/prime-simplereport
2 participants
@mehansen @BobanL