Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add aria-required for device combo box #6456

Merged
merged 1 commit into from
Aug 30, 2023
Merged

add aria-required for device combo box #6456

merged 1 commit into from
Aug 30, 2023

Conversation

BobanL
Copy link
Contributor

@BobanL BobanL commented Aug 30, 2023

FRONTEND PULL REQUEST

Related Issue

  • Why is this being done? Link to issue, or a few sentences describing why this PR exists

Changes Proposed

Additional Information

Testing

  • Make sure that the ComboBox has aria-required = true

Screenshots / Demos

image

@sonarcloud
Copy link

sonarcloud bot commented Aug 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@BobanL BobanL marked this pull request as ready for review August 30, 2023 12:54
@BobanL BobanL enabled auto-merge August 30, 2023 12:54
johanna-skylight
johanna-skylight approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@johanna-skylight johanna-skylight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@BobanL BobanL added this pull request to the merge queue Aug 30, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 30, 2023
@BobanL BobanL added this pull request to the merge queue Aug 30, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 30, 2023
@BobanL BobanL added this pull request to the merge queue Aug 30, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 30, 2023
@BobanL BobanL added this pull request to the merge queue Aug 30, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 30, 2023
@BobanL BobanL added this pull request to the merge queue Aug 30, 2023
Merged via the queue into main with commit 5d331be Aug 30, 2023
@BobanL BobanL deleted the boban/6405-require-device-combobox branch August 30, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanna-skylight johanna-skylight johanna-skylight approved these changes

@fzhao99 fzhao99 fzhao99 approved these changes

@emyl3 emyl3 Awaiting requested review from emyl3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Edit existing device] Select device combo box is a required field but missing aria-required
3 participants
@BobanL @fzhao99 @johanna-skylight