-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/swagger parser upgrade #6338
Feature/swagger parser upgrade #6338
Conversation
9feb94d
to
0223a23
Compare
I'm afraid I don't have a lot of familiarity with this to really approve, though I'm happy to take a look conceptually. With some of the changes I see, though, I want to make sure: are properties of models still listed breadth-first - which I fixed in #5802 - instead of depth-first like they were? |
Based on request in #5582 I removed the nesting of models, instead I add each model to the definition where the properties are listed for each model. |
Is there a preview? |
d931b7b
to
35d1e03
Compare
@heaths description was updated to show the differences |
@mikekistler coudl you also take a look at this PR? |
I thought the plan for fixing the confusing flattening of models #5582 was to link to the model definition rather than expanding it in the request or response body section. But the the preview above there are no links: |
@chidozieononiwu Could you post a list of the improvements here -- a brief summary is fine, something like what we would post in the change log and advertise to the team. |
You are right. The actual linking will need to be a UI change yet to be made. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good.
35d1e03
to
7d5fdde
Compare
Flattening of nested models is really confusing in APIView for Swaggers #5582
Improvements to Swagger Parser #6008
Swagger Parser DataPlane Update #6188
Swagger APIView does not seem to follow external refs #6259
Problems with Swagger APIView #4978
Swagger APIView - new property in schema creates diff for all remaining properties #6296