Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to Swagger Parser #6008

Closed
Tracked by #4864
chidozieononiwu opened this issue Apr 19, 2023 · 0 comments
Closed
Tracked by #4864

Improvements to Swagger Parser #6008

chidozieononiwu opened this issue Apr 19, 2023 · 0 comments
Assignees
Labels
APIView Central-EngSys This issue is owned by the Engineering System team.

Comments

@chidozieononiwu
Copy link
Member

Swagger parser currently have many cases where it does not grab the data, mostly related to when schema is referenced from other swagger files relative to the root swagger file.
There are also cases where the relative refence is many layers down, i.e reference to a reference. A good test case to identify these situations is https://github.com/Azure/azure-rest-api-specs/blob/main/specification/maps/data-plane/DEM/preview/1.0/elevation.json

Another issue is that arrays are not properly modeled for APIView to render it. We should reconsider how to tokenize array and object within swagger schema.

SwaggerIssues

In the case above the properties of the objects should not be a different row.
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Apr 19, 2023
@kurtzeborn kurtzeborn added APIView Central-EngSys This issue is owned by the Engineering System team. and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Apr 24, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in ApiView Apr 24, 2023
@mikekistler mikekistler moved this from 🆕 New to 🏗 In progress in ApiView May 1, 2023
@chidozieononiwu chidozieononiwu moved this from 🤔 Triage to 🔬 Dev in PR in Azure SDK EngSys 🚢🎉 Jun 13, 2023
@github-project-automation github-project-automation bot moved this from 🔬 Dev in PR to 🎊 Closed in Azure SDK EngSys 🚢🎉 Jun 27, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in ApiView Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APIView Central-EngSys This issue is owned by the Engineering System team.
Projects
Status: ✅ Done
Archived in project
Development

No branches or pull requests

2 participants