Render response models breadth-first #5802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swagger response models were being rendered depth-first which made results very misleading, such that response models' properties were listed and seemingly nested after nested property model types, making those properties look like part of another model. Fixes Azure#5795
|
Thanks @heaths for this change. I will review and it and we can get this included in next APIView release. |
|
@chidozieononiwu just FYI. |
praveenkuttappan
approved these changes
Mar 27, 2023
|
@praveenkuttappan when might this go into production, and is it possible to regenerate all swagger views? Or will that potentially break comments? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swagger response models were being rendered depth-first which made results very misleading, such that response models' properties were listed and seemingly nested after nested property model types, making those properties look like part of another model.
Fixes #5795