Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swagger APIView - new property in schema creates diff for all remaining properties #6296

Closed
Tracked by #4864
mikekistler opened this issue Jun 6, 2023 · 2 comments
Closed
Tracked by #4864

Swagger APIView - new property in schema creates diff for all remaining properties #6296

mikekistler opened this issue Jun 6, 2023 · 2 comments
Assignees
@chidozieononiwu
Labels
APIView Central-EngSys This issue is owned by the Engineering System team. Swagger Issues for APIView support of Swagger

Comments

@mikekistler
Copy link
Member

In PR 24291, a new property id was added to the Pool schema, but all other properties are unchanged:

image

But in APIView, all the properties after id are highlighted as a diff from the base release.

image
@mikekistler mikekistler added APIView Swagger Issues for APIView support of Swagger labels Jun 6, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in ApiView Jun 6, 2023
@github-actions github-actions bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jun 6, 2023
@heaths
Copy link
Member

heaths commented Jun 7, 2023

I noticed this too and started a side conversation. Thank you for opening a bug. This makes it impractical to use the diffing view.

@heaths
Copy link
Member

heaths commented Jun 7, 2023

May be a dup of #6132. We should probably sort properties, but make sure to keep my breadth-first change in there. The old depth-first was very misleading.

@heaths heaths mentioned this issue Jun 7, 2023
Closed
@maririos maririos added Central-EngSys This issue is owned by the Engineering System team. and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Jun 9, 2023
@maririos maririos mentioned this issue Jun 9, 2023
Closed
@mikekistler mikekistler moved this from 🆕 New to 📋 Backlog in ApiView Jun 12, 2023
@chidozieononiwu chidozieononiwu self-assigned this Jun 14, 2023
@chidozieononiwu chidozieononiwu mentioned this issue Jun 15, 2023
Merged
@maririos maririos moved this from 📋 Backlog to 🏗 In progress in ApiView Jun 27, 2023
@maririos maririos moved this from 🤔 Triage to 🐝 Dev in Azure SDK EngSys 🚢🎉 Jun 27, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in ApiView Jun 27, 2023
@github-project-automation github-project-automation bot moved this from 🐝 Dev to 🎊 Closed in Azure SDK EngSys 🚢🎉 Jun 27, 2023
@heaths heaths mentioned this issue Jan 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chidozieononiwu chidozieononiwu

Labels
APIView Central-EngSys This issue is owned by the Engineering System team. Swagger Issues for APIView support of Swagger
Projects
ApiView
Status: ✅ Done
Azure SDK EngSys 🚢🎉
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@heaths @maririos @chidozieononiwu @mikekistler