Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EventHubs] ensure ownership arg does not mutate #20008

Merged
5 commits merged into from
Nov 29, 2021

Conversation

swathipil
Copy link
Member

@ghost ghost added the Event Hubs label Jul 30, 2021
@swathipil
Copy link
Member Author

/azp run python - eventhub - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@swathipil swathipil marked this pull request as ready for review November 23, 2021 01:02
@azure-sdk
Copy link
Collaborator

API changes have been detected in azure-eventhub-checkpointstoreblob-aio. You can review API changes here

API changes

-             api_version: str, 
+             api_version: str = ..., 
-             secondary_hostname: str, 
+             secondary_hostname: str = ..., 
-             api_version: str, 
+             api_version: str = ..., 
-             secondary_hostname: str, 
+             secondary_hostname: str = ..., 

@azure-sdk
Copy link
Collaborator

API changes have been detected in azure-eventhub-checkpointstoreblob. You can review API changes here

API changes

-             api_version: str, 
-             secondary_hostname: str, 
+             api_version: str = ..., 
+             secondary_hostname: str = ..., 
-             api_version: str, 
-             secondary_hostname: str, 
+             api_version: str = ..., 
+             secondary_hostname: str = ..., 

@yunhaoling
Copy link
Contributor

/azp run python - eventhub - tests

Copy link
Contributor

@yunhaoling yunhaoling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ghost
Copy link

ghost commented Nov 29, 2021

Hello @swathipil!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost
Copy link

ghost commented Nov 29, 2021

Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:

  1. Azure Pipelines

These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check.

Give feedback on this
From the bot dev team

We've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments.

Please reach out to us at [email protected] to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin.

@ghost ghost merged commit aa95b08 into Azure:main Nov 29, 2021
@swathipil swathipil deleted the swathipil/eh/copy-arg-ownership branch November 30, 2021 17:30
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Dec 1, 2021
…into add_body_error

* 'main' of https://github.com/Azure/azure-sdk-for-python: (74 commits)
  Pin Crypto Temporarily (Azure#21950)
  [release-helper] check `default tag` and `target tag` consistency (Azure#21952)
  [EventHubs] remove unused import (Azure#21949)
  [KV] Use shared test-resources.json (Azure#21940)
  [EventHubs] Fix pylint and mypy (Azure#21939)
  fix line in general document sample code (Azure#21936)
  Pipeline auto-discover stress test (Azure#21917)
  resolve the issue the bad condition in dump proxy logs (Azure#21947)
  [KV] Correctly fetch private RSA key material (Azure#21938)
  doc (Azure#21830)
  Sync eng/common directory with azure-sdk-tools for PR 2348 (Azure#21919)
  [EventHubs] ensure ownership arg does not mutate (Azure#20008)
  Fix the type for LROPoller wait timeout (Azure#21913)
  [EventHubs]Update async samples (Azure#21857)
  [AutoRelease] t2-containerservice-2021-11-25-33508 (Azure#21891)
  update for Go (Azure#21898)
  [pipeline] SDK Release helper : 0.0.1 (Azure#21888)
  [AutoRelease] t2-subscription-2021-11-25-24271 (Azure#21892)
  Release issue status (Azure#21887)
  [AutoRelease] t2-datafactory-2021-11-20-87712 (Azure#21840)
  ...
hildurhodd pushed a commit to hildurhodd/azure-sdk-for-python that referenced this pull request Jan 4, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants