-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EventHubs] ensure ownership arg does not mutate #20008
Conversation
/azp run python - eventhub - ci |
Azure Pipelines successfully started running 1 pipeline(s). |
API changes have been detected in API changes - api_version: str,
+ api_version: str = ...,
- secondary_hostname: str,
+ secondary_hostname: str = ...,
- api_version: str,
+ api_version: str = ...,
- secondary_hostname: str,
+ secondary_hostname: str = ..., |
API changes have been detected in API changes - api_version: str,
- secondary_hostname: str,
+ api_version: str = ...,
+ secondary_hostname: str = ...,
- api_version: str,
- secondary_hostname: str,
+ api_version: str = ...,
+ secondary_hostname: str = ..., |
...heckpointstoreblob-aio/azure/eventhub/extensions/checkpointstoreblobaio/_blobstoragecsaio.py
Show resolved
Hide resolved
...heckpointstoreblob-aio/azure/eventhub/extensions/checkpointstoreblobaio/_blobstoragecsaio.py
Show resolved
Hide resolved
/azp run python - eventhub - tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Azure Pipelines successfully started running 1 pipeline(s). |
Hello @swathipil! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:
These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check. Give feedback on thisFrom the bot dev teamWe've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments. Please reach out to us at [email protected] to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin. |
…into add_body_error * 'main' of https://github.com/Azure/azure-sdk-for-python: (74 commits) Pin Crypto Temporarily (Azure#21950) [release-helper] check `default tag` and `target tag` consistency (Azure#21952) [EventHubs] remove unused import (Azure#21949) [KV] Use shared test-resources.json (Azure#21940) [EventHubs] Fix pylint and mypy (Azure#21939) fix line in general document sample code (Azure#21936) Pipeline auto-discover stress test (Azure#21917) resolve the issue the bad condition in dump proxy logs (Azure#21947) [KV] Correctly fetch private RSA key material (Azure#21938) doc (Azure#21830) Sync eng/common directory with azure-sdk-tools for PR 2348 (Azure#21919) [EventHubs] ensure ownership arg does not mutate (Azure#20008) Fix the type for LROPoller wait timeout (Azure#21913) [EventHubs]Update async samples (Azure#21857) [AutoRelease] t2-containerservice-2021-11-25-33508 (Azure#21891) update for Go (Azure#21898) [pipeline] SDK Release helper : 0.0.1 (Azure#21888) [AutoRelease] t2-subscription-2021-11-25-24271 (Azure#21892) Release issue status (Azure#21887) [AutoRelease] t2-datafactory-2021-11-20-87712 (Azure#21840) ...
#19963