[Key Vault] Correctly fetch private RSA key material #21938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mccoyp
added
KeyVault
Client
mccoyp
requested review from
chlowell,
schaabs and
YalinLi0312
as code owners
YalinLi0312
approved these changes
Nov 30, 2021
|
/check-enforcer override |
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Dec 1, 2021
…into add_body_error * 'main' of https://github.com/Azure/azure-sdk-for-python: (74 commits) Pin Crypto Temporarily (Azure#21950) [release-helper] check `default tag` and `target tag` consistency (Azure#21952) [EventHubs] remove unused import (Azure#21949) [KV] Use shared test-resources.json (Azure#21940) [EventHubs] Fix pylint and mypy (Azure#21939) fix line in general document sample code (Azure#21936) Pipeline auto-discover stress test (Azure#21917) resolve the issue the bad condition in dump proxy logs (Azure#21947) [KV] Correctly fetch private RSA key material (Azure#21938) doc (Azure#21830) Sync eng/common directory with azure-sdk-tools for PR 2348 (Azure#21919) [EventHubs] ensure ownership arg does not mutate (Azure#20008) Fix the type for LROPoller wait timeout (Azure#21913) [EventHubs]Update async samples (Azure#21857) [AutoRelease] t2-containerservice-2021-11-25-33508 (Azure#21891) update for Go (Azure#21898) [pipeline] SDK Release helper : 0.0.1 (Azure#21888) [AutoRelease] t2-subscription-2021-11-25-24271 (Azure#21892) Release issue status (Azure#21887) [AutoRelease] t2-datafactory-2021-11-20-87712 (Azure#21840) ...
hildurhodd
pushed a commit
to hildurhodd/azure-sdk-for-python
that referenced
this pull request
Jan 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pylint checks recently started pointing out a bug in
azure-keyvault-keys. There's just a small typo in how we try to fetch thepattribute of RSA keys: we currently try to get this value from the public key material, but it should be fetched from the private key material instead.