add implementation for checkpointstoretable #19905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jg1255
requested review from
annatisch,
rakshith91,
swathipil and
yunhaoling
as code owners
ghost
added
Event Hubs
customer-reported
|
Thank you for your contribution Jg1255! We will review the pull request and get back to you soon. |
Jg1255
force-pushed
the
josue_third_branch
branch
from
9be9b52 to
2f974c4
Compare
add the test cases add the test file fix test file
Jg1255
force-pushed
the
josue_third_branch
branch
from
2f974c4 to
a6875dd
Compare
|
/azp run python - eventhub - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
swathipil
removed
the
customer-reported
swathipil
reviewed
Jul 23, 2021
...nthub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py
Outdated
Show resolved
Hide resolved
…b/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <[email protected]>
…sdk-for-python into josue_third_branch
swathipil
reviewed
Jul 23, 2021
added 2 commits
August 13, 2021 13:35
swathipil
reviewed
Aug 13, 2021
...nthub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py
Outdated
Show resolved
Hide resolved
...nthub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py
Outdated
Show resolved
Hide resolved
...nthub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py
Outdated
Show resolved
Hide resolved
...nthub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py
Outdated
Show resolved
Hide resolved
| mode=UpdateMode.REPLACE, | ||
| entity=ownership_entity, | ||
| etag=ownership["etag"], | ||
| match_condition=MatchConditions.IfNotModified, |
There was a problem hiding this comment.
hmm, now that I think about it, why are we setting this as the MatchCondition? is this what Baffy did in JS?
There was a problem hiding this comment.
I think we should remove this, b/c it implies that we only update the entity if it has not been modified before. However, if we call this method twice (or more) on the same entity, it should update it twice (or more).
There was a problem hiding this comment.
so we actually need it cause without the match condition it will not update the owner_id and raise an exception
There was a problem hiding this comment.
that's weird, but since we're not releasing this rn, I can check if this is the right approach later
...nthub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py
Outdated
Show resolved
Hide resolved
sdk/eventhub/azure-eventhub-checkpointstoretable/tests/test_storage_table_partition_manager.py
Show resolved
Hide resolved
sdk/eventhub/azure-eventhub-checkpointstoretable/tests/test_storage_table_partition_manager.py
Show resolved
Hide resolved
sdk/eventhub/azure-eventhub-checkpointstoretable/tests/test_storage_table_partition_manager.py
Show resolved
Hide resolved
Comment on lines
-2
to
+4
| aiohttp>=3.0; python_version >= '3.5' | ||
| ../../core/azure-core | ||
| ../azure-eventhub | ||
| ../../tables/azure-data-tables |
There was a problem hiding this comment.
we shouldn't be touching this file at all since this is actually a management plane library. We on the data plane team are not in charge of this library. Let's undo these changes
There was a problem hiding this comment.
so undoing the changes would mean adding this line again:
aiohttp>=3.0; python_version >= '3.5'
and removing these:
../../core/azure-core
../azure-eventhub
../../tables/azure-data-tables
…b/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <[email protected]>
…b/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <[email protected]>
…b/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <[email protected]>
…b/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <[email protected]>
…b/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <[email protected]>
…orage_table_partition_manager.py Co-authored-by: swathipil <[email protected]>
…orage_table_partition_manager.py Co-authored-by: swathipil <[email protected]>
…orage_table_partition_manager.py Co-authored-by: swathipil <[email protected]>
…b/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <[email protected]>
…b/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <[email protected]>
…b/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <[email protected]>
…b/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <[email protected]>
…b/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <[email protected]>
…b/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <[email protected]>
…b/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <[email protected]>
|
/azp run python - eventhub - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
swathipil
reviewed
Aug 13, 2021
sdk/eventhub/azure-eventhub-checkpointstoretable/tests/test_storage_table_partition_manager.py
Show resolved
Hide resolved
sdk/eventhub/azure-eventhub-checkpointstoretable/tests/test_storage_table_partition_manager.py
Show resolved
Hide resolved
sdk/eventhub/azure-eventhub-checkpointstoretable/tests/test_storage_table_partition_manager.py
Show resolved
Hide resolved
sdk/eventhub/azure-eventhub-checkpointstoretable/tests/test_storage_table_partition_manager.py
Show resolved
Hide resolved
sdk/eventhub/azure-eventhub-checkpointstoretable/tests/test_storage_table_partition_manager.py
Show resolved
Hide resolved
sdk/eventhub/azure-eventhub-checkpointstoretable/tests/test_storage_table_partition_manager.py
Show resolved
Hide resolved
Comment on lines
-2
to
+4
| aiohttp>=3.0; python_version >= '3.5' | ||
| ../../core/azure-core | ||
| ../azure-eventhub | ||
| ../../tables/azure-data-tables |
There was a problem hiding this comment.
so undoing the changes would mean adding this line again:
aiohttp>=3.0; python_version >= '3.5'
and removing these:
../../core/azure-core
../azure-eventhub
../../tables/azure-data-tables
chradek
approved these changes
Aug 13, 2021
There was a problem hiding this comment.
Thank you for getting this implementation put together! And thanks @swathipil for reviewing!
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Aug 23, 2021
…into have_pipelines_support_rest * 'main' of https://github.com/Azure/azure-sdk-for-python: (108 commits) Enable API review approval check for Java spring packages (Azure#20311) [AutoRelease] t2-iothubprovisioningservices-2021-07-15-81882 (Azure#19816) Increment package version after release of azure-eventgrid (Azure#20204) Sync eng/common directory with azure-sdk-tools for PR 1909 (Azure#20298) Rename attrs is metrics (Azure#20236) [EventHubs] checkpointstoretable - skip tests until env vars configured (Azure#20289) Update to use timespan (Azure#20233) Prevent wildcard expansion in git sparse checkout add (Azure#20267) Fix typo and polish the key concepts (Azure#18407) Fix IOT Device Update readme issue (Azure#18752) Add context manager API to azure.identity credentials (Azure#19746) Add support for 'files' configuration (Azure#20272) Update main for 30-close.py (Azure#20287) [AutoRelease] t2-purview-2021-08-13-30358 (Azure#20260) add implementation for checkpointstoretable (Azure#19905) Fix resource clean-up script (Azure#20273) [Tables] Fix bug in update mode (Azure#20264) Add Rest Method checks to Prepare-Release (Azure#20275) Update release date (Azure#20270) Update the release date for ACS chat 1.1.0b1 (Azure#20277) ...
iscai-msft
pushed a commit
that referenced
this pull request
Sep 29, 2021
* add implementation add the test cases add the test file fix test file * fix pylint * fix pylint * fix pylint * fix pylint * fix pylint * fix pylint * fix pylint * fix pylint * fix pylint * Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <[email protected]> * new update * Update shared_requirements.txt Co-authored-by: swathipil <[email protected]> * environment * redo * redo * redo * changed variable name * changed variable name * Update sdk/eventhub/azure-eventhub-checkpointstoretable/tests/test_storage_table_partition_manager.py Co-authored-by: Sean Kane <[email protected]> * update on test file * update on test file * update on test file * update based on feedack * new update * update * update * update * Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: chradek <[email protected]> * new update * new * new * new * new * new * update on spacing * Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: chradek <[email protected]> * Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: chradek <[email protected]> * Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: chradek <[email protected]> * Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: chradek <[email protected]> * new update * update * update on test file * Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <[email protected]> * Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <[email protected]> * update * Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <[email protected]> * update * update * Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <[email protected]> * Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <[email protected]> * Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <[email protected]> * Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <[email protected]> * Update sdk/eventhub/azure-eventhub-checkpointstoretable/tests/test_storage_table_partition_manager.py Co-authored-by: swathipil <[email protected]> * Update sdk/eventhub/azure-eventhub-checkpointstoretable/tests/test_storage_table_partition_manager.py Co-authored-by: swathipil <[email protected]> * Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <[email protected]> * Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <[email protected]> * Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <[email protected]> * Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <[email protected]> * update * update * Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <[email protected]> * Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <[email protected]> * Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <[email protected]> * update * Update sdk/eventhub/azure-eventhub-checkpointstoretable/tests/test_storage_table_partition_manager.py Co-authored-by: swathipil <[email protected]> * update * Update sdk/eventhub/azure-eventhub-checkpointstoretable/tests/test_storage_table_partition_manager.py Co-authored-by: swathipil <[email protected]> * update * update * update * update * update * update * Revert "update" This reverts commit d2dbb2a. * update * update * update * newupdate * update * update * Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <[email protected]> * update * update * update * update * update * update * update * update * update * update * update * update * update * update * update * update * Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <[email protected]> * Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <[email protected]> * Update sdk/eventhub/azure-eventhub-checkpointstoretable/samples/receive_events_using_checkpoint_store.py Co-authored-by: swathipil <[email protected]> * Update sdk/eventhub/azure-eventhub-checkpointstoretable/setup.py Co-authored-by: swathipil <[email protected]> * Update sdk/eventhub/azure-eventhub-checkpointstoretable/tests/test_storage_table_partition_manager.py Co-authored-by: swathipil <[email protected]> * Update sdk/eventhub/azure-eventhub-checkpointstoretable/tests/test_storage_table_partition_manager.py Co-authored-by: swathipil <[email protected]> * update * update * update * update * update * update * p * update * update * Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <[email protected]> * Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <[email protected]> * Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <[email protected]> * Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <[email protected]> * Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <[email protected]> * Update sdk/eventhub/azure-eventhub-checkpointstoretable/tests/test_storage_table_partition_manager.py Co-authored-by: swathipil <[email protected]> * Update sdk/eventhub/azure-eventhub-checkpointstoretable/tests/test_storage_table_partition_manager.py Co-authored-by: swathipil <[email protected]> * Update sdk/eventhub/azure-eventhub-checkpointstoretable/tests/test_storage_table_partition_manager.py Co-authored-by: swathipil <[email protected]> * Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <[email protected]> * Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <[email protected]> * Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <[email protected]> * Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <[email protected]> * Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <[email protected]> * Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <[email protected]> * Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <[email protected]> * update * update * update Co-authored-by: Josue Garcia <[email protected]> Co-authored-by: swathipil <[email protected]> Co-authored-by: Sean Kane <[email protected]> Co-authored-by: chradek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implementation changes made to checkpointstoretable