Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EventHubs] claim_ownership in checkpointstoreblob mutates argument #19963

Closed
swathipil opened this issue Jul 27, 2021 · 0 comments
Closed

[EventHubs] claim_ownership in checkpointstoreblob mutates argument #19963

swathipil opened this issue Jul 27, 2021 · 0 comments
Assignees
@swathipil
Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs Messaging Messaging crew MQ This issue is part of a "milestone of quality" initiative. P0
Milestone
Backlog

Comments

@swathipil
Copy link
Member

Currently, claim_ownership on CheckpointStoreBlob mutates the ownership object that is passed in. It also unnecessarily adds a metadata with ownerid to ownership dict although owner_id is already in ownership. Need to:

  1. remove metadata here and here, and remove passing in metadata. create metadata = ownerid: ownership['owner_id'] before this line.
  2. create/return new updated_ownership object before here and add etag and last_modified to the new object, so that the original object is not mutated
  3. TEST THOROUGHLY to make sure nothing breaks.
@swathipil swathipil added Event Hubs Client This issue points to a problem in the data-plane of the library. Messaging Messaging crew labels Jul 27, 2021
@swathipil swathipil self-assigned this Jul 27, 2021
@swathipil swathipil added this to the Backlog milestone Jul 27, 2021
@swathipil swathipil mentioned this issue Jul 30, 2021
Merged
@yunhaoling yunhaoling added the MQ This issue is part of a "milestone of quality" initiative. label Oct 5, 2021
@yunhaoling yunhaoling added the P0 label Nov 16, 2021
ghost pushed a commit that referenced this issue Nov 29, 2021
@swathipil
[EventHubs] ensure ownership arg does not mutate (#20008)
aa95b08 
#19963
hildurhodd pushed a commit to hildurhodd/azure-sdk-for-python that referenced this issue Jan 4, 2022
@swathipil
[EventHubs] ensure ownership arg does not mutate (Azure#20008)
b5811f9 
Azure#19963
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@swathipil swathipil

Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs Messaging Messaging crew MQ This issue is part of a "milestone of quality" initiative. P0
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@yunhaoling @swathipil