-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sdk for Content Safety #34933
Add sdk for Content Safety #34933
Conversation
@mengaims could you please update the codeowners file. We always recommend putting 2 owners in the list - https://github.com/Azure/azure-sdk-for-net/blob/main/.github/CODEOWNERS |
/cc: @heaths for review/service buddy. |
sdk/contentsafety/Azure.AI.ContentSafety/api/Azure.AI.netstandard2.0.cs
Outdated
Show resolved
Hide resolved
sdk/contentsafety/Azure.AI.ContentSafety/api/Azure.AI.netstandard2.0.cs
Outdated
Show resolved
Hide resolved
sdk/contentsafety/Azure.AI.ContentSafety/api/Azure.AI.netstandard2.0.cs
Outdated
Show resolved
Hide resolved
sdk/contentsafety/Azure.AI.ContentSafety/api/Azure.AI.ContentSafety.netstandard2.0.cs
Show resolved
Hide resolved
@pallavit Updated, please check the latest code in PR. Btw, do I need any other changes like changing the name of PR? |
@heaths I've already updated following content in this PR:
Could you help have one round of review of them and trigger the CI pipeline run? And here are the items WIP:
Please let me know if I have other things missing. |
@m-nash should the onboarding tool be creating the pipelines automatically? @mengaims there's no pipeline for me to approve, but one was not created which seems the onboarding wizard should've taken care of. Or was there a step skipped in documentation? Looking through our wiki docs, it seems this should've been created automatically. I'll ping a few people offline for clarification. |
/azp run prepare-pipelines |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run net - contentsafety - ci |
Azure Pipelines successfully started running 1 pipeline(s). |
Now that the CI is hooked in it will start to report all the errors. One thing I see is we are missing the tsp-location.yaml file which was used to do the dotnet build /t:GenerateCode. The CI will complain about this. |
@m-nash , thanks for the reminding! I have a question here, the CI will only check the existence of this file or will try run dotnet build /t:GenerateCode according to it? Since I've met some errors when using remote branch in this file, after mitigate with referencing to local repository, it works. The error is: 0m |
@mengaims you need to run |
Yes I've ran it locally. |
comment out unused snippets update test to pass base64 string to binarydata add tsp-location and gen library
API change check APIView has identified API level changes in this PR and created following API reviews. |
…coded base64 string
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.