-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update samples and readme for Content Safety sdk #36784
Conversation
/azp run prepare-pipelines |
Azure Pipelines successfully started running 1 pipeline(s). |
API change check API changes are not detected in this pull request. |
/azp run net - contentsafety - ci |
Azure Pipelines successfully started running 1 pipeline(s). |
@heaths I've added the readme and refine samples for Content Safety in this PR, could you help review? |
Can we please include the SDK in the codeowners file - https://github.com/Azure/azure-sdk-for-net/blob/main/.github/CODEOWNERS |
Already added in previous PR: #34933 |
@heaths I've reply all the comments, please help check and approve, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to run eng/scripts/CodeChecks.ps1 contentsafety to make sure everything is updated.
Actually, I see now why the build didn't fail like it should've: you need to add a package-level "samples" with markdown files that reference the snippets. See https://github.com/Azure/azure-sdk-for-net/blob/main/samples/README.MD.
Hi @heaths , I've added a package-level "samples", please check.
Is it the same case from your side? I'm confused with these errors, since I've double checked there is no invalid project reference in this solution file, and the CI build all look good. Besides I tried to search for some information but did not find the description of this script in https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md. |
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.