-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix custompage issue when there are two #3389
Conversation
test/TestProjects/Authoring-Typespec/src/Generated/Docs/AuthoringClient.xml
Show resolved
Hide resolved
It appears the current regen shows some odd swapping from ctor to Create which doesn't seem right. https://github.com/Azure/azure-sdk-for-net/pull/36206/files#diff-a076be848338a356eff6ca0db1f64dfb29bd595405264856797b6041c97e2ad2R123 Please send an updated regen PR. Did we manually check this against this branch to see that the two lists now generate as expected? |
This is already updated. We have that change in regen PR is because @JoshLove-msft did this change manually Azure/azure-sdk-for-net#36192 and testcommon doesn't have a Yes, I checked their entire spec and the generated code is expected. We have test in Pagination-Typespec as well. |
The testcommon library is pinned to a specific version of AutoRest so it doesn't pick up new changes. Should we try to unpin it? |
@m-nash Seems you did this change. Any background here? I create an issue here: Azure/azure-sdk-for-net#36235 |
We can't unpin it, we would either need to sync the release label that is pinned now and create a fix in a hotfix branch and release from there and update the version, OR we need to move this to manual code, we cannot change generated files manually. |
Commented out the download shared source check until this gets resolved #3392 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Validated the fix in the content saftey pr
Fix #3386