Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure.Graph.Rbac is pinned to an old version of generator #36235

Closed
pshao25 opened this issue May 12, 2023 · 2 comments · Fixed by #36244
Closed

Azure.Graph.Rbac is pinned to an old version of generator #36235

pshao25 opened this issue May 12, 2023 · 2 comments · Fixed by #36244
Assignees
@ArthurMa1978
Labels
Graph Mgmt This issue is related to a management-plane library.

Comments

@pshao25
Copy link
Member

pshao25 commented May 12, 2023

https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/testcommon/Azure.Graph.Rbac/src/Azure.Graph.Rbac.csproj#L16

Azure.Graph.Rbac set to an old version so that @JoshLove-msft did this change #36192. This makes our regen pipeline always has this change https://github.com/Azure/azure-sdk-for-net/pull/36206/files#diff-a076be848338a356eff6ca0db1f64dfb29bd595405264856797b6041c97e2ad2
@pshao25 pshao25 mentioned this issue May 12, 2023
Merged
@github-actions github-actions bot added Client This issue points to a problem in the data-plane of the library. Graph needs-team-triage Workflow: This issue needs the team to triage. labels May 12, 2023
@jsquire
Copy link
Member

jsquire commented May 12, 2023

@ArthurMa1978, @m-nash: Do you folks know anything about that library? It doesn't seem to be a published package and lives in a test directory. It looks to have snuck in with an initial merge for KeyVault and hasn't been worked on outside of fixing up breaks for Core/codegen changes. If we don't know what this is, can we remove it?

@jsquire jsquire added Mgmt This issue is related to a management-plane library. and removed Client This issue points to a problem in the data-plane of the library. needs-team-triage Workflow: This issue needs the team to triage. labels May 12, 2023
@jsquire
Copy link
Member

jsquire commented May 12, 2023

I would also really like to understand why we have a testcommon directory under sdk - if anyone knows.

@m-nash m-nash mentioned this issue May 12, 2023
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Aug 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ArthurMa1978 ArthurMa1978

Labels
Graph Mgmt This issue is related to a management-plane library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move files with manual changes to custom code Azure/azure-sdk-for-net
3 participants
@jsquire @ArthurMa1978 @pshao25