Missing cancellation token for Get methods when generating SDK

[mengaims]

Generated code example:
public virtual async Task GetTextBlocklistAsync(string blocklistName, RequestContext context)

The build error example:

SDK PR
TypeSpec PR

[ArcturusZhang]

I believe this is by-design, this is flagging AZC0002 is because the linter is not properly updated per our decision.
cc @pshao25 @m-nash for more information to share.

As a workaround, please feel free to suppress it @mengaims

[mengaims]

Thanks @ArcturusZhang for the suggestion, I've suppressed AZC0002 and no build error reported now.

[ghost]

Hi @mengaims. Thank you for opening this issue and giving us the opportunity to assist. We believe that this has been addressed. If you feel that further discussion is needed, please add a comment with the text “/unresolve” to remove the “issue-addressed” label and continue the conversation.

[m-nash]

@ArcturusZhang please open / link an issue in azure-sdk-tools to address updating the analyzer.

[pshao25]

@m-nash I think we haven't decided how to resolve the ambiguity between convenience and protocol. So we might put off updating the analyzer till we have a decision.

[m-nash]

We have decided.

We will always use overloads which means for protocol we will have all required parameters when an ambiguous call exists i.e. there is no RequestContent or it is optional. When there is a RequestContent we can leave the optional parameters optional.

We are not moving the location of RequestContext param

public Response<Model> Method(string pathParam, CancellationToken token = default)

//protocol must be all required
public Response Method(string pathParam, RequestContext context)

when there is a request content we don't need to make all params required

public Response<Model> Method(string pathParam, InputModel content, CancellationToken token = default)

//protocol doesn't need to be all required
public Response Method(string pathParam, RequestContent content,  RequestContext context = default)

Optional body param

public Response<Model> Method(string pathParam, InputModel content = null, CancellationToken token = default)

//protocol must be all required
public Response Method(string pathParam, RequestContent content,  RequestContext context)

[pshao25]

Close this as the analyzer update is tracked at Azure/azure-sdk-tools#6145