Only methods returning a Task<Operation<T>> are being instrumented automatically

[heaths]

The InstrumentResultInterceptor is only automatically intercepting and proxying methods that return a Task<Operation<T>>. This was discovered when async tests were completing in tends of milliseconds, while sync tests were taking seconds. For the Conversations SDK, that triggered the 5s local playback error.

To work around this we can manually instrument, but it'd be nice if this was automatic so we didn't have to condition code to instrument.

[JoshLove-msft]

This is specific to SyncOnly tests. Most tests are written as async and will have their operations instrumented here. The UseSyncMethodsInterceptor runs after this to handle running the sync variant of tests. The operation instrumentation doesn't work for SyncOnly tests because the operation method doesn't return a Task.

[heaths]

IIRC, you had a reason why this wouldn't work but I wanted to ask it again here for posterity, but would it not be as easy as switching the order of the interceptors for instrumenting async operations (to bifurcate sync and async) and the one to instrument operations based on method signature?

[heaths]

I tried it, and it's not quite so simple as reversing the order. Some changes to the flow and method name calculation in the UseSyncMethodIntercepter got me further, but it's clear this is going to require more thought and careful evaluation. I have a scenario where this would be handy, but will just work around this for now by using WaitUntil.Started in non-SNIPPET code and disable recordings while I wait - perhaps something akin to what @m-nash suggested in Azure/azure-sdk-tools#2703.

[pallavit]

@heaths do you think there is value in exploring a solution here?

[heaths]

Yes. For sync-only tests that use LROs, we need a way to make sure they are runnable.

[github-actions]

Hi @heaths, we deeply appreciate your input into this project. Regrettably, this issue has remained unresolved for over 2 years and inactive for 30 days, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

[github-actions]

Hi @heaths, we deeply appreciate your input into this project. Regrettably, this issue has remained unresolved for over 2 years and inactive for 30 days, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.