Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AnalyzeConversationResultsKind and discriminators using it have wrong casing #29141

Closed
heaths opened this issue Jun 7, 2022 · 5 comments
Closed

AnalyzeConversationResultsKind and discriminators using it have wrong casing #29141

heaths opened this issue Jun 7, 2022 · 5 comments
Labels
blocking-release Blocks release Cognitive - Language Cognitive - LUIS Service Attention Workflow: This issue is responsible by Azure service team. Service This issue points to a problem in the service.
Milestone
Backlog

Comments

@heaths
Copy link
Member

heaths commented Jun 7, 2022

The 2022-05-15-preview version of the swagger we're using for the CLU 1.1.0-beta.1 release states that AnalyzeConversationResultsKind is an enum with PascalCased values ConversationalPIIResults and ConversationalSummarizationResults when, in fact, the service returns camelCased values conversationalPIIResults and conversationalSummarizationResults respectively.

Per discussion we'll work around this for now for the SDK release.

/cc @ChongTang @mshaban-msft @kristapratico
@heaths heaths added Service Attention Workflow: This issue is responsible by Azure service team. Service This issue points to a problem in the service. Cognitive - Language labels Jun 7, 2022
@heaths heaths added this to the [2022] August milestone Jun 7, 2022
heaths added a commit to heaths/azure-sdk-for-net that referenced this issue Jun 7, 2022
@heaths
Add swagger transforms
d225af6 
Works around Azure#29141 and Azure#29143
@heaths heaths self-assigned this Jun 9, 2022
heaths added a commit that referenced this issue Jun 14, 2022
@heaths
Prepare Conversations Language Understanding SDK 1.1.0-beta.1 (#29144)
45c6d8e 
* Convert to DPG with HLC models

* Ignore long sync LRO test

Caused by #29140 (seemingly)

* Add swagger transforms

Works around #29141 and #29143

* Convert to DPG

Also fixes #26379

* Update public APIs and documentation

* Resolve PR feedback

* Resolve offline feedback

* Update generated code
@heaths
Copy link
Member Author

heaths commented Jun 15, 2022

We're no longer shipping models as part of our DPG work, but this is something we may have to work around for a future 1.1 beta.

@heaths heaths mentioned this issue Jun 29, 2022
Merged
Yao725 referenced this issue in shreyks/azure-sdk-for-net Jul 6, 2022
@heaths
Release Conversations Language Understanding SDK 1.1.0-beta.1 (Azure#…
06c767b 
…29542)

* Prepare Conversations Language Understanding SDK 1.1.0-beta.1

* Convert to DPG with HLC models
* Ignore long sync LRO test

  Caused by Azure#29140 (seemingly)

* Add swagger transforms

  Works around Azure#29141 and Azure#29143

* Convert to DPG

  Also fixes Azure#26379

* Update public APIs and documentation
* Resolve PR feedback
* Resolve offline feedback
* Update generated code

* Stop always recording authoring tests

* Update samples

* Update CHANGELOG for release
zhihaoxue pushed a commit to zhihaoxue/azure-sdk-for-net that referenced this issue Jul 27, 2022
@heaths @zhihaoxue
Prepare Conversations Language Understanding SDK 1.1.0-beta.1 (Azure#…
154920f 
…29144)

* Convert to DPG with HLC models

* Ignore long sync LRO test

Caused by Azure#29140 (seemingly)

* Add swagger transforms

Works around Azure#29141 and Azure#29143

* Convert to DPG

Also fixes Azure#26379

* Update public APIs and documentation

* Resolve PR feedback

* Resolve offline feedback

* Update generated code
@jsquire jsquire modified the milestones: 2022-08, Backlog Sep 6, 2022
@heaths heaths modified the milestones: Backlog, 2022-11 Oct 26, 2022
@heaths heaths mentioned this issue Oct 27, 2022
Merged
heaths added a commit to heaths/azure-sdk-for-net that referenced this issue Oct 27, 2022
@heaths
Work around casing problem for AnalyzeConversationResultKind
828dacd 
Workaround for Azure#29141
heaths added a commit that referenced this issue Oct 27, 2022
@heaths
Work around casing problem for AnalyzeConversationResultKind (#32078)
8dddea1 
Workaround for #29141
@heaths heaths mentioned this issue Nov 1, 2022
Open
@heaths
Copy link
Member Author

heaths commented Nov 1, 2022

We still aren't generating models for 1.1 so pushing this out further. When we generate models, we may need to opt into a case-insensitive comparison depending on how Azure/autorest.csharp#2826 goes.

@heaths heaths modified the milestones: 2022-11, Backlog Nov 1, 2022
sofiar-msft pushed a commit to sofiar-msft/azure-sdk-for-net that referenced this issue Dec 7, 2022
@heaths @sofiar-msft
Prepare Conversations Language Understanding SDK 1.1.0-beta.1 (Azure#…
bc8ab04 
…29144)

* Convert to DPG with HLC models

* Ignore long sync LRO test

Caused by Azure#29140 (seemingly)

* Add swagger transforms

Works around Azure#29141 and Azure#29143

* Convert to DPG

Also fixes Azure#26379

* Update public APIs and documentation

* Resolve PR feedback

* Resolve offline feedback

* Update generated code
sofiar-msft referenced this issue in sofiar-msft/azure-sdk-for-net Dec 7, 2022
@heaths @sofiar-msft
Release Conversations Language Understanding SDK 1.1.0-beta.1 (Azure#…
cd13a55 
…29542)

* Prepare Conversations Language Understanding SDK 1.1.0-beta.1

* Convert to DPG with HLC models
* Ignore long sync LRO test

  Caused by Azure#29140 (seemingly)

* Add swagger transforms

  Works around Azure#29141 and Azure#29143

* Convert to DPG

  Also fixes Azure#26379

* Update public APIs and documentation
* Resolve PR feedback
* Resolve offline feedback
* Update generated code

* Stop always recording authoring tests

* Update samples

* Update CHANGELOG for release
sofiar-msft pushed a commit to sofiar-msft/azure-sdk-for-net that referenced this issue Dec 7, 2022
@heaths @sofiar-msft
Work around casing problem for AnalyzeConversationResultKind (Azure#3…
c3f5972 
…2078)

Workaround for Azure#29141
@ghost
Copy link

ghost commented Jan 30, 2023

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @cahann, @kayousef.

Issue Details

The 2022-05-15-preview version of the swagger we're using for the CLU 1.1.0-beta.1 release states that AnalyzeConversationResultsKind is an enum with PascalCased values ConversationalPIIResults and ConversationalSummarizationResults when, in fact, the service returns camelCased values conversationalPIIResults and conversationalSummarizationResults respectively.

Per discussion we'll work around this for now for the SDK release.

/cc @ChongTang @mshaban-msft @kristapratico

Author: heaths
Assignees: heaths
Labels:

Service Attention, blocking-release, Service, Cognitive - LUIS, Cognitive - Language
Milestone: Backlog

@heaths heaths removed their assignment Jul 6, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 7, 2024

Hi @heaths, we deeply appreciate your input into this project. Regrettably, this issue has remained unresolved for over 2 years and inactive for 30 days, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

1 similar comment
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2024

Hi @heaths, we deeply appreciate your input into this project. Regrettably, this issue has remained unresolved for over 2 years and inactive for 30 days, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 8, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jul 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
blocking-release Blocks release Cognitive - Language Cognitive - LUIS Service Attention Workflow: This issue is responsible by Azure service team. Service This issue points to a problem in the service.
Projects
Azure SDK for Cognitive Services - Language
Status: Done
Milestone
Backlog
Development

No branches or pull requests
3 participants
@jsquire @heaths @kristapratico