Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

confidenceScore should be confidence in the SDK #29143

Closed
heaths opened this issue Jun 7, 2022 · 2 comments
Closed

confidenceScore should be confidence in the SDK #29143

heaths opened this issue Jun 7, 2022 · 2 comments
Labels
Cognitive - Language late-blocker Changes based on review feedback before imminent release. Service Attention Workflow: This issue is responsible by Azure service team. Service This issue points to a problem in the service.

Comments

@heaths
Copy link
Member

heaths commented Jun 7, 2022

The 2022-05-15-preview version of the swagger we're using for the CLU 1.1.0-beta.1 release contains confidenceScore but this - like with Question Answering - should have an x-ms-client-name of confidence. The generated models should not have the "Score" suffix per previous SDK architect review.

/cc @ChongTang @mshaban-msft @kristapratico
@heaths heaths added Service Attention Workflow: This issue is responsible by Azure service team. Service This issue points to a problem in the service. Cognitive - Language labels Jun 7, 2022
heaths added a commit to heaths/azure-sdk-for-net that referenced this issue Jun 7, 2022
@heaths
Add swagger transforms
d225af6 
Works around Azure#29141 and Azure#29143
heaths added a commit that referenced this issue Jun 14, 2022
@heaths
Prepare Conversations Language Understanding SDK 1.1.0-beta.1 (#29144)
45c6d8e 
* Convert to DPG with HLC models

* Ignore long sync LRO test

Caused by #29140 (seemingly)

* Add swagger transforms

Works around #29141 and #29143

* Convert to DPG

Also fixes #26379

* Update public APIs and documentation

* Resolve PR feedback

* Resolve offline feedback

* Update generated code
@heaths heaths mentioned this issue Jun 29, 2022
Merged
Yao725 referenced this issue in shreyks/azure-sdk-for-net Jul 6, 2022
@heaths
Release Conversations Language Understanding SDK 1.1.0-beta.1 (Azure#…
06c767b 
…29542)

* Prepare Conversations Language Understanding SDK 1.1.0-beta.1

* Convert to DPG with HLC models
* Ignore long sync LRO test

  Caused by Azure#29140 (seemingly)

* Add swagger transforms

  Works around Azure#29141 and Azure#29143

* Convert to DPG

  Also fixes Azure#26379

* Update public APIs and documentation
* Resolve PR feedback
* Resolve offline feedback
* Update generated code

* Stop always recording authoring tests

* Update samples

* Update CHANGELOG for release
zhihaoxue pushed a commit to zhihaoxue/azure-sdk-for-net that referenced this issue Jul 27, 2022
@heaths @zhihaoxue
Prepare Conversations Language Understanding SDK 1.1.0-beta.1 (Azure#…
154920f 
…29144)

* Convert to DPG with HLC models

* Ignore long sync LRO test

Caused by Azure#29140 (seemingly)

* Add swagger transforms

Works around Azure#29141 and Azure#29143

* Convert to DPG

Also fixes Azure#26379

* Update public APIs and documentation

* Resolve PR feedback

* Resolve offline feedback

* Update generated code
sofiar-msft pushed a commit to sofiar-msft/azure-sdk-for-net that referenced this issue Dec 7, 2022
@heaths @sofiar-msft
Prepare Conversations Language Understanding SDK 1.1.0-beta.1 (Azure#…
bc8ab04 
…29144)

* Convert to DPG with HLC models

* Ignore long sync LRO test

Caused by Azure#29140 (seemingly)

* Add swagger transforms

Works around Azure#29141 and Azure#29143

* Convert to DPG

Also fixes Azure#26379

* Update public APIs and documentation

* Resolve PR feedback

* Resolve offline feedback

* Update generated code
sofiar-msft referenced this issue in sofiar-msft/azure-sdk-for-net Dec 7, 2022
@heaths @sofiar-msft
Release Conversations Language Understanding SDK 1.1.0-beta.1 (Azure#…
cd13a55 
…29542)

* Prepare Conversations Language Understanding SDK 1.1.0-beta.1

* Convert to DPG with HLC models
* Ignore long sync LRO test

  Caused by Azure#29140 (seemingly)

* Add swagger transforms

  Works around Azure#29141 and Azure#29143

* Convert to DPG

  Also fixes Azure#26379

* Update public APIs and documentation
* Resolve PR feedback
* Resolve offline feedback
* Update generated code

* Stop always recording authoring tests

* Update samples

* Update CHANGELOG for release
@heaths heaths added the late-blocker Changes based on review feedback before imminent release. label May 30, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 7, 2024

Hi @heaths, we deeply appreciate your input into this project. Regrettably, this issue has remained unresolved for over 2 years and inactive for 30 days, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

1 similar comment
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2024

Hi @heaths, we deeply appreciate your input into this project. Regrettably, this issue has remained unresolved for over 2 years and inactive for 30 days, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 8, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jul 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Cognitive - Language late-blocker Changes based on review feedback before imminent release. Service Attention Workflow: This issue is responsible by Azure service team. Service This issue points to a problem in the service.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@heaths