Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test-Proxy] Make test recorder more efficient when recording LROs #2703

Open
m-nash opened this issue Jan 27, 2022 · 2 comments
Open

[Test-Proxy] Make test recorder more efficient when recording LROs #2703

m-nash opened this issue Jan 27, 2022 · 2 comments
Assignees
Labels
Central-EngSys This issue is owned by the Engineering System team. Test-Proxy Anything relating to test-proxy requests or issues.

Comments

@m-nash
Copy link
Member

m-nash commented Jan 27, 2022

Library name

Azure.Core.TestFramework

Please describe the feature.

Right now when an LRO is recorded in the worst case where the service doesn't send back a Retry-After header the default will be to query for status every second. In management plane quite a few of our test cases take 15-60 minutes to record which results in an extremely large file which adds to test playback execution time since the recorder will need to find and deserialize all of those.

The enhancement would be to give the recorder context that it is recording an LRO and only log

  1. Initial request
  2. First retry after request
  3. last retry before final response
  4. final response

With this set you can properly test an LRO scenario as all other recordings will be identical to Azure/azure-sdk-for-net#2. We could also potentially look at only recording if current != last just in case somewhere in the middle we get a slightly different response (I don't think this is possible).

@azure-sdk
Copy link
Collaborator

Label prediction was below confidence level 0.6 for Model:ServiceLabels: 'Cognitive - Form Recognizer:0.26791137,Service Bus:0.17913784,Storage:0.07234221'

@JoshLove-msft
Copy link
Member

This should probably be a Test Proxy enhancement. One idea we had was to do a pass at the end of recording an LRO test where we remove duplicate request/response pairs. The mgmt team already has a script that they use to do this cleanup.

@JoshLove-msft JoshLove-msft transferred this issue from Azure/azure-sdk-for-net Feb 8, 2022
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Feb 8, 2022
@JoshLove-msft JoshLove-msft removed their assignment Feb 8, 2022
@scbedd scbedd changed the title Make test recorder more efficient when recording LROs [Test-Proxy] Make test recorder more efficient when recording LROs Feb 16, 2022
@kurtzeborn kurtzeborn added Central-EngSys This issue is owned by the Engineering System team. and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Mar 7, 2022
@scbedd scbedd added the Test-Proxy Anything relating to test-proxy requests or issues. label May 11, 2022
@kurtzeborn kurtzeborn moved this from 🤔Triage to 📋Backlog in Azure SDK EngSys 🚢🎉 Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team. Test-Proxy Anything relating to test-proxy requests or issues.
Projects
Status: 📋 Backlog
Development

No branches or pull requests

5 participants